You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@twill.apache.org by chtyim <gi...@git.apache.org> on 2015/10/10 03:27:38 UTC

[GitHub] incubator-twill pull request: (TWILL-148) Allow setting of env var...

GitHub user chtyim opened a pull request:

    https://github.com/apache/incubator-twill/pull/69

    (TWILL-148) Allow setting of env variables

    - Added methods to TwillPreparer for setting env for runnables

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chtyim/incubator-twill feature/TWILL-148

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-twill/pull/69.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #69
    
----
commit 6e2d515f5cffb5bcc15f0063a75e79d850876fb2
Author: Terence Yim <ch...@apache.org>
Date:   2015-10-10T01:27:17Z

    (TWILL-148) Allow setting of env variables
    - Added methods to TwillPreparer for setting env for runnables

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-twill pull request: (TWILL-148) Allow setting of env var...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-twill/pull/69


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-twill pull request: (TWILL-148) Allow setting of env var...

Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:

    https://github.com/apache/incubator-twill/pull/69#issuecomment-147021445
  
    +1
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-twill pull request: (TWILL-148) Allow setting of env var...

Posted by chtyim <gi...@git.apache.org>.
Github user chtyim commented on the pull request:

    https://github.com/apache/incubator-twill/pull/69#issuecomment-147020901
  
    Checkstyle failure in a test class... :(


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-twill pull request: (TWILL-148) Allow setting of env var...

Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:

    https://github.com/apache/incubator-twill/pull/69#issuecomment-147020669
  
    All CI break?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---