You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/01 15:52:42 UTC

[GitHub] [kafka] jolshan commented on pull request #10590: KAFKA-5761: support ByteBuffer as value in ProducerRecord and avoid redundant serialization when it's used

jolshan commented on pull request #10590:
URL: https://github.com/apache/kafka/pull/10590#issuecomment-852237161


   Seems reasonable to me. One small thing I would say is to add comments to `tryAppend` and `append` like the versions that use the byte[] parameter. And of course, we will still need a committer to review this code before it can be merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org