You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/11/18 02:12:15 UTC
[GitHub] [apisix] cache-missing opened a new pull request #5540: 🐞 fix(plugin): fix str concat error
cache-missing opened a new pull request #5540:
URL: https://github.com/apache/apisix/pull/5540
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. Use "request review" to notify the reviewer once you have resolved the review
-->
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] lijing-21 edited a comment on pull request #5540: fix: str concat in error call
Posted by GitBox <gi...@apache.org>.
lijing-21 edited a comment on pull request #5540:
URL: https://github.com/apache/apisix/pull/5540#issuecomment-1014999881
Hi @cache-missing, thank you for your contribution!
Here is the Contributor T-shirt form[1], if you're interested, kindly take a look :)
[1] https://github.com/apache/apisix/blob/master/CONTRIBUTING.md#contributor-t-shirt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on pull request #5540: 🐞 fix(plugin): fix str concat error
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #5540:
URL: https://github.com/apache/apisix/pull/5540#issuecomment-972438004
@cache-missing The PR title is not semantic, please fix it, see https://github.com/zeke/semantic-pull-requests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] lijing-21 commented on pull request #5540: fix: str concat in error call
Posted by GitBox <gi...@apache.org>.
lijing-21 commented on pull request #5540:
URL: https://github.com/apache/apisix/pull/5540#issuecomment-1014999881
Hi @cache-missing , thank you for your contribution!
Now you are eligible to receive the very special [Contributor T-shirt](https://github.com/apache/apisix/blob/master/CONTRIBUTING.md#contributor-t-shirt)！
Just fill out the [Contributors Submissions form](https://docs.google.com/forms/d/e/1FAIpQLSdXEpCs60UK49UlOGdBCQSXr7DYz3enyT4GJPKrYQmYfVLPKQ/viewform)~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5540: fix: str concat in error call
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #5540:
URL: https://github.com/apache/apisix/pull/5540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on a change in pull request #5540: 🐞 fix(plugin): fix str concat error
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #5540:
URL: https://github.com/apache/apisix/pull/5540#discussion_r751863086
##########
File path: apisix/plugin.lua
##########
@@ -264,7 +264,7 @@ function _M.load(config)
local_conf, err = core.config.local_conf(true)
if not local_conf then
-- the error is unrecoverable, so we need to raise it
- error("failed to load the configuration file: ", err)
+ error("failed to load the configuration file: " .. err)
Review comment:
```suggestion
core.log.error("failed to load the configuration file: ", err)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on a change in pull request #5540: fix: str concat in error call
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #5540:
URL: https://github.com/apache/apisix/pull/5540#discussion_r751926905
##########
File path: apisix/plugin.lua
##########
@@ -264,7 +264,7 @@ function _M.load(config)
local_conf, err = core.config.local_conf(true)
if not local_conf then
-- the error is unrecoverable, so we need to raise it
- error("failed to load the configuration file: ", err)
+ error("failed to load the configuration file: " .. err)
Review comment:
got it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] lijing-21 edited a comment on pull request #5540: fix: str concat in error call
Posted by GitBox <gi...@apache.org>.
lijing-21 edited a comment on pull request #5540:
URL: https://github.com/apache/apisix/pull/5540#issuecomment-1014999881
Hi @cache-missing , thank you for your contribution!
We'd like to send you the special [Contributor T-shirt](https://github.com/apache/apisix/blob/master/CONTRIBUTING.md#contributor-t-shirt), you could [fill this form](https://docs.google.com/forms/d/e/1FAIpQLSdXEpCs60UK49UlOGdBCQSXr7DYz3enyT4GJPKrYQmYfVLPKQ/viewform)~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5540: 🐞 fix(plugin): fix str concat error
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #5540:
URL: https://github.com/apache/apisix/pull/5540#discussion_r751886067
##########
File path: apisix/plugin.lua
##########
@@ -264,7 +264,7 @@ function _M.load(config)
local_conf, err = core.config.local_conf(true)
if not local_conf then
-- the error is unrecoverable, so we need to raise it
- error("failed to load the configuration file: ", err)
+ error("failed to load the configuration file: " .. err)
Review comment:
We need to raise error here as it is unrecoverable. Otherwise, APISIX is still in trouble.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] lijing-21 edited a comment on pull request #5540: fix: str concat in error call
Posted by GitBox <gi...@apache.org>.
lijing-21 edited a comment on pull request #5540:
URL: https://github.com/apache/apisix/pull/5540#issuecomment-1014999881
Hi @cache-missing, thank you for your contribution!
We'd like to send you the special Contributor T-shirt[1], you could fill this form[2]~
[1] https://github.com/apache/apisix/blob/master/CONTRIBUTING.md#contributor-t-shirt
[2] https://forms.gle/ycKcJNsjnqajMYzu7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org