You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2016/08/23 00:13:21 UTC
Review Request 51308: GEODE-1811: Marking runtime dependencies as
optional in the pom
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51308/
-----------------------------------------------------------
Review request for geode, Anthony Baker and Mark Bretl.
Repository: geode
Description
-------
We had certain runtime dependencies marked as optional in
geode-core/build.gradle. However, we were only looking for the optional
flag on compile dependencies, so the runtime dependencies were not
marked as optional in the generated pom file.
Diffs
-----
gradle/publish.gradle 768fce43459eb4a0397f055100aac481d8ed89ae
Diff: https://reviews.apache.org/r/51308/diff/
Testing
-------
Thanks,
Dan Smith
Re: Review Request 51308: GEODE-1811: Marking runtime dependencies as
optional in the pom
Posted by Anthony Baker <ab...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51308/#review146460
-----------------------------------------------------------
Ship it!
Ship It!
- Anthony Baker
On Aug. 23, 2016, 12:13 a.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51308/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2016, 12:13 a.m.)
>
>
> Review request for geode, Anthony Baker and Mark Bretl.
>
>
> Repository: geode
>
>
> Description
> -------
>
> We had certain runtime dependencies marked as optional in
> geode-core/build.gradle. However, we were only looking for the optional
> flag on compile dependencies, so the runtime dependencies were not
> marked as optional in the generated pom file.
>
>
> Diffs
> -----
>
> gradle/publish.gradle 768fce43459eb4a0397f055100aac481d8ed89ae
>
> Diff: https://reviews.apache.org/r/51308/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>