You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2021/11/18 23:28:21 UTC
[kudu-CR] [build] fix THIRDPARTY DIR used in build mini cluster binaries.sh
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18035
Change subject: [build] fix THIRDPARTY_DIR used in build_mini_cluster_binaries.sh
......................................................................
[build] fix THIRDPARTY_DIR used in build_mini_cluster_binaries.sh
The base directory used in defining THIRDPARTY_DIR in
build_mini_cluster_binaries.sh was incorrect. When running through an
internal build job, it failed with the following error:
15:06:06 2021/11/18 23:06:06 INFO : + build-support/mini-cluster/build_mini_cluster_binaries.sh
15:06:06 2021/11/18 23:06:06 INFO : Building thirdparty...
15:06:06 2021/11/18 23:06:06 INFO : /grid/0/jenkins/workspace/workspace/CI_Build_CDPD/SOURCES/kudu/build-support/enable_devtoolset_inner.sh: line 35: /thirdparty/build-if-necessary.sh: No such file or directory
This is a follow-up to commit dfb3ce9efe51ced39e3c83e229725e26abeb0136.
Change-Id: I0a6ef017e941002241ef55329c168d9bb9afc218
---
M build-support/mini-cluster/build_mini_cluster_binaries.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/18035/1
--
To view, visit http://gerrit.cloudera.org:8080/18035
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a6ef017e941002241ef55329c168d9bb9afc218
Gerrit-Change-Number: 18035
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] [build] fix THIRDPARTY DIR used in build mini cluster binaries.sh
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.
Change subject: [build] fix THIRDPARTY_DIR used in build_mini_cluster_binaries.sh
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18035
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I0a6ef017e941002241ef55329c168d9bb9afc218
Gerrit-Change-Number: 18035
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [build] fix THIRDPARTY DIR used in build mini cluster binaries.sh
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18035 )
Change subject: [build] fix THIRDPARTY_DIR used in build_mini_cluster_binaries.sh
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18035
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a6ef017e941002241ef55329c168d9bb9afc218
Gerrit-Change-Number: 18035
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Fri, 19 Nov 2021 01:08:38 +0000
Gerrit-HasComments: No
[kudu-CR] [build] fix THIRDPARTY DIR used in build mini cluster binaries.sh
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18035 )
Change subject: [build] fix THIRDPARTY_DIR used in build_mini_cluster_binaries.sh
......................................................................
Patch Set 1: Code-Review+2
Thank you for fixing this!
--
To view, visit http://gerrit.cloudera.org:8080/18035
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a6ef017e941002241ef55329c168d9bb9afc218
Gerrit-Change-Number: 18035
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Fri, 19 Nov 2021 02:00:41 +0000
Gerrit-HasComments: No
[kudu-CR] [build] fix THIRDPARTY DIR used in build mini cluster binaries.sh
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18035 )
Change subject: [build] fix THIRDPARTY_DIR used in build_mini_cluster_binaries.sh
......................................................................
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18035
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a6ef017e941002241ef55329c168d9bb9afc218
Gerrit-Change-Number: 18035
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Fri, 19 Nov 2021 01:09:24 +0000
Gerrit-HasComments: No
[kudu-CR] [build] fix THIRDPARTY DIR used in build mini cluster binaries.sh
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18035 )
Change subject: [build] fix THIRDPARTY_DIR used in build_mini_cluster_binaries.sh
......................................................................
[build] fix THIRDPARTY_DIR used in build_mini_cluster_binaries.sh
The base directory used in defining THIRDPARTY_DIR in
build_mini_cluster_binaries.sh was incorrect. When running through an
internal build job, it failed with the following error:
15:06:06 2021/11/18 23:06:06 INFO : + build-support/mini-cluster/build_mini_cluster_binaries.sh
15:06:06 2021/11/18 23:06:06 INFO : Building thirdparty...
15:06:06 2021/11/18 23:06:06 INFO : /grid/0/jenkins/workspace/workspace/CI_Build_CDPD/SOURCES/kudu/build-support/enable_devtoolset_inner.sh: line 35: /thirdparty/build-if-necessary.sh: No such file or directory
This is a follow-up to commit dfb3ce9efe51ced39e3c83e229725e26abeb0136.
Change-Id: I0a6ef017e941002241ef55329c168d9bb9afc218
Reviewed-on: http://gerrit.cloudera.org:8080/18035
Reviewed-by: Yingchun Lai <ac...@gmail.com>
Tested-by: Yingchun Lai <ac...@gmail.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M build-support/mini-cluster/build_mini_cluster_binaries.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Yingchun Lai: Looks good to me, approved; Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18035
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a6ef017e941002241ef55329c168d9bb9afc218
Gerrit-Change-Number: 18035
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>