You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sid Wagle <sw...@hortonworks.com> on 2015/11/23 22:15:10 UTC
Review Request 40612: Deleting host from cluster does not work on
bleprint deployed cluster
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40612/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sumit Mohanty.
Bugs: AMBARI-14025
https://issues.apache.org/jira/browse/AMBARI-14025
Repository: ambari
Description
-------
_STR:_
1. Decommission node managers
2. Decommission data nodes
3. Stop all components on the host being removed
4. Delete all components on the host being removed
5. Delete the host from the cluster
The last step fails with Internal Server Error.
Caused by: javax.persistence.RollbackException: Exception [EclipseLink-4002] (Eclipse Persistence Services - 2.5.2.v20140319-9ad6abd): org.eclipse.persistence.exceptions.DatabaseException
Internal Exception: java.sql.BatchUpdateException: The DELETE statement conflicted with the REFERENCE constraint "FK_ltask_hrc_id". The conflict occurred in database "v328ade4c5c99344203aca00abaed19feb5AmbariDb", table "dbo.topology_logical_task", column 'physical_task_id'.
Error Code: 547
at org.eclipse.persistence.internal.jpa.transaction.EntityTransactionImpl.commit(EntityTransactionImpl.java:157)
at org.apache.ambari.server.orm.AmbariJpaLocalTxnInterceptor.invoke(AmbariJpaLocalTxnInterceptor.java:91)
at org.apache.ambari.server.state.cluster.ClustersImpl.deleteHostEntityRelationships(ClustersImpl.java:840)
... 94 more
*Note*: Patch includes fix for AMBARI-13934. Request and Stage resource should show correct status after host delete.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java 30da833
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java 2524df8
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 7fcdac9
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java 55d91c7
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 911e3cd
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java d479bfe
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java f04c868
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java 4040c5f
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java 9b63358
Diff: https://reviews.apache.org/r/40612/diff/
Testing
-------
Manually verified.
Unit test in progress.
Thanks,
Sid Wagle
Re: Review Request 40612: Deleting host from cluster does not work on
bleprint deployed cluster
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40612/#review107720
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On Nov. 24, 2015, 4:25 a.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40612/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 4:25 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14025
> https://issues.apache.org/jira/browse/AMBARI-14025
>
>
> Repository: ambari
>
>
> Description
> -------
>
> _STR:_
> 1. Decommission node managers
> 2. Decommission data nodes
> 3. Stop all components on the host being removed
> 4. Delete all components on the host being removed
> 5. Delete the host from the cluster
>
> The last step fails with Internal Server Error.
>
> Caused by: javax.persistence.RollbackException: Exception [EclipseLink-4002] (Eclipse Persistence Services - 2.5.2.v20140319-9ad6abd): org.eclipse.persistence.exceptions.DatabaseException
> Internal Exception: java.sql.BatchUpdateException: The DELETE statement conflicted with the REFERENCE constraint "FK_ltask_hrc_id". The conflict occurred in database "v328ade4c5c99344203aca00abaed19feb5AmbariDb", table "dbo.topology_logical_task", column 'physical_task_id'.
> Error Code: 547
> at org.eclipse.persistence.internal.jpa.transaction.EntityTransactionImpl.commit(EntityTransactionImpl.java:157)
> at org.apache.ambari.server.orm.AmbariJpaLocalTxnInterceptor.invoke(AmbariJpaLocalTxnInterceptor.java:91)
> at org.apache.ambari.server.state.cluster.ClustersImpl.deleteHostEntityRelationships(ClustersImpl.java:840)
> ... 94 more
>
>
> *Note*: Patch includes fix for AMBARI-13934. Request and Stage resource should show correct status after host delete.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java 30da833
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java 2524df8
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 7fcdac9
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java 55d91c7
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 39d4040
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 911e3cd
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java d479bfe
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java f04c868
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java 4040c5f
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java 9b63358
>
> Diff: https://reviews.apache.org/r/40612/diff/
>
>
> Testing
> -------
>
> Manually verified.
> Unit test in progress.
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 40612: Deleting host from cluster does not work on
bleprint deployed cluster
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40612/
-----------------------------------------------------------
(Updated Nov. 24, 2015, 4:25 a.m.)
Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sumit Mohanty.
Changes
-------
Added check for null on the TopologyLogicalTaskEntity
Bugs: AMBARI-14025
https://issues.apache.org/jira/browse/AMBARI-14025
Repository: ambari
Description
-------
_STR:_
1. Decommission node managers
2. Decommission data nodes
3. Stop all components on the host being removed
4. Delete all components on the host being removed
5. Delete the host from the cluster
The last step fails with Internal Server Error.
Caused by: javax.persistence.RollbackException: Exception [EclipseLink-4002] (Eclipse Persistence Services - 2.5.2.v20140319-9ad6abd): org.eclipse.persistence.exceptions.DatabaseException
Internal Exception: java.sql.BatchUpdateException: The DELETE statement conflicted with the REFERENCE constraint "FK_ltask_hrc_id". The conflict occurred in database "v328ade4c5c99344203aca00abaed19feb5AmbariDb", table "dbo.topology_logical_task", column 'physical_task_id'.
Error Code: 547
at org.eclipse.persistence.internal.jpa.transaction.EntityTransactionImpl.commit(EntityTransactionImpl.java:157)
at org.apache.ambari.server.orm.AmbariJpaLocalTxnInterceptor.invoke(AmbariJpaLocalTxnInterceptor.java:91)
at org.apache.ambari.server.state.cluster.ClustersImpl.deleteHostEntityRelationships(ClustersImpl.java:840)
... 94 more
*Note*: Patch includes fix for AMBARI-13934. Request and Stage resource should show correct status after host delete.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java 30da833
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java 2524df8
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 7fcdac9
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java 55d91c7
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 39d4040
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 911e3cd
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java d479bfe
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java f04c868
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java 4040c5f
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java 9b63358
Diff: https://reviews.apache.org/r/40612/diff/
Testing
-------
Manually verified.
Unit test in progress.
Thanks,
Sid Wagle
Re: Review Request 40612: Deleting host from cluster does not work on
bleprint deployed cluster
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40612/
-----------------------------------------------------------
(Updated Nov. 24, 2015, 1:59 a.m.)
Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sumit Mohanty.
Changes
-------
Was missing @Transaction on an intermediate method results in partial commit.
Bugs: AMBARI-14025
https://issues.apache.org/jira/browse/AMBARI-14025
Repository: ambari
Description
-------
_STR:_
1. Decommission node managers
2. Decommission data nodes
3. Stop all components on the host being removed
4. Delete all components on the host being removed
5. Delete the host from the cluster
The last step fails with Internal Server Error.
Caused by: javax.persistence.RollbackException: Exception [EclipseLink-4002] (Eclipse Persistence Services - 2.5.2.v20140319-9ad6abd): org.eclipse.persistence.exceptions.DatabaseException
Internal Exception: java.sql.BatchUpdateException: The DELETE statement conflicted with the REFERENCE constraint "FK_ltask_hrc_id". The conflict occurred in database "v328ade4c5c99344203aca00abaed19feb5AmbariDb", table "dbo.topology_logical_task", column 'physical_task_id'.
Error Code: 547
at org.eclipse.persistence.internal.jpa.transaction.EntityTransactionImpl.commit(EntityTransactionImpl.java:157)
at org.apache.ambari.server.orm.AmbariJpaLocalTxnInterceptor.invoke(AmbariJpaLocalTxnInterceptor.java:91)
at org.apache.ambari.server.state.cluster.ClustersImpl.deleteHostEntityRelationships(ClustersImpl.java:840)
... 94 more
*Note*: Patch includes fix for AMBARI-13934. Request and Stage resource should show correct status after host delete.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java 30da833
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java 2524df8
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 7fcdac9
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java 55d91c7
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 911e3cd
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java d479bfe
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java f04c868
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java 4040c5f
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java 9b63358
Diff: https://reviews.apache.org/r/40612/diff/
Testing
-------
Manually verified.
Unit test in progress.
Thanks,
Sid Wagle
Re: Review Request 40612: Deleting host from cluster does not work on
bleprint deployed cluster
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40612/#review107647
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Nov. 23, 2015, 9:15 p.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40612/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2015, 9:15 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14025
> https://issues.apache.org/jira/browse/AMBARI-14025
>
>
> Repository: ambari
>
>
> Description
> -------
>
> _STR:_
> 1. Decommission node managers
> 2. Decommission data nodes
> 3. Stop all components on the host being removed
> 4. Delete all components on the host being removed
> 5. Delete the host from the cluster
>
> The last step fails with Internal Server Error.
>
> Caused by: javax.persistence.RollbackException: Exception [EclipseLink-4002] (Eclipse Persistence Services - 2.5.2.v20140319-9ad6abd): org.eclipse.persistence.exceptions.DatabaseException
> Internal Exception: java.sql.BatchUpdateException: The DELETE statement conflicted with the REFERENCE constraint "FK_ltask_hrc_id". The conflict occurred in database "v328ade4c5c99344203aca00abaed19feb5AmbariDb", table "dbo.topology_logical_task", column 'physical_task_id'.
> Error Code: 547
> at org.eclipse.persistence.internal.jpa.transaction.EntityTransactionImpl.commit(EntityTransactionImpl.java:157)
> at org.apache.ambari.server.orm.AmbariJpaLocalTxnInterceptor.invoke(AmbariJpaLocalTxnInterceptor.java:91)
> at org.apache.ambari.server.state.cluster.ClustersImpl.deleteHostEntityRelationships(ClustersImpl.java:840)
> ... 94 more
>
>
> *Note*: Patch includes fix for AMBARI-13934. Request and Stage resource should show correct status after host delete.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java 30da833
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java 2524df8
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 7fcdac9
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java 55d91c7
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 911e3cd
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java d479bfe
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java f04c868
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java 4040c5f
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java 9b63358
>
> Diff: https://reviews.apache.org/r/40612/diff/
>
>
> Testing
> -------
>
> Manually verified.
> Unit test in progress.
>
>
> Thanks,
>
> Sid Wagle
>
>