[GitHub] [phoenix] kadirozde commented on a change in pull request #1159: PHOENIX-6402 Allow using local indexes with uncovered columns in the WHERE clause.

[GitBox <gi...@apache.org>]

kadirozde commented on a change in pull request #1159:
URL: https://github.com/apache/phoenix/pull/1159#discussion_r589815433



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/iterate/RegionScannerFactory.java
##########
@@ -205,6 +210,22 @@ public boolean nextRaw(List<Cell> result) throws IOException {
              */
             IndexUtil.wrapResultUsingOffset(env, result, offset, dataColumns,
                 tupleProjector, dataRegion, indexMaintainer, viewConstants, ptr);
+
+            byte[] expBytes = scan.getAttribute(BaseScannerRegionObserver.LOCAL_INDEX_FILTER);

Review comment:
       Does the client issue a new scan for every row to be returned? Otherwise, how does this work if there are multiple rows to be returned to the client for a query? It seems that it is assumed here that the order of rows to be visited in the index CF is the same as the order of of rows to be visited in the data CF (based on how scanTillScanStartRow is used). If so, this assumption is wrong. Maybe I misunderstood the implementation here. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org