You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "hangc0276 (via GitHub)" <gi...@apache.org> on 2023/05/06 10:02:12 UTC
[GitHub] [pulsar] hangc0276 opened a new pull request, #20243: Upgrade rocksDB version to 6.29.4.1 to keep in sync with BookKeeper's RocksDB version
hangc0276 opened a new pull request, #20243:
URL: https://github.com/apache/pulsar/pull/20243
…cksDB version
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://pulsar.apache.org/contribute/develop-semantic-title/)*.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
-->
<!-- Either this PR fixes an issue, -->
Fixes #xyz
<!-- or this PR is one task of an issue -->
Master Issue: #xyz
<!-- If the PR belongs to a PIP, please add the PIP link here -->
PIP: #xyz
<!-- Details of when a PIP is required and how the PIP process work, please see: https://github.com/apache/pulsar/blob/master/wiki/proposals/PIP.md -->
### Motivation
Ugrade the RocksDB's version to 6.29.4.1 to keep in sync with BookKeeper's RocksDB version
### Modifications
<!-- Describe the modifications you've done. -->
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 commented on pull request #20243: [fix] [broker] [Branch-2.10] Upgrade rocksDB version to 6.29.4.1 to keep in sync with BookKeeper's RocksDB version
Posted by "hangc0276 (via GitHub)" <gi...@apache.org>.
hangc0276 commented on PR #20243:
URL: https://github.com/apache/pulsar/pull/20243#issuecomment-1541460450
Hi @dave2wave, I have pushed one PR https://github.com/apache/pulsar/pull/20287 to revert this change. The Pulsar RocksDB version upgrade should be done after the BookKeeper side upgradation. Refer to https://github.com/apache/pulsar/pull/14962#issuecomment-1084192562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #20243: [fix] [broker] [Branch-2.10] Upgrade rocksDB version to 6.29.4.1 to keep in sync with BookKeeper's RocksDB version
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #20243:
URL: https://github.com/apache/pulsar/pull/20243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: PR #20243: [fix] [broker] [Branch-2.10] Upgrade rocksDB version to 6.29.4.1 to keep in sync with BookKeeper's RocksDB version
Posted by Dave Fisher <wa...@apache.org>.
And tests using the 2.9 branch also fail in the same way with the same error.
Please revert these RocksDB upgrades made to 2.9 and 2.10.
Best,
Dave
> On May 9, 2023, at 9:43 AM, Dave Fisher <wa...@apache.org> wrote:
>
> The cherry pick of this RocksDB version is causing a conflict and the 2.10 branch is not usable since this PR was merged.
>
> In the Bookie log:
> java.lang.NoSuchMethodError: 'org.rocksdb.ReadOptions org.rocksdb.ReadOptions.setIterateUpperBound(org.rocksdb.Slice)’
>
> Maybe this is caused by conflict with another PR that was also merged two days ago.
>
> Please look into this.
>
> Best,
> Dave
>
>> On May 9, 2023, at 9:33 AM, dave2wave (via GitHub) <gi...@apache.org> wrote:
>>
>>
>> dave2wave commented on PR #20243:
>> URL: https://github.com/apache/pulsar/pull/20243#issuecomment-1540505700
>>
>> Since the merge of this some of our Pulsar 2.10 integration tests are failing these include errors like:
>>
>>
>> --
>> This is an automated message from the Apache Git Service.
>> To respond to the message, please log on to GitHub and use the
>> URL above to go to the specific comment.
>>
>> To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
>>
>> For queries about this service, please contact Infrastructure at:
>> users@infra.apache.org
>>
>
Re: PR #20243: [fix] [broker] [Branch-2.10] Upgrade rocksDB version to 6.29.4.1 to keep in sync with BookKeeper's RocksDB version
Posted by Dave Fisher <wa...@apache.org>.
The cherry pick of this RocksDB version is causing a conflict and the 2.10 branch is not usable since this PR was merged.
In the Bookie log:
java.lang.NoSuchMethodError: 'org.rocksdb.ReadOptions org.rocksdb.ReadOptions.setIterateUpperBound(org.rocksdb.Slice)’
Maybe this is caused by conflict with another PR that was also merged two days ago.
Please look into this.
Best,
Dave
> On May 9, 2023, at 9:33 AM, dave2wave (via GitHub) <gi...@apache.org> wrote:
>
>
> dave2wave commented on PR #20243:
> URL: https://github.com/apache/pulsar/pull/20243#issuecomment-1540505700
>
> Since the merge of this some of our Pulsar 2.10 integration tests are failing these include errors like:
>
>
> --
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
[GitHub] [pulsar] dave2wave commented on pull request #20243: [fix] [broker] [Branch-2.10] Upgrade rocksDB version to 6.29.4.1 to keep in sync with BookKeeper's RocksDB version
Posted by "dave2wave (via GitHub)" <gi...@apache.org>.
dave2wave commented on PR #20243:
URL: https://github.com/apache/pulsar/pull/20243#issuecomment-1540505700
Since the merge of this some of our Pulsar 2.10 integration tests are failing these include errors like:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org