You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/24 10:33:35 UTC
[GitHub] [flink] JingsongLi opened a new pull request #11201:
[FLINK-16179][hive] Use configuration from TableFactory in hive connector
JingsongLi opened a new pull request #11201: [FLINK-16179][hive] Use configuration from TableFactory in hive connector
URL: https://github.com/apache/flink/pull/11201
## What is the purpose of the change
Now HiveOptions is used for GlobalConfiguration.loadConfiguration() .
It is not natural for table, we should use configuration from TableFactory to enable table config.
## Brief change log
Modify `HiveTableSource` to read config from `TableSourceFactory.Context`.
## Verifying this change
`HiveTableSourceTest.testSourceConfig`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on a change in pull request #11201:
[FLINK-16179][hive] Use configuration from TableFactory in hive connector
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #11201: [FLINK-16179][hive] Use configuration from TableFactory in hive connector
URL: https://github.com/apache/flink/pull/11201#discussion_r383714212
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java
##########
@@ -79,7 +78,8 @@
private static final Logger LOG = LoggerFactory.getLogger(HiveTableSource.class);
- private final JobConf jobConf;
+ private final JobConf hiveConf;
Review comment:
Let's not change the name to `hiveConf` since it's not an instance of `HiveConf`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11201: [FLINK-16179][hive] Use
configuration from TableFactory in hive connector
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11201: [FLINK-16179][hive] Use configuration from TableFactory in hive connector
URL: https://github.com/apache/flink/pull/11201#issuecomment-590261947
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ad474e5d2fe5de5164ff7a87d0dd7c88b99cf3a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2ad474e5d2fe5de5164ff7a87d0dd7c88b99cf3a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2ad474e5d2fe5de5164ff7a87d0dd7c88b99cf3a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11201:
[FLINK-16179][hive] Use configuration from TableFactory in hive connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11201: [FLINK-16179][hive] Use configuration from TableFactory in hive connector
URL: https://github.com/apache/flink/pull/11201#issuecomment-590261947
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ad474e5d2fe5de5164ff7a87d0dd7c88b99cf3a",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150274027",
"triggerID" : "2ad474e5d2fe5de5164ff7a87d0dd7c88b99cf3a",
"triggerType" : "PUSH"
}, {
"hash" : "ab314712781098655191f60f5d92f6e48f2a7fbc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ab314712781098655191f60f5d92f6e48f2a7fbc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2ad474e5d2fe5de5164ff7a87d0dd7c88b99cf3a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150274027)
* ab314712781098655191f60f5d92f6e48f2a7fbc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #11201: [FLINK-16179][hive]
Use configuration from TableFactory in hive connector
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #11201: [FLINK-16179][hive] Use configuration from TableFactory in hive connector
URL: https://github.com/apache/flink/pull/11201#issuecomment-590257250
CC: @lirui-apache
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11201:
[FLINK-16179][hive] Use configuration from TableFactory in hive connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11201: [FLINK-16179][hive] Use configuration from TableFactory in hive connector
URL: https://github.com/apache/flink/pull/11201#issuecomment-590261947
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ad474e5d2fe5de5164ff7a87d0dd7c88b99cf3a",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150274027",
"triggerID" : "2ad474e5d2fe5de5164ff7a87d0dd7c88b99cf3a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2ad474e5d2fe5de5164ff7a87d0dd7c88b99cf3a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150274027)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi merged pull request #11201: [FLINK-16179][hive]
Use configuration from TableFactory in hive connector
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #11201: [FLINK-16179][hive] Use configuration from TableFactory in hive connector
URL: https://github.com/apache/flink/pull/11201
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11201: [FLINK-16179][hive] Use
configuration from TableFactory in hive connector
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11201: [FLINK-16179][hive] Use configuration from TableFactory in hive connector
URL: https://github.com/apache/flink/pull/11201#issuecomment-590258147
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 2ad474e5d2fe5de5164ff7a87d0dd7c88b99cf3a (Mon Feb 24 10:36:42 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #11201: [FLINK-16179][hive]
Use configuration from TableFactory in hive connector
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #11201: [FLINK-16179][hive] Use configuration from TableFactory in hive connector
URL: https://github.com/apache/flink/pull/11201#issuecomment-590827769
Thanks @lirui-apache for reviewing. Merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #11201:
[FLINK-16179][hive] Use configuration from TableFactory in hive connector
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #11201: [FLINK-16179][hive] Use configuration from TableFactory in hive connector
URL: https://github.com/apache/flink/pull/11201#discussion_r383720992
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java
##########
@@ -79,7 +78,8 @@
private static final Logger LOG = LoggerFactory.getLogger(HiveTableSource.class);
- private final JobConf jobConf;
+ private final JobConf hiveConf;
Review comment:
OK, revert to `jobConf`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11201:
[FLINK-16179][hive] Use configuration from TableFactory in hive connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11201: [FLINK-16179][hive] Use configuration from TableFactory in hive connector
URL: https://github.com/apache/flink/pull/11201#issuecomment-590261947
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ad474e5d2fe5de5164ff7a87d0dd7c88b99cf3a",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150274027",
"triggerID" : "2ad474e5d2fe5de5164ff7a87d0dd7c88b99cf3a",
"triggerType" : "PUSH"
}, {
"hash" : "ab314712781098655191f60f5d92f6e48f2a7fbc",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150438253",
"triggerID" : "ab314712781098655191f60f5d92f6e48f2a7fbc",
"triggerType" : "PUSH"
}, {
"hash" : "ab314712781098655191f60f5d92f6e48f2a7fbc",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5552",
"triggerID" : "ab314712781098655191f60f5d92f6e48f2a7fbc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ab314712781098655191f60f5d92f6e48f2a7fbc Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150438253) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5552)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11201:
[FLINK-16179][hive] Use configuration from TableFactory in hive connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11201: [FLINK-16179][hive] Use configuration from TableFactory in hive connector
URL: https://github.com/apache/flink/pull/11201#issuecomment-590261947
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ad474e5d2fe5de5164ff7a87d0dd7c88b99cf3a",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150274027",
"triggerID" : "2ad474e5d2fe5de5164ff7a87d0dd7c88b99cf3a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2ad474e5d2fe5de5164ff7a87d0dd7c88b99cf3a Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150274027)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11201:
[FLINK-16179][hive] Use configuration from TableFactory in hive connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11201: [FLINK-16179][hive] Use configuration from TableFactory in hive connector
URL: https://github.com/apache/flink/pull/11201#issuecomment-590261947
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ad474e5d2fe5de5164ff7a87d0dd7c88b99cf3a",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150274027",
"triggerID" : "2ad474e5d2fe5de5164ff7a87d0dd7c88b99cf3a",
"triggerType" : "PUSH"
}, {
"hash" : "ab314712781098655191f60f5d92f6e48f2a7fbc",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150438253",
"triggerID" : "ab314712781098655191f60f5d92f6e48f2a7fbc",
"triggerType" : "PUSH"
}, {
"hash" : "ab314712781098655191f60f5d92f6e48f2a7fbc",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5552",
"triggerID" : "ab314712781098655191f60f5d92f6e48f2a7fbc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ab314712781098655191f60f5d92f6e48f2a7fbc Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150438253) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5552)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11201:
[FLINK-16179][hive] Use configuration from TableFactory in hive connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11201: [FLINK-16179][hive] Use configuration from TableFactory in hive connector
URL: https://github.com/apache/flink/pull/11201#issuecomment-590261947
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ad474e5d2fe5de5164ff7a87d0dd7c88b99cf3a",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150274027",
"triggerID" : "2ad474e5d2fe5de5164ff7a87d0dd7c88b99cf3a",
"triggerType" : "PUSH"
}, {
"hash" : "ab314712781098655191f60f5d92f6e48f2a7fbc",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150438253",
"triggerID" : "ab314712781098655191f60f5d92f6e48f2a7fbc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2ad474e5d2fe5de5164ff7a87d0dd7c88b99cf3a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150274027)
* ab314712781098655191f60f5d92f6e48f2a7fbc Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150438253)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on issue #11201: [FLINK-16179][hive]
Use configuration from TableFactory in hive connector
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on issue #11201: [FLINK-16179][hive] Use configuration from TableFactory in hive connector
URL: https://github.com/apache/flink/pull/11201#issuecomment-590741924
@JingsongLi Thanks for the PR.
Just left a minor comment. And the check style failure also seems related.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services