You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Alisha Prabhu <al...@ibm.com> on 2018/03/15 09:49:54 UTC
Review Request 66084: Oozie-core fails with checkstyle errors.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66084/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-3176
https://issues.apache.org/jira/browse/OOZIE-3176
Repository: oozie-git
Description
-------
There are multiple checkstyle violations in the Oozie-core module.
Maven command used is mvn clean install -DskipTests
Diffs
-----
core/src/main/java/org/apache/oozie/BundleActionBean.java eeec549
core/src/main/java/org/apache/oozie/BundleJobBean.java dec0967
core/src/main/java/org/apache/oozie/CoordinatorActionBean.java ddec1e6
core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5999f40
core/src/main/java/org/apache/oozie/CoordinatorJobInfo.java 04c5bc9
core/src/main/java/org/apache/oozie/DagELFunctions.java 22ac624
core/src/main/java/org/apache/oozie/SLAEventBean.java b30867b
core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6b05b89
core/src/main/java/org/apache/oozie/WorkflowJobBean.java cb06bec
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java bc0f405
core/src/main/java/org/apache/oozie/client/rest/JsonBean.java c8bd7c2
core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 669ac5e
core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 179cc45
core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 16d7036
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java ff7bf8a
core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java fbc6152
core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 2b91253
core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1e864ea
core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 1998924
core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 42bdc99
core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 1195ef0
core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 86ee1cc
core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 61891b8
core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 71c29cd
core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 29ccd32
core/src/main/java/org/apache/oozie/coord/CoordUtils.java 2874bf6
core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java f40f406
core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java 18ceb10
core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java 02a4f68
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetRunningActionsCountJPAExecutor.java 274b3c1
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java 51449db
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java 43c7d08
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsBasicInfoFromParentId.java 4b8adfb
core/src/main/java/org/apache/oozie/service/AuthorizationService.java d76e1ea
core/src/main/java/org/apache/oozie/service/PurgeService.java c2c966b
core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 404d3cd
core/src/main/java/org/apache/oozie/servlet/ServletUtilities.java 9cdd915
core/src/main/java/org/apache/oozie/servlet/V0AdminServlet.java d4a0989
core/src/main/java/org/apache/oozie/servlet/V0JobsServlet.java ff50f3d
core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 0d275fd
core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java 5eac78c
core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java e9ea9ba
core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java d08521c
core/src/main/java/org/apache/oozie/store/WorkflowStore.java 821abc5
core/src/main/java/org/apache/oozie/util/OozieRollingPolicy.java 625053c
core/src/main/java/org/apache/oozie/util/ParameterVerifier.java f3f4630
core/src/main/java/org/apache/oozie/util/ParameterVerifierException.java ef9a591
core/src/main/java/org/apache/oozie/util/PollablePriorityDelayQueue.java 03279eb
core/src/main/java/org/apache/oozie/util/db/BasicDataSourceWrapper.java 826f95b
core/src/main/java/org/apache/oozie/util/db/Schema.java 1278be1
core/src/main/java/org/apache/oozie/workflow/lite/ActionNodeDef.java 97c7134
core/src/main/java/org/apache/oozie/workflow/lite/DBLiteWorkflowLib.java dd6afa0
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java c236daf
core/src/main/resources/jetty-logging.properties 3da7c30
core/src/main/resources/localoozie-log4j.properties 906397f
core/src/main/resources/oozie-log4j.properties ba8d7b9
core/src/test/java/org/apache/hadoop/examples/SleepJob.java 342f8b3
core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java c6c9c49
core/src/test/java/org/apache/oozie/TestLocalOozieClientCoord.java 177bff7
core/src/test/java/org/apache/oozie/action/hadoop/InsertTestToken.java 9558aa5
core/src/test/java/org/apache/oozie/action/hadoop/TestHadoopELFunctions.java c6ec63c
core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1cc569d
core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 8d0b441
core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobXCommand.java c6ecb5e
core/src/test/java/org/apache/oozie/command/bundle/TestBundlePauseUnpauseXCommand.java 46819d9
core/src/test/java/org/apache/oozie/command/bundle/TestBundleRerunXCommand.java 4a10a8b
core/src/test/java/org/apache/oozie/command/bundle/TestBundleSubmitXCommand.java 429eb0d
core/src/test/java/org/apache/oozie/command/coord/CoordXTestCase.java 4a25356
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 96ac195
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java db66c72
core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java b8eb15d
core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java 111eace
core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 9a05a85
core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java dcc97ad
core/src/test/java/org/apache/oozie/command/coord/TestCoordUpdateXCommand.java 5bee228
core/src/test/java/org/apache/oozie/command/coord/TestFutureActionsTimeOut.java a6fce4e
core/src/test/java/org/apache/oozie/command/coord/TestPastActionsTimeOut.java f4327ae
core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 25d16cf
core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java dadebb5
core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 80c5d54
core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 45cbbc4
core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java a429665
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForCheckJPAExecutor.java 05d93a8
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForExternalIdJPAExecutor.java 5b748f0
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseStatusCountGetJPAExecutor.java a35c987
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionForNominalTimeJPAExecutor.java 3d90cdf
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsJPAExecutor.java e9fa9f6
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 9ccd62a
core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowIdGetForExternalIdJPAExecutor.java df57b72
core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 620dc6d
core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java 30fd151
core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java ca5b940
core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java ebe8e48
core/src/test/java/org/apache/oozie/service/TestCoordMaterializeTriggerService.java aadf3fb
core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java 53b7f62
core/src/test/java/org/apache/oozie/service/TestLiteWorkflowStoreService.java 1eda445
core/src/test/java/org/apache/oozie/service/TestRecoveryService.java ce04c6d
core/src/test/java/org/apache/oozie/service/TestSparkConfigurationService.java 1278efa
core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 0bcbce0
core/src/test/java/org/apache/oozie/servlet/TestV1AdminServlet.java 534f572
core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java 03f2323
core/src/test/java/org/apache/oozie/test/MiniOozieTestCase.java 12ede02
core/src/test/java/org/apache/oozie/test/XDataTestCase.java 2105e2f
core/src/test/java/org/apache/oozie/test/XFsTestCase.java 2b33d93
core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java d8acc99
core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 3253512
core/src/test/java/org/apache/oozie/util/TestOozieRollingPolicy.java 051ce56
core/src/test/java/org/apache/oozie/util/TestParameterVerifier.java 8cd89cb
core/src/test/java/org/apache/oozie/util/TestXLogFilter.java ec712c9
core/src/test/java/org/apache/oozie/util/db/TestSqlStatement.java 91a1698
core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java 74c1618
core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java 2cdbde4
core/src/test/resources/test-custom-log4j.properties 747df01
core/src/test/resources/test-no-dash-log4j.properties 4242f8a
core/src/test/resources/test-oozie-log4j.properties 3040d4f
Diff: https://reviews.apache.org/r/66084/diff/1/
Testing
-------
Have tested the patch with mvn clean install -DskipTests
There are 3 Checkstyle violations as I have kept the .properties files intact.
Thanks,
Alisha Prabhu
Re: Review Request 66084: Oozie-core fails with checkstyle errors.
Posted by Alisha Prabhu <al...@ibm.com>.
> On March 19, 2018, 8:37 a.m., Attila Sasvari wrote:
> >
Hi Attila Sasvari, can you please review the updated patch. Thank you.
- Alisha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66084/#review199384
-----------------------------------------------------------
On March 20, 2018, 5:36 a.m., Alisha Prabhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66084/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 5:36 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-3176
> https://issues.apache.org/jira/browse/OOZIE-3176
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/BundleActionBean.java eeec549
> core/src/main/java/org/apache/oozie/BundleJobBean.java dec0967
> core/src/main/java/org/apache/oozie/CoordinatorActionBean.java ddec1e6
> core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5999f40
> core/src/main/java/org/apache/oozie/CoordinatorJobInfo.java 04c5bc9
> core/src/main/java/org/apache/oozie/DagELFunctions.java 22ac624
> core/src/main/java/org/apache/oozie/SLAEventBean.java b30867b
> core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6b05b89
> core/src/main/java/org/apache/oozie/WorkflowJobBean.java cb06bec
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 122dfd0
> core/src/main/java/org/apache/oozie/client/rest/JsonBean.java c8bd7c2
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 669ac5e
> core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 179cc45
> core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 16d7036
> core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java ff7bf8a
> core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java fbc6152
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 2b91253
> core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1e864ea
> core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 1998924
> core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 42bdc99
> core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 1195ef0
> core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 86ee1cc
> core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 61891b8
> core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 71c29cd
> core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 29ccd32
> core/src/main/java/org/apache/oozie/coord/CoordUtils.java 2874bf6
> core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java f40f406
> core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java 18ceb10
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java 02a4f68
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetRunningActionsCountJPAExecutor.java 274b3c1
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java 51449db
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java 43c7d08
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsBasicInfoFromParentId.java 4b8adfb
> core/src/main/java/org/apache/oozie/service/AuthorizationService.java d76e1ea
> core/src/main/java/org/apache/oozie/service/PurgeService.java c2c966b
> core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 404d3cd
> core/src/main/java/org/apache/oozie/servlet/ServletUtilities.java 9cdd915
> core/src/main/java/org/apache/oozie/servlet/V0AdminServlet.java d4a0989
> core/src/main/java/org/apache/oozie/servlet/V0JobsServlet.java ff50f3d
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 0d275fd
> core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java 5eac78c
> core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java e9ea9ba
> core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java d08521c
> core/src/main/java/org/apache/oozie/store/WorkflowStore.java 821abc5
> core/src/main/java/org/apache/oozie/util/OozieRollingPolicy.java 625053c
> core/src/main/java/org/apache/oozie/util/ParameterVerifier.java f3f4630
> core/src/main/java/org/apache/oozie/util/ParameterVerifierException.java ef9a591
> core/src/main/java/org/apache/oozie/util/PollablePriorityDelayQueue.java 03279eb
> core/src/main/java/org/apache/oozie/util/db/Schema.java 1278be1
> core/src/main/java/org/apache/oozie/workflow/lite/ActionNodeDef.java 97c7134
> core/src/main/java/org/apache/oozie/workflow/lite/DBLiteWorkflowLib.java dd6afa0
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java 78b0652
> core/src/main/resources/localoozie-log4j.properties 906397f
> core/src/test/java/org/apache/hadoop/examples/SleepJob.java 342f8b3
> core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java c6c9c49
> core/src/test/java/org/apache/oozie/TestLocalOozieClientCoord.java 177bff7
> core/src/test/java/org/apache/oozie/action/hadoop/InsertTestToken.java 9558aa5
> core/src/test/java/org/apache/oozie/action/hadoop/TestHadoopELFunctions.java c6ec63c
> core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java b55a3cd
> core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 8d0b441
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobXCommand.java c6ecb5e
> core/src/test/java/org/apache/oozie/command/bundle/TestBundlePauseUnpauseXCommand.java 46819d9
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleRerunXCommand.java 4a10a8b
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleSubmitXCommand.java 429eb0d
> core/src/test/java/org/apache/oozie/command/coord/CoordXTestCase.java 4a25356
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 96ac195
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java db66c72
> core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java b8eb15d
> core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java 111eace
> core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 9a05a85
> core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java dcc97ad
> core/src/test/java/org/apache/oozie/command/coord/TestCoordUpdateXCommand.java 5bee228
> core/src/test/java/org/apache/oozie/command/coord/TestFutureActionsTimeOut.java a6fce4e
> core/src/test/java/org/apache/oozie/command/coord/TestPastActionsTimeOut.java f4327ae
> core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 25d16cf
> core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java dadebb5
> core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 80c5d54
> core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 45cbbc4
> core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java a429665
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForCheckJPAExecutor.java 05d93a8
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForExternalIdJPAExecutor.java 5b748f0
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseStatusCountGetJPAExecutor.java a35c987
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionForNominalTimeJPAExecutor.java 3d90cdf
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsJPAExecutor.java e9fa9f6
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 9ccd62a
> core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowIdGetForExternalIdJPAExecutor.java df57b72
> core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 620dc6d
> core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java 30fd151
> core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java ca5b940
> core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java ebe8e48
> core/src/test/java/org/apache/oozie/service/TestCoordMaterializeTriggerService.java aadf3fb
> core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java 53b7f62
> core/src/test/java/org/apache/oozie/service/TestLiteWorkflowStoreService.java 1eda445
> core/src/test/java/org/apache/oozie/service/TestRecoveryService.java ce04c6d
> core/src/test/java/org/apache/oozie/service/TestSparkConfigurationService.java 1278efa
> core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 0bcbce0
> core/src/test/java/org/apache/oozie/servlet/TestV1AdminServlet.java 534f572
> core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java 03f2323
> core/src/test/java/org/apache/oozie/test/MiniOozieTestCase.java 12ede02
> core/src/test/java/org/apache/oozie/test/XDataTestCase.java 2105e2f
> core/src/test/java/org/apache/oozie/test/XFsTestCase.java 2b33d93
> core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java d8acc99
> core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 3253512
> core/src/test/java/org/apache/oozie/util/TestOozieRollingPolicy.java 051ce56
> core/src/test/java/org/apache/oozie/util/TestParameterVerifier.java 8cd89cb
> core/src/test/java/org/apache/oozie/util/TestXLogFilter.java ec712c9
> core/src/test/java/org/apache/oozie/util/db/TestSqlStatement.java 91a1698
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java 74c1618
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java f5baf6b
> core/src/test/resources/test-custom-log4j.properties 747df01
> core/src/test/resources/test-oozie-log4j.properties 3040d4f
> src/main/resources/checkstyle-header.txt 4247452
> src/main/resources/checkstyle.xml 68b6cce
>
>
> Diff: https://reviews.apache.org/r/66084/diff/3/
>
>
> Testing
> -------
>
> Have tested the patch with mvn clean install -DskipTests
> There are 3 Checkstyle violations as I have kept the .properties files intact.
>
>
> Thanks,
>
> Alisha Prabhu
>
>
Re: Review Request 66084: Oozie-core fails with checkstyle errors.
Posted by Alisha Prabhu <al...@ibm.com>.
> On March 19, 2018, 8:37 a.m., Attila Sasvari wrote:
> > core/src/main/resources/jetty-logging.properties
> > Line 1 (original), 1 (patched)
> > <https://reviews.apache.org/r/66084/diff/1/?file=1976730#file1976730line1>
> >
> > Please leave .properties files intact. ``/**/`` is not a valid comment. Format: https://docs.oracle.com/javase/8/docs/api/java/util/Properties.html#load-java.io.Reader-
>
> Alisha Prabhu wrote:
> Have now kept all the .properties files intact.
>
> Peter Cseh wrote:
> I think the proper solution here is to don't use CheckStyle for header checking. We have RAT to check the headers.
> Please remove this section from the checkstyle config: https://github.com/apache/oozie/blob/master/src/main/resources/checkstyle.xml#L29-L31 and the corresponging file: https://github.com/apache/oozie/blob/master/src/main/resources/checkstyle-header.txt
Uploaded the patch by making the above changes.
- Alisha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66084/#review199384
-----------------------------------------------------------
On March 20, 2018, 5:36 a.m., Alisha Prabhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66084/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 5:36 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-3176
> https://issues.apache.org/jira/browse/OOZIE-3176
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/BundleActionBean.java eeec549
> core/src/main/java/org/apache/oozie/BundleJobBean.java dec0967
> core/src/main/java/org/apache/oozie/CoordinatorActionBean.java ddec1e6
> core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5999f40
> core/src/main/java/org/apache/oozie/CoordinatorJobInfo.java 04c5bc9
> core/src/main/java/org/apache/oozie/DagELFunctions.java 22ac624
> core/src/main/java/org/apache/oozie/SLAEventBean.java b30867b
> core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6b05b89
> core/src/main/java/org/apache/oozie/WorkflowJobBean.java cb06bec
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 122dfd0
> core/src/main/java/org/apache/oozie/client/rest/JsonBean.java c8bd7c2
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 669ac5e
> core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 179cc45
> core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 16d7036
> core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java ff7bf8a
> core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java fbc6152
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 2b91253
> core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1e864ea
> core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 1998924
> core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 42bdc99
> core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 1195ef0
> core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 86ee1cc
> core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 61891b8
> core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 71c29cd
> core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 29ccd32
> core/src/main/java/org/apache/oozie/coord/CoordUtils.java 2874bf6
> core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java f40f406
> core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java 18ceb10
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java 02a4f68
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetRunningActionsCountJPAExecutor.java 274b3c1
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java 51449db
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java 43c7d08
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsBasicInfoFromParentId.java 4b8adfb
> core/src/main/java/org/apache/oozie/service/AuthorizationService.java d76e1ea
> core/src/main/java/org/apache/oozie/service/PurgeService.java c2c966b
> core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 404d3cd
> core/src/main/java/org/apache/oozie/servlet/ServletUtilities.java 9cdd915
> core/src/main/java/org/apache/oozie/servlet/V0AdminServlet.java d4a0989
> core/src/main/java/org/apache/oozie/servlet/V0JobsServlet.java ff50f3d
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 0d275fd
> core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java 5eac78c
> core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java e9ea9ba
> core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java d08521c
> core/src/main/java/org/apache/oozie/store/WorkflowStore.java 821abc5
> core/src/main/java/org/apache/oozie/util/OozieRollingPolicy.java 625053c
> core/src/main/java/org/apache/oozie/util/ParameterVerifier.java f3f4630
> core/src/main/java/org/apache/oozie/util/ParameterVerifierException.java ef9a591
> core/src/main/java/org/apache/oozie/util/PollablePriorityDelayQueue.java 03279eb
> core/src/main/java/org/apache/oozie/util/db/Schema.java 1278be1
> core/src/main/java/org/apache/oozie/workflow/lite/ActionNodeDef.java 97c7134
> core/src/main/java/org/apache/oozie/workflow/lite/DBLiteWorkflowLib.java dd6afa0
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java 78b0652
> core/src/main/resources/localoozie-log4j.properties 906397f
> core/src/test/java/org/apache/hadoop/examples/SleepJob.java 342f8b3
> core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java c6c9c49
> core/src/test/java/org/apache/oozie/TestLocalOozieClientCoord.java 177bff7
> core/src/test/java/org/apache/oozie/action/hadoop/InsertTestToken.java 9558aa5
> core/src/test/java/org/apache/oozie/action/hadoop/TestHadoopELFunctions.java c6ec63c
> core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java b55a3cd
> core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 8d0b441
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobXCommand.java c6ecb5e
> core/src/test/java/org/apache/oozie/command/bundle/TestBundlePauseUnpauseXCommand.java 46819d9
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleRerunXCommand.java 4a10a8b
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleSubmitXCommand.java 429eb0d
> core/src/test/java/org/apache/oozie/command/coord/CoordXTestCase.java 4a25356
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 96ac195
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java db66c72
> core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java b8eb15d
> core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java 111eace
> core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 9a05a85
> core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java dcc97ad
> core/src/test/java/org/apache/oozie/command/coord/TestCoordUpdateXCommand.java 5bee228
> core/src/test/java/org/apache/oozie/command/coord/TestFutureActionsTimeOut.java a6fce4e
> core/src/test/java/org/apache/oozie/command/coord/TestPastActionsTimeOut.java f4327ae
> core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 25d16cf
> core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java dadebb5
> core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 80c5d54
> core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 45cbbc4
> core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java a429665
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForCheckJPAExecutor.java 05d93a8
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForExternalIdJPAExecutor.java 5b748f0
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseStatusCountGetJPAExecutor.java a35c987
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionForNominalTimeJPAExecutor.java 3d90cdf
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsJPAExecutor.java e9fa9f6
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 9ccd62a
> core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowIdGetForExternalIdJPAExecutor.java df57b72
> core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 620dc6d
> core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java 30fd151
> core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java ca5b940
> core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java ebe8e48
> core/src/test/java/org/apache/oozie/service/TestCoordMaterializeTriggerService.java aadf3fb
> core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java 53b7f62
> core/src/test/java/org/apache/oozie/service/TestLiteWorkflowStoreService.java 1eda445
> core/src/test/java/org/apache/oozie/service/TestRecoveryService.java ce04c6d
> core/src/test/java/org/apache/oozie/service/TestSparkConfigurationService.java 1278efa
> core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 0bcbce0
> core/src/test/java/org/apache/oozie/servlet/TestV1AdminServlet.java 534f572
> core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java 03f2323
> core/src/test/java/org/apache/oozie/test/MiniOozieTestCase.java 12ede02
> core/src/test/java/org/apache/oozie/test/XDataTestCase.java 2105e2f
> core/src/test/java/org/apache/oozie/test/XFsTestCase.java 2b33d93
> core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java d8acc99
> core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 3253512
> core/src/test/java/org/apache/oozie/util/TestOozieRollingPolicy.java 051ce56
> core/src/test/java/org/apache/oozie/util/TestParameterVerifier.java 8cd89cb
> core/src/test/java/org/apache/oozie/util/TestXLogFilter.java ec712c9
> core/src/test/java/org/apache/oozie/util/db/TestSqlStatement.java 91a1698
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java 74c1618
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java f5baf6b
> core/src/test/resources/test-custom-log4j.properties 747df01
> core/src/test/resources/test-oozie-log4j.properties 3040d4f
> src/main/resources/checkstyle-header.txt 4247452
> src/main/resources/checkstyle.xml 68b6cce
>
>
> Diff: https://reviews.apache.org/r/66084/diff/3/
>
>
> Testing
> -------
>
> Have tested the patch with mvn clean install -DskipTests
> There are 3 Checkstyle violations as I have kept the .properties files intact.
>
>
> Thanks,
>
> Alisha Prabhu
>
>
Re: Review Request 66084: Oozie-core fails with checkstyle errors.
Posted by Alisha Prabhu <al...@ibm.com>.
> On March 19, 2018, 8:37 a.m., Attila Sasvari wrote:
> > core/src/main/java/org/apache/oozie/util/db/BasicDataSourceWrapper.java
> > Lines 44 (patched)
> > <https://reviews.apache.org/r/66084/diff/1/?file=1976725#file1976725line44>
> >
> > It breaks the precommit build (mkdistro, see https://builds.apache.org/job/PreCommit-OOZIE-Build/416/artifact/test-patch/reports/DISTRO.out)
Have kept the BasicDataSourceWrapper.java file intact.
Got build success after running the below command :
bin/mkdistro.sh -DskipTests -Puber -DtargetJavaVersion=1.8 -DjavaVersion=1.8
> On March 19, 2018, 8:37 a.m., Attila Sasvari wrote:
> > core/src/main/resources/jetty-logging.properties
> > Line 1 (original), 1 (patched)
> > <https://reviews.apache.org/r/66084/diff/1/?file=1976730#file1976730line1>
> >
> > Please leave .properties files intact. ``/**/`` is not a valid comment. Format: https://docs.oracle.com/javase/8/docs/api/java/util/Properties.html#load-java.io.Reader-
Have now kept all the .properties files intact.
- Alisha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66084/#review199384
-----------------------------------------------------------
On March 19, 2018, 12:32 p.m., Alisha Prabhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66084/
> -----------------------------------------------------------
>
> (Updated March 19, 2018, 12:32 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-3176
> https://issues.apache.org/jira/browse/OOZIE-3176
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/BundleActionBean.java eeec549
> core/src/main/java/org/apache/oozie/BundleJobBean.java dec0967
> core/src/main/java/org/apache/oozie/CoordinatorActionBean.java ddec1e6
> core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5999f40
> core/src/main/java/org/apache/oozie/CoordinatorJobInfo.java 04c5bc9
> core/src/main/java/org/apache/oozie/DagELFunctions.java 22ac624
> core/src/main/java/org/apache/oozie/SLAEventBean.java b30867b
> core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6b05b89
> core/src/main/java/org/apache/oozie/WorkflowJobBean.java cb06bec
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 122dfd0
> core/src/main/java/org/apache/oozie/client/rest/JsonBean.java c8bd7c2
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 669ac5e
> core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 179cc45
> core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 16d7036
> core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java ff7bf8a
> core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java fbc6152
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 2b91253
> core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1e864ea
> core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 1998924
> core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 42bdc99
> core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 1195ef0
> core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 86ee1cc
> core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 61891b8
> core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 71c29cd
> core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 29ccd32
> core/src/main/java/org/apache/oozie/coord/CoordUtils.java 2874bf6
> core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java f40f406
> core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java 18ceb10
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java 02a4f68
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetRunningActionsCountJPAExecutor.java 274b3c1
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java 51449db
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java 43c7d08
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsBasicInfoFromParentId.java 4b8adfb
> core/src/main/java/org/apache/oozie/service/AuthorizationService.java d76e1ea
> core/src/main/java/org/apache/oozie/service/PurgeService.java c2c966b
> core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 404d3cd
> core/src/main/java/org/apache/oozie/servlet/ServletUtilities.java 9cdd915
> core/src/main/java/org/apache/oozie/servlet/V0AdminServlet.java d4a0989
> core/src/main/java/org/apache/oozie/servlet/V0JobsServlet.java ff50f3d
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 0d275fd
> core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java 5eac78c
> core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java e9ea9ba
> core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java d08521c
> core/src/main/java/org/apache/oozie/store/WorkflowStore.java 821abc5
> core/src/main/java/org/apache/oozie/util/OozieRollingPolicy.java 625053c
> core/src/main/java/org/apache/oozie/util/ParameterVerifier.java f3f4630
> core/src/main/java/org/apache/oozie/util/ParameterVerifierException.java ef9a591
> core/src/main/java/org/apache/oozie/util/PollablePriorityDelayQueue.java 03279eb
> core/src/main/java/org/apache/oozie/util/db/Schema.java 1278be1
> core/src/main/java/org/apache/oozie/workflow/lite/ActionNodeDef.java 97c7134
> core/src/main/java/org/apache/oozie/workflow/lite/DBLiteWorkflowLib.java dd6afa0
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java 78b0652
> core/src/main/resources/localoozie-log4j.properties 906397f
> core/src/test/java/org/apache/hadoop/examples/SleepJob.java 342f8b3
> core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java c6c9c49
> core/src/test/java/org/apache/oozie/TestLocalOozieClientCoord.java 177bff7
> core/src/test/java/org/apache/oozie/action/hadoop/InsertTestToken.java 9558aa5
> core/src/test/java/org/apache/oozie/action/hadoop/TestHadoopELFunctions.java c6ec63c
> core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java b55a3cd
> core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 8d0b441
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobXCommand.java c6ecb5e
> core/src/test/java/org/apache/oozie/command/bundle/TestBundlePauseUnpauseXCommand.java 46819d9
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleRerunXCommand.java 4a10a8b
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleSubmitXCommand.java 429eb0d
> core/src/test/java/org/apache/oozie/command/coord/CoordXTestCase.java 4a25356
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 96ac195
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java db66c72
> core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java b8eb15d
> core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java 111eace
> core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 9a05a85
> core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java dcc97ad
> core/src/test/java/org/apache/oozie/command/coord/TestCoordUpdateXCommand.java 5bee228
> core/src/test/java/org/apache/oozie/command/coord/TestFutureActionsTimeOut.java a6fce4e
> core/src/test/java/org/apache/oozie/command/coord/TestPastActionsTimeOut.java f4327ae
> core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 25d16cf
> core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java dadebb5
> core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 80c5d54
> core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 45cbbc4
> core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java a429665
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForCheckJPAExecutor.java 05d93a8
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForExternalIdJPAExecutor.java 5b748f0
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseStatusCountGetJPAExecutor.java a35c987
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionForNominalTimeJPAExecutor.java 3d90cdf
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsJPAExecutor.java e9fa9f6
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 9ccd62a
> core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowIdGetForExternalIdJPAExecutor.java df57b72
> core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 620dc6d
> core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java 30fd151
> core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java ca5b940
> core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java ebe8e48
> core/src/test/java/org/apache/oozie/service/TestCoordMaterializeTriggerService.java aadf3fb
> core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java 53b7f62
> core/src/test/java/org/apache/oozie/service/TestLiteWorkflowStoreService.java 1eda445
> core/src/test/java/org/apache/oozie/service/TestRecoveryService.java ce04c6d
> core/src/test/java/org/apache/oozie/service/TestSparkConfigurationService.java 1278efa
> core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 0bcbce0
> core/src/test/java/org/apache/oozie/servlet/TestV1AdminServlet.java 534f572
> core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java 03f2323
> core/src/test/java/org/apache/oozie/test/MiniOozieTestCase.java 12ede02
> core/src/test/java/org/apache/oozie/test/XDataTestCase.java 2105e2f
> core/src/test/java/org/apache/oozie/test/XFsTestCase.java 2b33d93
> core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java d8acc99
> core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 3253512
> core/src/test/java/org/apache/oozie/util/TestOozieRollingPolicy.java 051ce56
> core/src/test/java/org/apache/oozie/util/TestParameterVerifier.java 8cd89cb
> core/src/test/java/org/apache/oozie/util/TestXLogFilter.java ec712c9
> core/src/test/java/org/apache/oozie/util/db/TestSqlStatement.java 91a1698
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java 74c1618
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java f5baf6b
> core/src/test/resources/test-custom-log4j.properties 747df01
> core/src/test/resources/test-oozie-log4j.properties 3040d4f
>
>
> Diff: https://reviews.apache.org/r/66084/diff/2/
>
>
> Testing
> -------
>
> Have tested the patch with mvn clean install -DskipTests
> There are 3 Checkstyle violations as I have kept the .properties files intact.
>
>
> Thanks,
>
> Alisha Prabhu
>
>
Re: Review Request 66084: Oozie-core fails with checkstyle errors.
Posted by Peter Cseh via Review Board <no...@reviews.apache.org>.
> On March 19, 2018, 8:37 a.m., Attila Sasvari wrote:
> > core/src/main/resources/jetty-logging.properties
> > Line 1 (original), 1 (patched)
> > <https://reviews.apache.org/r/66084/diff/1/?file=1976730#file1976730line1>
> >
> > Please leave .properties files intact. ``/**/`` is not a valid comment. Format: https://docs.oracle.com/javase/8/docs/api/java/util/Properties.html#load-java.io.Reader-
>
> Alisha Prabhu wrote:
> Have now kept all the .properties files intact.
I think the proper solution here is to don't use CheckStyle for header checking. We have RAT to check the headers.
Please remove this section from the checkstyle config: https://github.com/apache/oozie/blob/master/src/main/resources/checkstyle.xml#L29-L31 and the corresponging file: https://github.com/apache/oozie/blob/master/src/main/resources/checkstyle-header.txt
- Peter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66084/#review199384
-----------------------------------------------------------
On March 19, 2018, 12:32 p.m., Alisha Prabhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66084/
> -----------------------------------------------------------
>
> (Updated March 19, 2018, 12:32 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-3176
> https://issues.apache.org/jira/browse/OOZIE-3176
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/BundleActionBean.java eeec549
> core/src/main/java/org/apache/oozie/BundleJobBean.java dec0967
> core/src/main/java/org/apache/oozie/CoordinatorActionBean.java ddec1e6
> core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5999f40
> core/src/main/java/org/apache/oozie/CoordinatorJobInfo.java 04c5bc9
> core/src/main/java/org/apache/oozie/DagELFunctions.java 22ac624
> core/src/main/java/org/apache/oozie/SLAEventBean.java b30867b
> core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6b05b89
> core/src/main/java/org/apache/oozie/WorkflowJobBean.java cb06bec
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 122dfd0
> core/src/main/java/org/apache/oozie/client/rest/JsonBean.java c8bd7c2
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 669ac5e
> core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 179cc45
> core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 16d7036
> core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java ff7bf8a
> core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java fbc6152
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 2b91253
> core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1e864ea
> core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 1998924
> core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 42bdc99
> core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 1195ef0
> core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 86ee1cc
> core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 61891b8
> core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 71c29cd
> core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 29ccd32
> core/src/main/java/org/apache/oozie/coord/CoordUtils.java 2874bf6
> core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java f40f406
> core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java 18ceb10
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java 02a4f68
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetRunningActionsCountJPAExecutor.java 274b3c1
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java 51449db
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java 43c7d08
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsBasicInfoFromParentId.java 4b8adfb
> core/src/main/java/org/apache/oozie/service/AuthorizationService.java d76e1ea
> core/src/main/java/org/apache/oozie/service/PurgeService.java c2c966b
> core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 404d3cd
> core/src/main/java/org/apache/oozie/servlet/ServletUtilities.java 9cdd915
> core/src/main/java/org/apache/oozie/servlet/V0AdminServlet.java d4a0989
> core/src/main/java/org/apache/oozie/servlet/V0JobsServlet.java ff50f3d
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 0d275fd
> core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java 5eac78c
> core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java e9ea9ba
> core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java d08521c
> core/src/main/java/org/apache/oozie/store/WorkflowStore.java 821abc5
> core/src/main/java/org/apache/oozie/util/OozieRollingPolicy.java 625053c
> core/src/main/java/org/apache/oozie/util/ParameterVerifier.java f3f4630
> core/src/main/java/org/apache/oozie/util/ParameterVerifierException.java ef9a591
> core/src/main/java/org/apache/oozie/util/PollablePriorityDelayQueue.java 03279eb
> core/src/main/java/org/apache/oozie/util/db/Schema.java 1278be1
> core/src/main/java/org/apache/oozie/workflow/lite/ActionNodeDef.java 97c7134
> core/src/main/java/org/apache/oozie/workflow/lite/DBLiteWorkflowLib.java dd6afa0
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java 78b0652
> core/src/main/resources/localoozie-log4j.properties 906397f
> core/src/test/java/org/apache/hadoop/examples/SleepJob.java 342f8b3
> core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java c6c9c49
> core/src/test/java/org/apache/oozie/TestLocalOozieClientCoord.java 177bff7
> core/src/test/java/org/apache/oozie/action/hadoop/InsertTestToken.java 9558aa5
> core/src/test/java/org/apache/oozie/action/hadoop/TestHadoopELFunctions.java c6ec63c
> core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java b55a3cd
> core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 8d0b441
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobXCommand.java c6ecb5e
> core/src/test/java/org/apache/oozie/command/bundle/TestBundlePauseUnpauseXCommand.java 46819d9
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleRerunXCommand.java 4a10a8b
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleSubmitXCommand.java 429eb0d
> core/src/test/java/org/apache/oozie/command/coord/CoordXTestCase.java 4a25356
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 96ac195
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java db66c72
> core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java b8eb15d
> core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java 111eace
> core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 9a05a85
> core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java dcc97ad
> core/src/test/java/org/apache/oozie/command/coord/TestCoordUpdateXCommand.java 5bee228
> core/src/test/java/org/apache/oozie/command/coord/TestFutureActionsTimeOut.java a6fce4e
> core/src/test/java/org/apache/oozie/command/coord/TestPastActionsTimeOut.java f4327ae
> core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 25d16cf
> core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java dadebb5
> core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 80c5d54
> core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 45cbbc4
> core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java a429665
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForCheckJPAExecutor.java 05d93a8
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForExternalIdJPAExecutor.java 5b748f0
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseStatusCountGetJPAExecutor.java a35c987
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionForNominalTimeJPAExecutor.java 3d90cdf
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsJPAExecutor.java e9fa9f6
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 9ccd62a
> core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowIdGetForExternalIdJPAExecutor.java df57b72
> core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 620dc6d
> core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java 30fd151
> core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java ca5b940
> core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java ebe8e48
> core/src/test/java/org/apache/oozie/service/TestCoordMaterializeTriggerService.java aadf3fb
> core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java 53b7f62
> core/src/test/java/org/apache/oozie/service/TestLiteWorkflowStoreService.java 1eda445
> core/src/test/java/org/apache/oozie/service/TestRecoveryService.java ce04c6d
> core/src/test/java/org/apache/oozie/service/TestSparkConfigurationService.java 1278efa
> core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 0bcbce0
> core/src/test/java/org/apache/oozie/servlet/TestV1AdminServlet.java 534f572
> core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java 03f2323
> core/src/test/java/org/apache/oozie/test/MiniOozieTestCase.java 12ede02
> core/src/test/java/org/apache/oozie/test/XDataTestCase.java 2105e2f
> core/src/test/java/org/apache/oozie/test/XFsTestCase.java 2b33d93
> core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java d8acc99
> core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 3253512
> core/src/test/java/org/apache/oozie/util/TestOozieRollingPolicy.java 051ce56
> core/src/test/java/org/apache/oozie/util/TestParameterVerifier.java 8cd89cb
> core/src/test/java/org/apache/oozie/util/TestXLogFilter.java ec712c9
> core/src/test/java/org/apache/oozie/util/db/TestSqlStatement.java 91a1698
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java 74c1618
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java f5baf6b
> core/src/test/resources/test-custom-log4j.properties 747df01
> core/src/test/resources/test-oozie-log4j.properties 3040d4f
>
>
> Diff: https://reviews.apache.org/r/66084/diff/2/
>
>
> Testing
> -------
>
> Have tested the patch with mvn clean install -DskipTests
> There are 3 Checkstyle violations as I have kept the .properties files intact.
>
>
> Thanks,
>
> Alisha Prabhu
>
>
Re: Review Request 66084: Oozie-core fails with checkstyle errors.
Posted by Peter Cseh via Review Board <no...@reviews.apache.org>.
> On March 19, 2018, 8:37 a.m., Attila Sasvari wrote:
> > core/src/main/resources/jetty-logging.properties
> > Line 1 (original), 1 (patched)
> > <https://reviews.apache.org/r/66084/diff/1/?file=1976730#file1976730line1>
> >
> > Please leave .properties files intact. ``/**/`` is not a valid comment. Format: https://docs.oracle.com/javase/8/docs/api/java/util/Properties.html#load-java.io.Reader-
>
> Alisha Prabhu wrote:
> Have now kept all the .properties files intact.
>
> Peter Cseh wrote:
> I think the proper solution here is to don't use CheckStyle for header checking. We have RAT to check the headers.
> Please remove this section from the checkstyle config: https://github.com/apache/oozie/blob/master/src/main/resources/checkstyle.xml#L29-L31 and the corresponging file: https://github.com/apache/oozie/blob/master/src/main/resources/checkstyle-header.txt
>
> Alisha Prabhu wrote:
> Uploaded the patch by making the above changes.
It looks good! I've attached this patch to the Jira so the pre-commit hook can kick in.
- Peter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66084/#review199384
-----------------------------------------------------------
On March 20, 2018, 5:36 a.m., Alisha Prabhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66084/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 5:36 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-3176
> https://issues.apache.org/jira/browse/OOZIE-3176
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/BundleActionBean.java eeec549
> core/src/main/java/org/apache/oozie/BundleJobBean.java dec0967
> core/src/main/java/org/apache/oozie/CoordinatorActionBean.java ddec1e6
> core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5999f40
> core/src/main/java/org/apache/oozie/CoordinatorJobInfo.java 04c5bc9
> core/src/main/java/org/apache/oozie/DagELFunctions.java 22ac624
> core/src/main/java/org/apache/oozie/SLAEventBean.java b30867b
> core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6b05b89
> core/src/main/java/org/apache/oozie/WorkflowJobBean.java cb06bec
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 122dfd0
> core/src/main/java/org/apache/oozie/client/rest/JsonBean.java c8bd7c2
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 669ac5e
> core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 179cc45
> core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 16d7036
> core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java ff7bf8a
> core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java fbc6152
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 2b91253
> core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1e864ea
> core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 1998924
> core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 42bdc99
> core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 1195ef0
> core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 86ee1cc
> core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 61891b8
> core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 71c29cd
> core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 29ccd32
> core/src/main/java/org/apache/oozie/coord/CoordUtils.java 2874bf6
> core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java f40f406
> core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java 18ceb10
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java 02a4f68
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetRunningActionsCountJPAExecutor.java 274b3c1
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java 51449db
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java 43c7d08
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsBasicInfoFromParentId.java 4b8adfb
> core/src/main/java/org/apache/oozie/service/AuthorizationService.java d76e1ea
> core/src/main/java/org/apache/oozie/service/PurgeService.java c2c966b
> core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 404d3cd
> core/src/main/java/org/apache/oozie/servlet/ServletUtilities.java 9cdd915
> core/src/main/java/org/apache/oozie/servlet/V0AdminServlet.java d4a0989
> core/src/main/java/org/apache/oozie/servlet/V0JobsServlet.java ff50f3d
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 0d275fd
> core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java 5eac78c
> core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java e9ea9ba
> core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java d08521c
> core/src/main/java/org/apache/oozie/store/WorkflowStore.java 821abc5
> core/src/main/java/org/apache/oozie/util/OozieRollingPolicy.java 625053c
> core/src/main/java/org/apache/oozie/util/ParameterVerifier.java f3f4630
> core/src/main/java/org/apache/oozie/util/ParameterVerifierException.java ef9a591
> core/src/main/java/org/apache/oozie/util/PollablePriorityDelayQueue.java 03279eb
> core/src/main/java/org/apache/oozie/util/db/Schema.java 1278be1
> core/src/main/java/org/apache/oozie/workflow/lite/ActionNodeDef.java 97c7134
> core/src/main/java/org/apache/oozie/workflow/lite/DBLiteWorkflowLib.java dd6afa0
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java 78b0652
> core/src/main/resources/localoozie-log4j.properties 906397f
> core/src/test/java/org/apache/hadoop/examples/SleepJob.java 342f8b3
> core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java c6c9c49
> core/src/test/java/org/apache/oozie/TestLocalOozieClientCoord.java 177bff7
> core/src/test/java/org/apache/oozie/action/hadoop/InsertTestToken.java 9558aa5
> core/src/test/java/org/apache/oozie/action/hadoop/TestHadoopELFunctions.java c6ec63c
> core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java b55a3cd
> core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 8d0b441
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobXCommand.java c6ecb5e
> core/src/test/java/org/apache/oozie/command/bundle/TestBundlePauseUnpauseXCommand.java 46819d9
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleRerunXCommand.java 4a10a8b
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleSubmitXCommand.java 429eb0d
> core/src/test/java/org/apache/oozie/command/coord/CoordXTestCase.java 4a25356
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 96ac195
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java db66c72
> core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java b8eb15d
> core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java 111eace
> core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 9a05a85
> core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java dcc97ad
> core/src/test/java/org/apache/oozie/command/coord/TestCoordUpdateXCommand.java 5bee228
> core/src/test/java/org/apache/oozie/command/coord/TestFutureActionsTimeOut.java a6fce4e
> core/src/test/java/org/apache/oozie/command/coord/TestPastActionsTimeOut.java f4327ae
> core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 25d16cf
> core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java dadebb5
> core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 80c5d54
> core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 45cbbc4
> core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java a429665
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForCheckJPAExecutor.java 05d93a8
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForExternalIdJPAExecutor.java 5b748f0
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseStatusCountGetJPAExecutor.java a35c987
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionForNominalTimeJPAExecutor.java 3d90cdf
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsJPAExecutor.java e9fa9f6
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 9ccd62a
> core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowIdGetForExternalIdJPAExecutor.java df57b72
> core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 620dc6d
> core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java 30fd151
> core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java ca5b940
> core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java ebe8e48
> core/src/test/java/org/apache/oozie/service/TestCoordMaterializeTriggerService.java aadf3fb
> core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java 53b7f62
> core/src/test/java/org/apache/oozie/service/TestLiteWorkflowStoreService.java 1eda445
> core/src/test/java/org/apache/oozie/service/TestRecoveryService.java ce04c6d
> core/src/test/java/org/apache/oozie/service/TestSparkConfigurationService.java 1278efa
> core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 0bcbce0
> core/src/test/java/org/apache/oozie/servlet/TestV1AdminServlet.java 534f572
> core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java 03f2323
> core/src/test/java/org/apache/oozie/test/MiniOozieTestCase.java 12ede02
> core/src/test/java/org/apache/oozie/test/XDataTestCase.java 2105e2f
> core/src/test/java/org/apache/oozie/test/XFsTestCase.java 2b33d93
> core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java d8acc99
> core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 3253512
> core/src/test/java/org/apache/oozie/util/TestOozieRollingPolicy.java 051ce56
> core/src/test/java/org/apache/oozie/util/TestParameterVerifier.java 8cd89cb
> core/src/test/java/org/apache/oozie/util/TestXLogFilter.java ec712c9
> core/src/test/java/org/apache/oozie/util/db/TestSqlStatement.java 91a1698
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java 74c1618
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java f5baf6b
> core/src/test/resources/test-custom-log4j.properties 747df01
> core/src/test/resources/test-oozie-log4j.properties 3040d4f
> src/main/resources/checkstyle-header.txt 4247452
> src/main/resources/checkstyle.xml 68b6cce
>
>
> Diff: https://reviews.apache.org/r/66084/diff/3/
>
>
> Testing
> -------
>
> Have tested the patch with mvn clean install -DskipTests
> There are 3 Checkstyle violations as I have kept the .properties files intact.
>
>
> Thanks,
>
> Alisha Prabhu
>
>
Re: Review Request 66084: Oozie-core fails with checkstyle errors.
Posted by Attila Sasvari via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66084/#review199384
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/util/db/BasicDataSourceWrapper.java
Lines 44 (patched)
<https://reviews.apache.org/r/66084/#comment279726>
It breaks the precommit build (mkdistro, see https://builds.apache.org/job/PreCommit-OOZIE-Build/416/artifact/test-patch/reports/DISTRO.out)
core/src/main/resources/jetty-logging.properties
Line 1 (original), 1 (patched)
<https://reviews.apache.org/r/66084/#comment279713>
Please leave .properties files intact. ``/**/`` is not a valid comment. Format: https://docs.oracle.com/javase/8/docs/api/java/util/Properties.html#load-java.io.Reader-
core/src/main/resources/localoozie-log4j.properties
Line 1 (original), 1 (patched)
<https://reviews.apache.org/r/66084/#comment279714>
Please leave .properties files intact. ``/**/`` is not a valid comment. Format: https://docs.oracle.com/javase/8/docs/api/java/util/Properties.html#load-java.io.Reader-
core/src/main/resources/oozie-log4j.properties
Line 1 (original), 1 (patched)
<https://reviews.apache.org/r/66084/#comment279715>
Please leave .properties files intact. ``/**/`` is not a valid comment. Format: https://docs.oracle.com/javase/8/docs/api/java/util/Properties.html#load-java.io.Reader-
- Attila Sasvari
On March 15, 2018, 9:49 a.m., Alisha Prabhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66084/
> -----------------------------------------------------------
>
> (Updated March 15, 2018, 9:49 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-3176
> https://issues.apache.org/jira/browse/OOZIE-3176
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/BundleActionBean.java eeec549
> core/src/main/java/org/apache/oozie/BundleJobBean.java dec0967
> core/src/main/java/org/apache/oozie/CoordinatorActionBean.java ddec1e6
> core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5999f40
> core/src/main/java/org/apache/oozie/CoordinatorJobInfo.java 04c5bc9
> core/src/main/java/org/apache/oozie/DagELFunctions.java 22ac624
> core/src/main/java/org/apache/oozie/SLAEventBean.java b30867b
> core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6b05b89
> core/src/main/java/org/apache/oozie/WorkflowJobBean.java cb06bec
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java bc0f405
> core/src/main/java/org/apache/oozie/client/rest/JsonBean.java c8bd7c2
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 669ac5e
> core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 179cc45
> core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 16d7036
> core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java ff7bf8a
> core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java fbc6152
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 2b91253
> core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1e864ea
> core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 1998924
> core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 42bdc99
> core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 1195ef0
> core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 86ee1cc
> core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 61891b8
> core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 71c29cd
> core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 29ccd32
> core/src/main/java/org/apache/oozie/coord/CoordUtils.java 2874bf6
> core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java f40f406
> core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java 18ceb10
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java 02a4f68
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetRunningActionsCountJPAExecutor.java 274b3c1
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java 51449db
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java 43c7d08
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsBasicInfoFromParentId.java 4b8adfb
> core/src/main/java/org/apache/oozie/service/AuthorizationService.java d76e1ea
> core/src/main/java/org/apache/oozie/service/PurgeService.java c2c966b
> core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 404d3cd
> core/src/main/java/org/apache/oozie/servlet/ServletUtilities.java 9cdd915
> core/src/main/java/org/apache/oozie/servlet/V0AdminServlet.java d4a0989
> core/src/main/java/org/apache/oozie/servlet/V0JobsServlet.java ff50f3d
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 0d275fd
> core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java 5eac78c
> core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java e9ea9ba
> core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java d08521c
> core/src/main/java/org/apache/oozie/store/WorkflowStore.java 821abc5
> core/src/main/java/org/apache/oozie/util/OozieRollingPolicy.java 625053c
> core/src/main/java/org/apache/oozie/util/ParameterVerifier.java f3f4630
> core/src/main/java/org/apache/oozie/util/ParameterVerifierException.java ef9a591
> core/src/main/java/org/apache/oozie/util/PollablePriorityDelayQueue.java 03279eb
> core/src/main/java/org/apache/oozie/util/db/BasicDataSourceWrapper.java 826f95b
> core/src/main/java/org/apache/oozie/util/db/Schema.java 1278be1
> core/src/main/java/org/apache/oozie/workflow/lite/ActionNodeDef.java 97c7134
> core/src/main/java/org/apache/oozie/workflow/lite/DBLiteWorkflowLib.java dd6afa0
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java c236daf
> core/src/main/resources/jetty-logging.properties 3da7c30
> core/src/main/resources/localoozie-log4j.properties 906397f
> core/src/main/resources/oozie-log4j.properties ba8d7b9
> core/src/test/java/org/apache/hadoop/examples/SleepJob.java 342f8b3
> core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java c6c9c49
> core/src/test/java/org/apache/oozie/TestLocalOozieClientCoord.java 177bff7
> core/src/test/java/org/apache/oozie/action/hadoop/InsertTestToken.java 9558aa5
> core/src/test/java/org/apache/oozie/action/hadoop/TestHadoopELFunctions.java c6ec63c
> core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1cc569d
> core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 8d0b441
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobXCommand.java c6ecb5e
> core/src/test/java/org/apache/oozie/command/bundle/TestBundlePauseUnpauseXCommand.java 46819d9
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleRerunXCommand.java 4a10a8b
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleSubmitXCommand.java 429eb0d
> core/src/test/java/org/apache/oozie/command/coord/CoordXTestCase.java 4a25356
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 96ac195
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java db66c72
> core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java b8eb15d
> core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java 111eace
> core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 9a05a85
> core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java dcc97ad
> core/src/test/java/org/apache/oozie/command/coord/TestCoordUpdateXCommand.java 5bee228
> core/src/test/java/org/apache/oozie/command/coord/TestFutureActionsTimeOut.java a6fce4e
> core/src/test/java/org/apache/oozie/command/coord/TestPastActionsTimeOut.java f4327ae
> core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 25d16cf
> core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java dadebb5
> core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 80c5d54
> core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 45cbbc4
> core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java a429665
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForCheckJPAExecutor.java 05d93a8
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForExternalIdJPAExecutor.java 5b748f0
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseStatusCountGetJPAExecutor.java a35c987
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionForNominalTimeJPAExecutor.java 3d90cdf
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsJPAExecutor.java e9fa9f6
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 9ccd62a
> core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowIdGetForExternalIdJPAExecutor.java df57b72
> core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 620dc6d
> core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java 30fd151
> core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java ca5b940
> core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java ebe8e48
> core/src/test/java/org/apache/oozie/service/TestCoordMaterializeTriggerService.java aadf3fb
> core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java 53b7f62
> core/src/test/java/org/apache/oozie/service/TestLiteWorkflowStoreService.java 1eda445
> core/src/test/java/org/apache/oozie/service/TestRecoveryService.java ce04c6d
> core/src/test/java/org/apache/oozie/service/TestSparkConfigurationService.java 1278efa
> core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 0bcbce0
> core/src/test/java/org/apache/oozie/servlet/TestV1AdminServlet.java 534f572
> core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java 03f2323
> core/src/test/java/org/apache/oozie/test/MiniOozieTestCase.java 12ede02
> core/src/test/java/org/apache/oozie/test/XDataTestCase.java 2105e2f
> core/src/test/java/org/apache/oozie/test/XFsTestCase.java 2b33d93
> core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java d8acc99
> core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 3253512
> core/src/test/java/org/apache/oozie/util/TestOozieRollingPolicy.java 051ce56
> core/src/test/java/org/apache/oozie/util/TestParameterVerifier.java 8cd89cb
> core/src/test/java/org/apache/oozie/util/TestXLogFilter.java ec712c9
> core/src/test/java/org/apache/oozie/util/db/TestSqlStatement.java 91a1698
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java 74c1618
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java 2cdbde4
> core/src/test/resources/test-custom-log4j.properties 747df01
> core/src/test/resources/test-no-dash-log4j.properties 4242f8a
> core/src/test/resources/test-oozie-log4j.properties 3040d4f
>
>
> Diff: https://reviews.apache.org/r/66084/diff/1/
>
>
> Testing
> -------
>
> Have tested the patch with mvn clean install -DskipTests
> There are 3 Checkstyle violations as I have kept the .properties files intact.
>
>
> Thanks,
>
> Alisha Prabhu
>
>
Re: Review Request 66084: Oozie-core fails with checkstyle errors.
Posted by András Piros via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66084/#review200041
-----------------------------------------------------------
Ship it!
Ship It!
- András Piros
On March 20, 2018, 5:36 a.m., Alisha Prabhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66084/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 5:36 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-3176
> https://issues.apache.org/jira/browse/OOZIE-3176
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/BundleActionBean.java eeec549
> core/src/main/java/org/apache/oozie/BundleJobBean.java dec0967
> core/src/main/java/org/apache/oozie/CoordinatorActionBean.java ddec1e6
> core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5999f40
> core/src/main/java/org/apache/oozie/CoordinatorJobInfo.java 04c5bc9
> core/src/main/java/org/apache/oozie/DagELFunctions.java 22ac624
> core/src/main/java/org/apache/oozie/SLAEventBean.java b30867b
> core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6b05b89
> core/src/main/java/org/apache/oozie/WorkflowJobBean.java cb06bec
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 122dfd0
> core/src/main/java/org/apache/oozie/client/rest/JsonBean.java c8bd7c2
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 669ac5e
> core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 179cc45
> core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 16d7036
> core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java ff7bf8a
> core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java fbc6152
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 2b91253
> core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1e864ea
> core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 1998924
> core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 42bdc99
> core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 1195ef0
> core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 86ee1cc
> core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 61891b8
> core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 71c29cd
> core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 29ccd32
> core/src/main/java/org/apache/oozie/coord/CoordUtils.java 2874bf6
> core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java f40f406
> core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java 18ceb10
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java 02a4f68
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetRunningActionsCountJPAExecutor.java 274b3c1
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java 51449db
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java 43c7d08
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsBasicInfoFromParentId.java 4b8adfb
> core/src/main/java/org/apache/oozie/service/AuthorizationService.java d76e1ea
> core/src/main/java/org/apache/oozie/service/PurgeService.java c2c966b
> core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 404d3cd
> core/src/main/java/org/apache/oozie/servlet/ServletUtilities.java 9cdd915
> core/src/main/java/org/apache/oozie/servlet/V0AdminServlet.java d4a0989
> core/src/main/java/org/apache/oozie/servlet/V0JobsServlet.java ff50f3d
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 0d275fd
> core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java 5eac78c
> core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java e9ea9ba
> core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java d08521c
> core/src/main/java/org/apache/oozie/store/WorkflowStore.java 821abc5
> core/src/main/java/org/apache/oozie/util/OozieRollingPolicy.java 625053c
> core/src/main/java/org/apache/oozie/util/ParameterVerifier.java f3f4630
> core/src/main/java/org/apache/oozie/util/ParameterVerifierException.java ef9a591
> core/src/main/java/org/apache/oozie/util/PollablePriorityDelayQueue.java 03279eb
> core/src/main/java/org/apache/oozie/util/db/Schema.java 1278be1
> core/src/main/java/org/apache/oozie/workflow/lite/ActionNodeDef.java 97c7134
> core/src/main/java/org/apache/oozie/workflow/lite/DBLiteWorkflowLib.java dd6afa0
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java 78b0652
> core/src/main/resources/localoozie-log4j.properties 906397f
> core/src/test/java/org/apache/hadoop/examples/SleepJob.java 342f8b3
> core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java c6c9c49
> core/src/test/java/org/apache/oozie/TestLocalOozieClientCoord.java 177bff7
> core/src/test/java/org/apache/oozie/action/hadoop/InsertTestToken.java 9558aa5
> core/src/test/java/org/apache/oozie/action/hadoop/TestHadoopELFunctions.java c6ec63c
> core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java b55a3cd
> core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 8d0b441
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobXCommand.java c6ecb5e
> core/src/test/java/org/apache/oozie/command/bundle/TestBundlePauseUnpauseXCommand.java 46819d9
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleRerunXCommand.java 4a10a8b
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleSubmitXCommand.java 429eb0d
> core/src/test/java/org/apache/oozie/command/coord/CoordXTestCase.java 4a25356
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 96ac195
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java db66c72
> core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java b8eb15d
> core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java 111eace
> core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 9a05a85
> core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java dcc97ad
> core/src/test/java/org/apache/oozie/command/coord/TestCoordUpdateXCommand.java 5bee228
> core/src/test/java/org/apache/oozie/command/coord/TestFutureActionsTimeOut.java a6fce4e
> core/src/test/java/org/apache/oozie/command/coord/TestPastActionsTimeOut.java f4327ae
> core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 25d16cf
> core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java dadebb5
> core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 80c5d54
> core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 45cbbc4
> core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java a429665
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForCheckJPAExecutor.java 05d93a8
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForExternalIdJPAExecutor.java 5b748f0
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseStatusCountGetJPAExecutor.java a35c987
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionForNominalTimeJPAExecutor.java 3d90cdf
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsJPAExecutor.java e9fa9f6
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 9ccd62a
> core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowIdGetForExternalIdJPAExecutor.java df57b72
> core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 620dc6d
> core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java 30fd151
> core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java ca5b940
> core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java ebe8e48
> core/src/test/java/org/apache/oozie/service/TestCoordMaterializeTriggerService.java aadf3fb
> core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java 53b7f62
> core/src/test/java/org/apache/oozie/service/TestLiteWorkflowStoreService.java 1eda445
> core/src/test/java/org/apache/oozie/service/TestRecoveryService.java ce04c6d
> core/src/test/java/org/apache/oozie/service/TestSparkConfigurationService.java 1278efa
> core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 0bcbce0
> core/src/test/java/org/apache/oozie/servlet/TestV1AdminServlet.java 534f572
> core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java 03f2323
> core/src/test/java/org/apache/oozie/test/MiniOozieTestCase.java 12ede02
> core/src/test/java/org/apache/oozie/test/XDataTestCase.java 2105e2f
> core/src/test/java/org/apache/oozie/test/XFsTestCase.java 2b33d93
> core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java d8acc99
> core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 3253512
> core/src/test/java/org/apache/oozie/util/TestOozieRollingPolicy.java 051ce56
> core/src/test/java/org/apache/oozie/util/TestParameterVerifier.java 8cd89cb
> core/src/test/java/org/apache/oozie/util/TestXLogFilter.java ec712c9
> core/src/test/java/org/apache/oozie/util/db/TestSqlStatement.java 91a1698
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java 74c1618
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java f5baf6b
> core/src/test/resources/test-custom-log4j.properties 747df01
> core/src/test/resources/test-oozie-log4j.properties 3040d4f
> src/main/resources/checkstyle-header.txt 4247452
> src/main/resources/checkstyle.xml 68b6cce
>
>
> Diff: https://reviews.apache.org/r/66084/diff/3/
>
>
> Testing
> -------
>
> Have tested the patch with mvn clean install -DskipTests
> There are 3 Checkstyle violations as I have kept the .properties files intact.
>
>
> Thanks,
>
> Alisha Prabhu
>
>
Re: Review Request 66084: Oozie-core fails with checkstyle errors.
Posted by Alisha Prabhu <al...@ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66084/
-----------------------------------------------------------
(Updated March 20, 2018, 5:36 a.m.)
Review request for oozie.
Changes
-------
Modified checkstyle.xml, removed checkstyle-header.txt
Bugs: OOZIE-3176
https://issues.apache.org/jira/browse/OOZIE-3176
Repository: oozie-git
Description
-------
There are multiple checkstyle violations in the Oozie-core module.
Maven command used is mvn clean install -DskipTests
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/BundleActionBean.java eeec549
core/src/main/java/org/apache/oozie/BundleJobBean.java dec0967
core/src/main/java/org/apache/oozie/CoordinatorActionBean.java ddec1e6
core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5999f40
core/src/main/java/org/apache/oozie/CoordinatorJobInfo.java 04c5bc9
core/src/main/java/org/apache/oozie/DagELFunctions.java 22ac624
core/src/main/java/org/apache/oozie/SLAEventBean.java b30867b
core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6b05b89
core/src/main/java/org/apache/oozie/WorkflowJobBean.java cb06bec
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 122dfd0
core/src/main/java/org/apache/oozie/client/rest/JsonBean.java c8bd7c2
core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 669ac5e
core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 179cc45
core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 16d7036
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java ff7bf8a
core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java fbc6152
core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 2b91253
core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1e864ea
core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 1998924
core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 42bdc99
core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 1195ef0
core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 86ee1cc
core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 61891b8
core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 71c29cd
core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 29ccd32
core/src/main/java/org/apache/oozie/coord/CoordUtils.java 2874bf6
core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java f40f406
core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java 18ceb10
core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java 02a4f68
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetRunningActionsCountJPAExecutor.java 274b3c1
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java 51449db
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java 43c7d08
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsBasicInfoFromParentId.java 4b8adfb
core/src/main/java/org/apache/oozie/service/AuthorizationService.java d76e1ea
core/src/main/java/org/apache/oozie/service/PurgeService.java c2c966b
core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 404d3cd
core/src/main/java/org/apache/oozie/servlet/ServletUtilities.java 9cdd915
core/src/main/java/org/apache/oozie/servlet/V0AdminServlet.java d4a0989
core/src/main/java/org/apache/oozie/servlet/V0JobsServlet.java ff50f3d
core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 0d275fd
core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java 5eac78c
core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java e9ea9ba
core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java d08521c
core/src/main/java/org/apache/oozie/store/WorkflowStore.java 821abc5
core/src/main/java/org/apache/oozie/util/OozieRollingPolicy.java 625053c
core/src/main/java/org/apache/oozie/util/ParameterVerifier.java f3f4630
core/src/main/java/org/apache/oozie/util/ParameterVerifierException.java ef9a591
core/src/main/java/org/apache/oozie/util/PollablePriorityDelayQueue.java 03279eb
core/src/main/java/org/apache/oozie/util/db/Schema.java 1278be1
core/src/main/java/org/apache/oozie/workflow/lite/ActionNodeDef.java 97c7134
core/src/main/java/org/apache/oozie/workflow/lite/DBLiteWorkflowLib.java dd6afa0
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java 78b0652
core/src/main/resources/localoozie-log4j.properties 906397f
core/src/test/java/org/apache/hadoop/examples/SleepJob.java 342f8b3
core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java c6c9c49
core/src/test/java/org/apache/oozie/TestLocalOozieClientCoord.java 177bff7
core/src/test/java/org/apache/oozie/action/hadoop/InsertTestToken.java 9558aa5
core/src/test/java/org/apache/oozie/action/hadoop/TestHadoopELFunctions.java c6ec63c
core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java b55a3cd
core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 8d0b441
core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobXCommand.java c6ecb5e
core/src/test/java/org/apache/oozie/command/bundle/TestBundlePauseUnpauseXCommand.java 46819d9
core/src/test/java/org/apache/oozie/command/bundle/TestBundleRerunXCommand.java 4a10a8b
core/src/test/java/org/apache/oozie/command/bundle/TestBundleSubmitXCommand.java 429eb0d
core/src/test/java/org/apache/oozie/command/coord/CoordXTestCase.java 4a25356
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 96ac195
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java db66c72
core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java b8eb15d
core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java 111eace
core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 9a05a85
core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java dcc97ad
core/src/test/java/org/apache/oozie/command/coord/TestCoordUpdateXCommand.java 5bee228
core/src/test/java/org/apache/oozie/command/coord/TestFutureActionsTimeOut.java a6fce4e
core/src/test/java/org/apache/oozie/command/coord/TestPastActionsTimeOut.java f4327ae
core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 25d16cf
core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java dadebb5
core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 80c5d54
core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 45cbbc4
core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java a429665
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForCheckJPAExecutor.java 05d93a8
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForExternalIdJPAExecutor.java 5b748f0
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseStatusCountGetJPAExecutor.java a35c987
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionForNominalTimeJPAExecutor.java 3d90cdf
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsJPAExecutor.java e9fa9f6
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 9ccd62a
core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowIdGetForExternalIdJPAExecutor.java df57b72
core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 620dc6d
core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java 30fd151
core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java ca5b940
core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java ebe8e48
core/src/test/java/org/apache/oozie/service/TestCoordMaterializeTriggerService.java aadf3fb
core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java 53b7f62
core/src/test/java/org/apache/oozie/service/TestLiteWorkflowStoreService.java 1eda445
core/src/test/java/org/apache/oozie/service/TestRecoveryService.java ce04c6d
core/src/test/java/org/apache/oozie/service/TestSparkConfigurationService.java 1278efa
core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 0bcbce0
core/src/test/java/org/apache/oozie/servlet/TestV1AdminServlet.java 534f572
core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java 03f2323
core/src/test/java/org/apache/oozie/test/MiniOozieTestCase.java 12ede02
core/src/test/java/org/apache/oozie/test/XDataTestCase.java 2105e2f
core/src/test/java/org/apache/oozie/test/XFsTestCase.java 2b33d93
core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java d8acc99
core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 3253512
core/src/test/java/org/apache/oozie/util/TestOozieRollingPolicy.java 051ce56
core/src/test/java/org/apache/oozie/util/TestParameterVerifier.java 8cd89cb
core/src/test/java/org/apache/oozie/util/TestXLogFilter.java ec712c9
core/src/test/java/org/apache/oozie/util/db/TestSqlStatement.java 91a1698
core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java 74c1618
core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java f5baf6b
core/src/test/resources/test-custom-log4j.properties 747df01
core/src/test/resources/test-oozie-log4j.properties 3040d4f
src/main/resources/checkstyle-header.txt 4247452
src/main/resources/checkstyle.xml 68b6cce
Diff: https://reviews.apache.org/r/66084/diff/3/
Changes: https://reviews.apache.org/r/66084/diff/2-3/
Testing
-------
Have tested the patch with mvn clean install -DskipTests
There are 3 Checkstyle violations as I have kept the .properties files intact.
Thanks,
Alisha Prabhu
Re: Review Request 66084: Oozie-core fails with checkstyle errors.
Posted by Alisha Prabhu <al...@ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66084/
-----------------------------------------------------------
(Updated March 19, 2018, 12:32 p.m.)
Review request for oozie.
Bugs: OOZIE-3176
https://issues.apache.org/jira/browse/OOZIE-3176
Repository: oozie-git
Description
-------
There are multiple checkstyle violations in the Oozie-core module.
Maven command used is mvn clean install -DskipTests
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/BundleActionBean.java eeec549
core/src/main/java/org/apache/oozie/BundleJobBean.java dec0967
core/src/main/java/org/apache/oozie/CoordinatorActionBean.java ddec1e6
core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5999f40
core/src/main/java/org/apache/oozie/CoordinatorJobInfo.java 04c5bc9
core/src/main/java/org/apache/oozie/DagELFunctions.java 22ac624
core/src/main/java/org/apache/oozie/SLAEventBean.java b30867b
core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6b05b89
core/src/main/java/org/apache/oozie/WorkflowJobBean.java cb06bec
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 122dfd0
core/src/main/java/org/apache/oozie/client/rest/JsonBean.java c8bd7c2
core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 669ac5e
core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 179cc45
core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 16d7036
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java ff7bf8a
core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java fbc6152
core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 2b91253
core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1e864ea
core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 1998924
core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 42bdc99
core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 1195ef0
core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 86ee1cc
core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 61891b8
core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 71c29cd
core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 29ccd32
core/src/main/java/org/apache/oozie/coord/CoordUtils.java 2874bf6
core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java f40f406
core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java 18ceb10
core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java 02a4f68
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetRunningActionsCountJPAExecutor.java 274b3c1
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java 51449db
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java 43c7d08
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsBasicInfoFromParentId.java 4b8adfb
core/src/main/java/org/apache/oozie/service/AuthorizationService.java d76e1ea
core/src/main/java/org/apache/oozie/service/PurgeService.java c2c966b
core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 404d3cd
core/src/main/java/org/apache/oozie/servlet/ServletUtilities.java 9cdd915
core/src/main/java/org/apache/oozie/servlet/V0AdminServlet.java d4a0989
core/src/main/java/org/apache/oozie/servlet/V0JobsServlet.java ff50f3d
core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 0d275fd
core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java 5eac78c
core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java e9ea9ba
core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java d08521c
core/src/main/java/org/apache/oozie/store/WorkflowStore.java 821abc5
core/src/main/java/org/apache/oozie/util/OozieRollingPolicy.java 625053c
core/src/main/java/org/apache/oozie/util/ParameterVerifier.java f3f4630
core/src/main/java/org/apache/oozie/util/ParameterVerifierException.java ef9a591
core/src/main/java/org/apache/oozie/util/PollablePriorityDelayQueue.java 03279eb
core/src/main/java/org/apache/oozie/util/db/Schema.java 1278be1
core/src/main/java/org/apache/oozie/workflow/lite/ActionNodeDef.java 97c7134
core/src/main/java/org/apache/oozie/workflow/lite/DBLiteWorkflowLib.java dd6afa0
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java 78b0652
core/src/main/resources/localoozie-log4j.properties 906397f
core/src/test/java/org/apache/hadoop/examples/SleepJob.java 342f8b3
core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java c6c9c49
core/src/test/java/org/apache/oozie/TestLocalOozieClientCoord.java 177bff7
core/src/test/java/org/apache/oozie/action/hadoop/InsertTestToken.java 9558aa5
core/src/test/java/org/apache/oozie/action/hadoop/TestHadoopELFunctions.java c6ec63c
core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java b55a3cd
core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 8d0b441
core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobXCommand.java c6ecb5e
core/src/test/java/org/apache/oozie/command/bundle/TestBundlePauseUnpauseXCommand.java 46819d9
core/src/test/java/org/apache/oozie/command/bundle/TestBundleRerunXCommand.java 4a10a8b
core/src/test/java/org/apache/oozie/command/bundle/TestBundleSubmitXCommand.java 429eb0d
core/src/test/java/org/apache/oozie/command/coord/CoordXTestCase.java 4a25356
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 96ac195
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java db66c72
core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java b8eb15d
core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java 111eace
core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 9a05a85
core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java dcc97ad
core/src/test/java/org/apache/oozie/command/coord/TestCoordUpdateXCommand.java 5bee228
core/src/test/java/org/apache/oozie/command/coord/TestFutureActionsTimeOut.java a6fce4e
core/src/test/java/org/apache/oozie/command/coord/TestPastActionsTimeOut.java f4327ae
core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 25d16cf
core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java dadebb5
core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 80c5d54
core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 45cbbc4
core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java a429665
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForCheckJPAExecutor.java 05d93a8
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForExternalIdJPAExecutor.java 5b748f0
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseStatusCountGetJPAExecutor.java a35c987
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionForNominalTimeJPAExecutor.java 3d90cdf
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsJPAExecutor.java e9fa9f6
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 9ccd62a
core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowIdGetForExternalIdJPAExecutor.java df57b72
core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 620dc6d
core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java 30fd151
core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java ca5b940
core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java ebe8e48
core/src/test/java/org/apache/oozie/service/TestCoordMaterializeTriggerService.java aadf3fb
core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java 53b7f62
core/src/test/java/org/apache/oozie/service/TestLiteWorkflowStoreService.java 1eda445
core/src/test/java/org/apache/oozie/service/TestRecoveryService.java ce04c6d
core/src/test/java/org/apache/oozie/service/TestSparkConfigurationService.java 1278efa
core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 0bcbce0
core/src/test/java/org/apache/oozie/servlet/TestV1AdminServlet.java 534f572
core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java 03f2323
core/src/test/java/org/apache/oozie/test/MiniOozieTestCase.java 12ede02
core/src/test/java/org/apache/oozie/test/XDataTestCase.java 2105e2f
core/src/test/java/org/apache/oozie/test/XFsTestCase.java 2b33d93
core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java d8acc99
core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 3253512
core/src/test/java/org/apache/oozie/util/TestOozieRollingPolicy.java 051ce56
core/src/test/java/org/apache/oozie/util/TestParameterVerifier.java 8cd89cb
core/src/test/java/org/apache/oozie/util/TestXLogFilter.java ec712c9
core/src/test/java/org/apache/oozie/util/db/TestSqlStatement.java 91a1698
core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java 74c1618
core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java f5baf6b
core/src/test/resources/test-custom-log4j.properties 747df01
core/src/test/resources/test-oozie-log4j.properties 3040d4f
Diff: https://reviews.apache.org/r/66084/diff/2/
Changes: https://reviews.apache.org/r/66084/diff/1-2/
Testing
-------
Have tested the patch with mvn clean install -DskipTests
There are 3 Checkstyle violations as I have kept the .properties files intact.
Thanks,
Alisha Prabhu