You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/09/03 18:06:22 UTC

Review Request 25301: CLOUDSTACK-7442: Fixed template permission issue in test_project_resources.py

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25301/
-----------------------------------------------------------

Review request for cloudstack, sanjeev n, Santhosh Edukulla, and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-7442
    https://issues.apache.org/jira/browse/CLOUDSTACK-7442


Repository: cloudstack-git


Description
-------

The template was registered with admin api client, hence it failed to find the project in the domain while updating the permissions.

The permissions can only be updated if the resource is present in the same domain as that of the owner account of the template.

Registered the template with the api client of the account in which the project is added, so that the permissions for template can  successfully be updated for the project.


Diffs
-----

  test/integration/component/test_project_resources.py e769860 

Diff: https://reviews.apache.org/r/25301/diff/


Testing
-------

Yes.

Log:
Test use of private template in a project ... === TestName: test_05_use_private_template_in_project | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 1 test in 674.081s

OK


Thanks,

Gaurav Aradhye


Re: Review Request 25301: CLOUDSTACK-7442: Fixed template permission issue in test_project_resources.py

Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25301/#review52294
-----------------------------------------------------------

Ship it!


Ship It!

- SrikanteswaraRao Talluri


On Sept. 3, 2014, 4:06 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25301/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2014, 4:06 p.m.)
> 
> 
> Review request for cloudstack, sanjeev n, Santhosh Edukulla, and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7442
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7442
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The template was registered with admin api client, hence it failed to find the project in the domain while updating the permissions.
> 
> The permissions can only be updated if the resource is present in the same domain as that of the owner account of the template.
> 
> Registered the template with the api client of the account in which the project is added, so that the permissions for template can  successfully be updated for the project.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_project_resources.py e769860 
> 
> Diff: https://reviews.apache.org/r/25301/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> Log:
> Test use of private template in a project ... === TestName: test_05_use_private_template_in_project | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 674.081s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Re: Review Request 25301: CLOUDSTACK-7442: Fixed template permission issue in test_project_resources.py

Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25301/#review52293
-----------------------------------------------------------


Gentle Reminder

- Gaurav Aradhye


On Sept. 3, 2014, 9:36 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25301/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2014, 9:36 p.m.)
> 
> 
> Review request for cloudstack, sanjeev n, Santhosh Edukulla, and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7442
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7442
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The template was registered with admin api client, hence it failed to find the project in the domain while updating the permissions.
> 
> The permissions can only be updated if the resource is present in the same domain as that of the owner account of the template.
> 
> Registered the template with the api client of the account in which the project is added, so that the permissions for template can  successfully be updated for the project.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_project_resources.py e769860 
> 
> Diff: https://reviews.apache.org/r/25301/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> Log:
> Test use of private template in a project ... === TestName: test_05_use_private_template_in_project | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 674.081s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Re: Review Request 25301: CLOUDSTACK-7442: Fixed template permission issue in test_project_resources.py

Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25301/#review52296
-----------------------------------------------------------


pushed to master : abfb469f910b2e16b0d439c57f5878dd5ae46526

- SrikanteswaraRao Talluri


On Sept. 3, 2014, 4:06 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25301/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2014, 4:06 p.m.)
> 
> 
> Review request for cloudstack, sanjeev n, Santhosh Edukulla, and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7442
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7442
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The template was registered with admin api client, hence it failed to find the project in the domain while updating the permissions.
> 
> The permissions can only be updated if the resource is present in the same domain as that of the owner account of the template.
> 
> Registered the template with the api client of the account in which the project is added, so that the permissions for template can  successfully be updated for the project.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_project_resources.py e769860 
> 
> Diff: https://reviews.apache.org/r/25301/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> Log:
> Test use of private template in a project ... === TestName: test_05_use_private_template_in_project | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 674.081s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>