You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by "Paul J. Reder (JIRA)" <ji...@apache.org> on 2010/07/23 20:45:51 UTC

[jira] Created: (OWB-422) Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.

Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.
------------------------------------------------------------------------------------

                 Key: OWB-422
                 URL: https://issues.apache.org/jira/browse/OWB-422
             Project: OpenWebBeans
          Issue Type: Bug
          Components: Core
    Affects Versions: 1.0.0-alpha-1
         Environment: All
            Reporter: Paul J. Reder
            Assignee: Gurkan Erdogdu
             Fix For: 1.0.0-alpha-1


Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OWB-422) Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.

Posted by "Paul J. Reder (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OWB-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul J. Reder updated OWB-422:
------------------------------

    Attachment: PrePassivate_PostActivate_AroundTimeout.patch

Attached patch adds support for PrePassivate, PostActivate, and AroundTimeout via OWB EJB Interceptor for CDI managed beans.

> Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.
> ------------------------------------------------------------------------------------
>
>                 Key: OWB-422
>                 URL: https://issues.apache.org/jira/browse/OWB-422
>             Project: OpenWebBeans
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.0-alpha-1
>         Environment: All
>            Reporter: Paul J. Reder
>            Assignee: Gurkan Erdogdu
>             Fix For: 1.0.0-alpha-1
>
>         Attachments: PrePassivate_PostActivate_AroundTimeout.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OWB-422) Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.

Posted by "Gurkan Erdogdu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OWB-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898297#action_12898297 ] 

Gurkan Erdogdu commented on OWB-422:
------------------------------------

Very cool patch, thanks.

> Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.
> ------------------------------------------------------------------------------------
>
>                 Key: OWB-422
>                 URL: https://issues.apache.org/jira/browse/OWB-422
>             Project: OpenWebBeans
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.0-alpha-1
>         Environment: All
>            Reporter: Paul J. Reder
>            Assignee: Eric Covener
>             Fix For: 1.0.0-alpha-2
>
>         Attachments: plugin-based_PrePassivate_PostActivate_AroundTimeout.patch, PrePassivate_PostActivate_AroundTimeout.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OWB-422) Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.

Posted by "Paul J. Reder (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OWB-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul J. Reder updated OWB-422:
------------------------------

    Attachment: plugin-based_PrePassivate_PostActivate_AroundTimeout.patch

I finally found the time to refactor the original patch to use an EJB plugin instead of dragging javax.ejb into webbeans-impl.

> Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.
> ------------------------------------------------------------------------------------
>
>                 Key: OWB-422
>                 URL: https://issues.apache.org/jira/browse/OWB-422
>             Project: OpenWebBeans
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.0-alpha-1
>         Environment: All
>            Reporter: Paul J. Reder
>            Assignee: Eric Covener
>             Fix For: 1.0.0-alpha-2
>
>         Attachments: plugin-based_PrePassivate_PostActivate_AroundTimeout.patch, PrePassivate_PostActivate_AroundTimeout.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (OWB-422) Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.

Posted by "Eric Covener (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OWB-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Covener reassigned OWB-422:
--------------------------------

    Assignee: Eric Covener  (was: Gurkan Erdogdu)

> Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.
> ------------------------------------------------------------------------------------
>
>                 Key: OWB-422
>                 URL: https://issues.apache.org/jira/browse/OWB-422
>             Project: OpenWebBeans
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.0-alpha-1
>         Environment: All
>            Reporter: Paul J. Reder
>            Assignee: Eric Covener
>             Fix For: 1.0.0-alpha-1
>
>         Attachments: PrePassivate_PostActivate_AroundTimeout.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OWB-422) Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.

Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OWB-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892306#action_12892306 ] 

Mark Struberg commented on OWB-422:
-----------------------------------

The current solution pulls in a EJB spec dependencies to webbeans-impl. But all EJB dependencies should only get pulled in via the webbeans-ejb plugin and webbeans-impl shall remain Java-SE only!

> Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.
> ------------------------------------------------------------------------------------
>
>                 Key: OWB-422
>                 URL: https://issues.apache.org/jira/browse/OWB-422
>             Project: OpenWebBeans
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.0-alpha-1
>         Environment: All
>            Reporter: Paul J. Reder
>            Assignee: Eric Covener
>             Fix For: 1.0.0-alpha-2
>
>         Attachments: PrePassivate_PostActivate_AroundTimeout.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (OWB-422) Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.

Posted by "Rohit Dilip Kelapure (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OWB-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rohit Dilip Kelapure reopened OWB-422:
--------------------------------------

      Assignee: Rohit Dilip Kelapure  (was: Eric Covener)

Reopening OWB-422 because there is no @AroundTimeout code in the OpenWebBeansEjbInterceptor.
Fixing this by adding 

    @AroundTimeout
    public Object callAroundTimeouts(InvocationContext context) throws Exception
    .....
    ......


> Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.
> ------------------------------------------------------------------------------------
>
>                 Key: OWB-422
>                 URL: https://issues.apache.org/jira/browse/OWB-422
>             Project: OpenWebBeans
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.0-alpha-1
>         Environment: All
>            Reporter: Paul J. Reder
>            Assignee: Rohit Dilip Kelapure
>             Fix For: 1.0.0
>
>         Attachments: plugin-based_PrePassivate_PostActivate_AroundTimeout.patch, PrePassivate_PostActivate_AroundTimeout.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OWB-422) Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.

Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OWB-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Struberg updated OWB-422:
------------------------------

    Fix Version/s:     (was: 1.0.0)
                   1.1.0

> Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.
> ------------------------------------------------------------------------------------
>
>                 Key: OWB-422
>                 URL: https://issues.apache.org/jira/browse/OWB-422
>             Project: OpenWebBeans
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.0-alpha-1
>         Environment: All
>            Reporter: Paul J. Reder
>            Assignee: Rohit Dilip Kelapure
>             Fix For: 1.1.0
>
>         Attachments: plugin-based_PrePassivate_PostActivate_AroundTimeout.patch, PrePassivate_PostActivate_AroundTimeout.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (OWB-422) Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.

Posted by "Paul J. Reder (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OWB-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul J. Reder resolved OWB-422.
-------------------------------

    Resolution: Fixed

Rohit checked in all the changes required to finish this off.

> Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.
> ------------------------------------------------------------------------------------
>
>                 Key: OWB-422
>                 URL: https://issues.apache.org/jira/browse/OWB-422
>             Project: OpenWebBeans
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.0-alpha-1
>         Environment: All
>            Reporter: Paul J. Reder
>            Assignee: Rohit Dilip Kelapure
>             Fix For: 1.1.0
>
>         Attachments: plugin-based_PrePassivate_PostActivate_AroundTimeout.patch, PrePassivate_PostActivate_AroundTimeout.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OWB-422) Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.

Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OWB-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892312#action_12892312 ] 

Mark Struberg commented on OWB-422:
-----------------------------------

the patch introduces EJB dependencies in webbeans-impl.

Is there some way to drop this again and move all the EJB specific logic to webbeans-ejb?

We could e.g. introduce a WebBeansEjbInterceptor extends WebBeansInterceptor which contains this logic in webbeans-ejb.

> Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.
> ------------------------------------------------------------------------------------
>
>                 Key: OWB-422
>                 URL: https://issues.apache.org/jira/browse/OWB-422
>             Project: OpenWebBeans
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.0-alpha-1
>         Environment: All
>            Reporter: Paul J. Reder
>            Assignee: Eric Covener
>             Fix For: 1.0.0-alpha-2
>
>         Attachments: PrePassivate_PostActivate_AroundTimeout.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OWB-422) Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.

Posted by "Gurkan Erdogdu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OWB-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gurkan Erdogdu updated OWB-422:
-------------------------------

    Fix Version/s: 1.0.0-alpha-2
                       (was: 1.0.0-alpha-1)

> Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.
> ------------------------------------------------------------------------------------
>
>                 Key: OWB-422
>                 URL: https://issues.apache.org/jira/browse/OWB-422
>             Project: OpenWebBeans
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.0-alpha-1
>         Environment: All
>            Reporter: Paul J. Reder
>            Assignee: Eric Covener
>             Fix For: 1.0.0-alpha-2
>
>         Attachments: PrePassivate_PostActivate_AroundTimeout.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (OWB-422) Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.

Posted by "Eric Covener (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OWB-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Covener resolved OWB-422.
------------------------------

    Fix Version/s: 1.0.0-alpha-3
                       (was: 1.0.0-GA)
       Resolution: Fixed

committed with minor changes in r1001913

> Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.
> ------------------------------------------------------------------------------------
>
>                 Key: OWB-422
>                 URL: https://issues.apache.org/jira/browse/OWB-422
>             Project: OpenWebBeans
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.0-alpha-1
>         Environment: All
>            Reporter: Paul J. Reder
>            Assignee: Eric Covener
>             Fix For: 1.0.0-alpha-3
>
>         Attachments: plugin-based_PrePassivate_PostActivate_AroundTimeout.patch, PrePassivate_PostActivate_AroundTimeout.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.