[GitHub] [flink] dawidwys commented on a change in pull request #10879: [FLINK-15595][table] Remove CoreMudule in ModuleManager

[GitBox <gi...@apache.org>]

dawidwys commented on a change in pull request #10879: [FLINK-15595][table] Remove CoreMudule in ModuleManager
URL: https://github.com/apache/flink/pull/10879#discussion_r368399413
 
 

 ##########
 File path: docs/dev/table/functions/index.md
 ##########
 @@ -84,11 +84,13 @@ The resolution order is:
 1. Temporary catalog function
 2. Catalog function
 
-## Ambiguous Function Reference
+### Ambiguous Function Reference
 
 The resolution order is:
 
 1. Temporary system function
-2. System function
-3. Temporary catalog function, in the current catalog and current database of the session
-4. Catalog function, in the current catalog and current database of the session
+2. Temporary catalog function, in the current catalog and current database of the session
 
 Review comment:
   I agree we should have the resolution order as defined in FLIP-57. Unfortunately as I understand the state of the implementation we have an order as follows:
   1. Temporary system functions
   2. Modules system functions
   3. Temporary catalog functions
   4. Catalog functions
   5. Built-in functions

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services