You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by ph...@apache.org on 2010/12/09 17:28:33 UTC
svn commit: r1044023 - /subversion/trunk/subversion/tests/libsvn_wc/db-test.c
Author: philip
Date: Thu Dec 9 16:28:33 2010
New Revision: 1044023
URL: http://svn.apache.org/viewvc?rev=1044023&view=rev
Log:
* subversion/tests/libsvn_wc/db-test.c
(test_scan_deletion): Make one test result conditional on
SVN_WC__OP_DEPTH, add some comments expressing concern about
the results.
Modified:
subversion/trunk/subversion/tests/libsvn_wc/db-test.c
Modified: subversion/trunk/subversion/tests/libsvn_wc/db-test.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/libsvn_wc/db-test.c?rev=1044023&r1=1044022&r2=1044023&view=diff
==============================================================================
--- subversion/trunk/subversion/tests/libsvn_wc/db-test.c (original)
+++ subversion/trunk/subversion/tests/libsvn_wc/db-test.c Thu Dec 9 16:28:33 2010
@@ -1172,12 +1172,22 @@ test_scan_deletion(apr_pool_t *pool)
&work_del_abspath,
db, svn_dirent_join(local_abspath, "J/J-e/J-e-b/Jeba", pool),
pool, pool));
+ /* ### I don't understand this. "J/J-e/J-e-b/Jeba" is a deleted
+ base node that is not overlayed by the replacement rooted at "J".
+ Why does base_del_abspath refer to "J-e"? */
SVN_TEST_ASSERT(validate_abspath(local_abspath, "J/J-e",
base_del_abspath, pool));
SVN_TEST_ASSERT(validate_abspath(local_abspath, "other/place",
moved_to_abspath, pool));
+#ifndef SVN_WC__OP_DEPTH
+ /* ### I don't understand this. "J/J-e/J-e-b/Jeba" is a deleted
+ base node that is not overlayed by the replacement rooted at "J".
+ Why is work_del_abspath not NULL? */
SVN_TEST_ASSERT(validate_abspath(local_abspath, "J/J-e",
work_del_abspath, pool));
+#else
+ SVN_TEST_ASSERT(work_del_abspath == NULL);
+#endif
/* Base-deleted tree extending past added WORKING tree. */
SVN_ERR(svn_wc__db_scan_deletion(