You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shenyu.apache.org by "xuziyang (via GitHub)" <gi...@apache.org> on 2023/07/07 00:50:20 UTC

[GitHub] [shenyu] xuziyang commented on pull request #4806: [ISSUE #4686] ZookeeperClientRegisterRepository active offline

xuziyang commented on PR #4806:
URL: https://github.com/apache/shenyu/pull/4806#issuecomment-1624483162

   > need impl `offline` for `ZookeeperClientRegisterRepository`.
   
   Personally, I believe that there is no need to implement the offline () method for the following reasons:
   
   When the client side service stops, ShenyuClientShutdownHook will be triggered, which will close zkClient. After closing zkClient, the registered URI information will naturally be deleted by zk, and shenyu admin can sense the offline of the service.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org