You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Mike Drob (JIRA)" <ji...@apache.org> on 2016/08/29 18:14:20 UTC

[jira] [Updated] (SOLR-8589) Add aliases to the LIST action results in the Collections API

     [ https://issues.apache.org/jira/browse/SOLR-8589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mike Drob updated SOLR-8589:
----------------------------
    Attachment: SOLR-8589.patch

[~janhoy], thanks for the review. A couple questions based on your feedback -

bq. There are a few string constants that could be moved to {{CollectionAdminParams}}
If we do this, do you think there is going to be confusion between when to use {{CollectionAdminParams.COLLECTION}} and {{CollectionAdminParams.COLLECTIONS}}? That's the only potential downside that I can see.

bq. Also, I think we should return aliases by default.
I don't know if there is anybody out there that has some kind of monitoring script set up to parse the result of {{LIST}}, and in general I try to be super conservative about changing APIs. Maybe we default to returning them in 7.0, and not returning them in 6.x? That sounds like a fair compromise to me.

bq. This patch should also update related LIST tests in {{CollectionsAPISolrJTest}}.
Sure. I'm wary of scope creep, but it also makes sense to expand {{CollectionAdminRequest.List}} capabilities to allow toggling for collection and aliases as well.

bq. Also it should update JavaDoc comments where they say that the LIST command lists collections to include that it also lists aliases...
I think I got all of these, let me know if I missed some.

> Add aliases to the LIST action results in the Collections API
> -------------------------------------------------------------
>
>                 Key: SOLR-8589
>                 URL: https://issues.apache.org/jira/browse/SOLR-8589
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrCloud
>    Affects Versions: 5.4.1
>            Reporter: Shawn Heisey
>            Assignee: Shawn Heisey
>            Priority: Minor
>         Attachments: SOLR-8589.patch, SOLR-8589.patch, SOLR-8589.patch, SOLR-8589.patch, solr-8589-new-list-details-aliases.png
>
>
> Although it is possible to get a list of SolrCloud aliases vi an HTTP API, it is not available as a typical query response, I believe it is only available via the http API for zookeeper.
> The results from the LIST action in the Collections API is well-situated to handle this. The current results are contained in a "collections" node, we can simply add an "aliases" node if there are any aliases defined.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org