[GitHub] ivankelly commented on a change in pull request #873: Issue280: Add StateManager to manage Bookie's state, and use it to turn bookie into readonly when sortedLedgerStorage failed to flush data

[GitBox <gi...@apache.org>]

ivankelly commented on a change in pull request #873: Issue280: Add StateManager to manage Bookie's state, and use it to turn bookie into readonly when sortedLedgerStorage failed to flush data
URL: https://github.com/apache/bookkeeper/pull/873#discussion_r159857218
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java
 ##########
 @@ -233,4 +236,10 @@ public void onRotateEntryLog() {
         // can happen because compaction. in a sorted ledger storage, checkpoint should happen after the data is
         // flushed to the entry log file.
     }
+
+    @VisibleForTesting
 
 Review comment:
   Not needed. The test using this can record the state manager as ledger storage instance is being created.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services