[GitHub] [spark] LuciferYang commented on a diff in pull request #43129: no-java-comments

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on code in PR #43129:
URL: https://github.com/apache/spark/pull/43129#discussion_r1337181033


##########
project/SparkBuild.scala:
##########
@@ -358,7 +358,7 @@ object SparkBuild extends PomBuild {
       "-doc-title", "Spark " + version.value.replaceAll("-SNAPSHOT", "") + " ScalaDoc"
     ) ++ {
       // Do not attempt to scaladoc javadoc comments under 2.12 since it can't handle inner classes
-      if (scalaBinaryVersion.value == "2.12") Seq("-no-java-comments") else Seq.empty
+      if (scalaBinaryVersion.value == "2.13") Seq("-no-java-comments") else Seq.empty

Review Comment:
   @srowen @easel I've found a leftover Scala 2.12 version check here, but when using the check method provided in https://github.com/apache/spark/pull/20042: `sbt tags/publishLocal`, I couldn't distinguish the scala doc built with or without `-no-java-comments`. I hope to get your help,  how should we determine whether to keep the option `-no-java-comments` for Scala 2.13? Thanks ~



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org