You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/05/05 23:51:17 UTC
Re: Review Request 33505: Add state-summary endpoint to master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33505/
-----------------------------------------------------------
(Updated May 5, 2015, 9:51 p.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos
Description
-------
This exposes framework and slave statistics that are of high importance and aggregated per framework or slave respectively.
The statistics will not be exact due to the circular buffer that stores completed tasks, but this was also an issue with state.json.
Diffs (updated)
-----
src/master/http.cpp fb448256d7ced1f47ea48ccfca2ae267bc26ef94
src/master/master.hpp 49ee050ca4d2b2c5f75ce864fcf6ae703dfdeadd
src/master/master.cpp bee842557c8397428ca51e46faa182a391584be3
src/tests/master_tests.cpp bdfccb2427cba938dbbaa8e832255153172b0501
Diff: https://reviews.apache.org/r/33505/diff/
Testing
-------
make check
Thanks,
Joris Van Remoortere
Re: Review Request 33505: Add state-summary endpoint to master.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33505/#review82609
-----------------------------------------------------------
Patch looks great!
Reviews applied: [33643, 33505]
All tests passed.
- Mesos ReviewBot
On May 5, 2015, 9:51 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33505/
> -----------------------------------------------------------
>
> (Updated May 5, 2015, 9:51 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This exposes framework and slave statistics that are of high importance and aggregated per framework or slave respectively.
> The statistics will not be exact due to the circular buffer that stores completed tasks, but this was also an issue with state.json.
>
>
> Diffs
> -----
>
> src/master/http.cpp fb448256d7ced1f47ea48ccfca2ae267bc26ef94
> src/master/master.hpp 49ee050ca4d2b2c5f75ce864fcf6ae703dfdeadd
> src/master/master.cpp bee842557c8397428ca51e46faa182a391584be3
> src/tests/master_tests.cpp bdfccb2427cba938dbbaa8e832255153172b0501
>
> Diff: https://reviews.apache.org/r/33505/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 33505: Add state-summary endpoint to master.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On May 5, 2015, 10:36 p.m., Ben Mahler wrote:
> > Is there a ticket for this? Would love to get a higher level view of the motivation for the new endpoint and its format. A bit tough to tell what a sample response looks like without reading through this diff carefully. :)
There should have been a JIRA issue for this, my apologies for not making sure that was created as the shepherd. BenM, the basic idea here is to start making endpoints where we can get cluster state information without having to always get the entirety of 'state.json'.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33505/#review82596
-----------------------------------------------------------
On May 5, 2015, 9:51 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33505/
> -----------------------------------------------------------
>
> (Updated May 5, 2015, 9:51 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This exposes framework and slave statistics that are of high importance and aggregated per framework or slave respectively.
> The statistics will not be exact due to the circular buffer that stores completed tasks, but this was also an issue with state.json.
>
>
> Diffs
> -----
>
> src/master/http.cpp fb448256d7ced1f47ea48ccfca2ae267bc26ef94
> src/master/master.hpp 49ee050ca4d2b2c5f75ce864fcf6ae703dfdeadd
> src/master/master.cpp bee842557c8397428ca51e46faa182a391584be3
> src/tests/master_tests.cpp bdfccb2427cba938dbbaa8e832255153172b0501
>
> Diff: https://reviews.apache.org/r/33505/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 33505: Add state-summary endpoint to master.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33505/#review82596
-----------------------------------------------------------
Is there a ticket for this? Would love to get a higher level view of the motivation for the new endpoint and its format. A bit tough to tell what a sample response looks like without reading through this diff carefully. :)
- Ben Mahler
On May 5, 2015, 9:51 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33505/
> -----------------------------------------------------------
>
> (Updated May 5, 2015, 9:51 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This exposes framework and slave statistics that are of high importance and aggregated per framework or slave respectively.
> The statistics will not be exact due to the circular buffer that stores completed tasks, but this was also an issue with state.json.
>
>
> Diffs
> -----
>
> src/master/http.cpp fb448256d7ced1f47ea48ccfca2ae267bc26ef94
> src/master/master.hpp 49ee050ca4d2b2c5f75ce864fcf6ae703dfdeadd
> src/master/master.cpp bee842557c8397428ca51e46faa182a391584be3
> src/tests/master_tests.cpp bdfccb2427cba938dbbaa8e832255153172b0501
>
> Diff: https://reviews.apache.org/r/33505/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joris Van Remoortere
>
>