You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Attila Doroszlai <ad...@hortonworks.com> on 2017/11/13 14:31:18 UTC
Review Request 63754: AMBARI-22426. Push down Logger instances
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63754/
-----------------------------------------------------------
Review request for Ambari, Attila Magyar, Balázs Bence Sári, and Jonathan Hurley.
Bugs: AMBARI-22426
https://issues.apache.org/jira/browse/AMBARI-22426
Repository: ambari
Description
-------
Make (almost) all loggers private, push down to subclasses, keep in super class if also used there.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/handlers/BaseManagementHandler.java d0bd5d32f50820adfecfc2282f253e9ae03fbeb3
ambari-server/src/main/java/org/apache/ambari/server/api/handlers/CreateHandler.java 549da76b3b0c1651507d612b037f3d70715cb7be
ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java d24780b4ac191743d1e2c2cf4ea8c62c6f5844da
ambari-server/src/main/java/org/apache/ambari/server/api/services/LoggingService.java c86b9a0e50958c693b3f52f1de3aa3df1783fdd4
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java 2dc45de22655d7c7a69a11335a50f6d130cef34a
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java 34888f2408b7abcb75825acc1f6b6d15ea9fe2fa
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java e134f6dc6ef9850bb4e8d2cc58b7bf7c860f4da0
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractPropertyProvider.java 322596ea5e96c1e17433ad339f39d16898384015
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 1501a0186a315cff2391e0aadbe8c3232bb4d9ee
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractResourceProvider.java 5598650ef1681557464eed5cfbb573f2ecc33c95
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java 4e618e7ff63679086b507103adee2bc7736a16c4
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java 32f1fd8f4fcbddd47972add304648db9f44ba8a3
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java cf4e7475b3ab6ed1e5375af23dcbe28d0533c839
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java c71651e5ff0be669646950cc41b0aa56e73c47f0
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java 43ee7fe7c79a14e2de4c27bb1b121625381f413e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ArtifactResourceProvider.java c5c02cf274239fe3493b69f97e69cc63967375dd
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseProvider.java 135eefece20046037fc5440f4dc3bc946601b1e3
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 5a7cda0d8101abccefd0464b75777c78e8cbc9cb
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java 73d24908eabfe76908a60ebe4c0d3d08deb1f32a
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 54c83600b78d77ee26dffea947133cc7d07e098e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 98adcd112d768cca61c9eb0d59b00d85d8da0d9a
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java f05ffbe0167fe2a6d4970d3b628fea48a54217ec
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 2e86b2dcf45076315f54bbf298ab20a107fcf513
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CredentialResourceProvider.java 79254c6d8960867f737c64d2b48782e3a364d59d
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java f051651e12e1395e24c73af10fafea9ffdb38c1a
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 6708560969fc4728ca9f56d0d762db9b4438f83e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 5373ffe31cb367ab63a6940664cb5b7cfdafe7bb
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java b1062090e114554cfe4490ac5e92308018e79e09
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStatusHelper.java f94b979a49c7d9cdddb913b5c32a600f026f0f9a
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HttpPropertyProvider.java c556b06d5de91d806b6dafb542c7ca3f8aceb0ba
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/JsonHttpPropertyRequest.java 2e51e8c3795352ca4daf5ee53419be2efd54ea26
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LdapSyncEventResourceProvider.java 4badc9c472753cf90d665887323f9eda4facaef5
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/MemberResourceProvider.java d9d56eee8cee951d49c237731c0a1b2fe4b13806
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/QuickLinkArtifactResourceProvider.java 073ec60b27bdae211743d0cc39c39405472e09c6
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RecommendationResourceProvider.java 70ed3dc09f43eec511d98e8e6e883d27a848f703
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 81f283c55bec72f1aba74d3594b7677ec69dcf15
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RoleAuthorizationResourceProvider.java 78eb80e8d170e4448d55f119097553d3fa38e386
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java e55a380f3d54a186aa9810f1771c21017f06b88a
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java 7035f0a148083fd3cba4af51d4d54387a481bf0e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProvider.java 6bb421b67ba6aa6ef8541d0f96f27a8978e0ab81
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java 6a326b5338714c9db75a12f6450683f7925586fd
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java 0b4fcd9633237b65c376ee3113799135380f4af8
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ThemeArtifactResourceProvider.java fc7cfe7f91bdd1a23dd997137316d62b9a05562a
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java 36eb3bebf1aa9448dfbd86db37f30e5f149b8dd4
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java c5c36e9942713186bd38e1e96fbed46260586639
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ValidationResourceProvider.java b78c64af53eee617392289e7a9becd8df60a468f
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java f94ac32f1729e38d32a380ec9d46250944d8fd54
ambari-server/src/main/java/org/apache/ambari/server/controller/jdbc/JDBCResourceProvider.java ec5363b6ad242b51fa38b052c1d6451296b175ee
ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java 832d9aeff416bd2033ed468fbf1988b3e2071727
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsCollectorHAClusterState.java 9ff40b44009aa2584a16de4198fbd9477bb296d5
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsCollectorHAManager.java f107aab2ec6566c0bfd9e842d2e93d7d6fee8e24
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsDownsamplingMethod.java 5994f164e62f977ee5877a97a87cf3519a9a384d
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPropertyProvider.java 04f8c78a4fe39b1c2a98929486b0ed4b529d301b
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsReportPropertyProvider.java a11bcc92676c8541f756dc6aa7af61dc3e44ef7d
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProvider.java 7ab16daee4d50234e3be72028c0461f0f09049ef
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ThreadPoolEnabledPropertyProvider.java a2f7248ab7882e7a73322c15621df7ea2760d0dd
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaPropertyProvider.java ecfd4009ec5bbc660c65b79c4c13484994e69011
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaReportPropertyProvider.java f15615bd869446101131344d10cb520141ee417d
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java cae330b3466982923deb388ac5323c67fffea02d
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProvider.java 74df3a702ee4dfb55186bfa9e9d3a01e545e19d4
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java 95352bf5ce90bbeeb3e045afebce9c97a90b5b75
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/DefaultServiceCalculatedState.java 5e02a64810f9d9e07b3497760c3d0cd64183072a
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/FlumeServiceCalculatedState.java ca4fe6e0e0faddc9f7ea8886067e4c154d756654
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HBaseServiceCalculatedState.java eac0dce1e02c46803b056943fd1fe446762590b8
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HDFSServiceCalculatedState.java 7bbad2ad5af11eb24ca0ba15c1efdee97ad67440
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HiveServiceCalculatedState.java 77e44a5029bd04bf3042369583dccefcbeb15151
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/OozieServiceCalculatedState.java 1803f7041a3c5a71bdf7f8a690b9539466fed18d
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/YARNServiceCalculatedState.java 2f1619f27fd28b317e013d7f3e123997eac881c8
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/DefaultLdapConnectionConfigService.java 9afcf51a4968c4740cac10b10a9fc94d0405156b
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RemoteAmbariClusterEntity.java 4f10d6f4247ef99116896f27b62460cfb97243c6
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java b7ff297ce5eaa9042f4b6c5d8db57ffe509f6141
ambari-server/src/main/java/org/apache/ambari/server/security/encryption/CredentialProvider.java 1f2f6dbe8bf48d9f34fc3675766095cdf7efb765
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KDCKerberosOperationHandler.java e5696cd48e862eb1e26eab279c1d4645de71cc52
ambari-server/src/main/java/org/apache/ambari/server/state/services/MetricsRetrievalService.java 510e7067f7816cbd93623cba80eec6bcb328c11f
ambari-server/src/main/java/org/apache/ambari/server/state/stack/OsFamily.java c0483e839a47ff87964cf4fa35318b56c9d8d94a
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java 7bd377f183ca265026fbe138996607b02a8dc55f
ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedStateImpl.java 12af1310ecab35d18b4a0705229201e8d716ba1b
ambari-server/src/main/java/org/apache/ambari/server/utils/RetryHelper.java d732edf4c7a41fd0ef762a1c4f04ae9b97d064ba
ambari-server/src/main/java/org/apache/ambari/server/view/ViewDataMigrationUtility.java 55f85a7e8ef53324e0091a528117a7a01cf45013
ambari-server/src/main/java/org/apache/ambari/server/view/ViewExtractor.java ad1cc5227976f3702bc852d264f4f2e79f58242f
ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java c50276e8561182514dfc59e2a6901c6f476483ed
ambari-server/src/main/java/org/apache/ambari/server/view/ViewSubResourceProvider.java 5cceb1ece5cb9221ee93c6530e30b1bcc945e803
ambari-server/src/main/java/org/apache/ambari/server/view/persistence/DataStoreImpl.java 5d4c7581c4c8a7b22e527fac31bf7f54ec8212aa
Diff: https://reviews.apache.org/r/63754/diff/1/
Testing
-------
Tested some requests that previously referred to "abstract" or "base" classes, to verify that the actual logging class shows up in the message, eg.:
```
13 Nov 2017 14:19:14,137 ERROR [ambari-client-thread-37] CreateHandler:79 - Bad request received: Request body for Blueprint create request is empty
13 Nov 2017 14:19:14,133 ERROR [ambari-client-thread-37] BlueprintResourceProvider:194 - Exception while creating blueprint
```
Code compiles, unit tests pass:
```
$ mvn -am -pl ambari-server clean test
...
Tests run: 4955, Failures: 0, Errors: 0, Skipped: 36
...
```
Thanks,
Attila Doroszlai
Re: Review Request 63754: AMBARI-22426. Push down Logger instances
Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63754/#review190817
-----------------------------------------------------------
Ship it!
Ship It!
- Attila Magyar
On Nov. 13, 2017, 2:31 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63754/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2017, 2:31 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, and Jonathan Hurley.
>
>
> Bugs: AMBARI-22426
> https://issues.apache.org/jira/browse/AMBARI-22426
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Make (almost) all loggers private, push down to subclasses, keep in super class if also used there.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/handlers/BaseManagementHandler.java d0bd5d32f50820adfecfc2282f253e9ae03fbeb3
> ambari-server/src/main/java/org/apache/ambari/server/api/handlers/CreateHandler.java 549da76b3b0c1651507d612b037f3d70715cb7be
> ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java d24780b4ac191743d1e2c2cf4ea8c62c6f5844da
> ambari-server/src/main/java/org/apache/ambari/server/api/services/LoggingService.java c86b9a0e50958c693b3f52f1de3aa3df1783fdd4
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java 2dc45de22655d7c7a69a11335a50f6d130cef34a
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java 34888f2408b7abcb75825acc1f6b6d15ea9fe2fa
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java e134f6dc6ef9850bb4e8d2cc58b7bf7c860f4da0
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractPropertyProvider.java 322596ea5e96c1e17433ad339f39d16898384015
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 1501a0186a315cff2391e0aadbe8c3232bb4d9ee
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractResourceProvider.java 5598650ef1681557464eed5cfbb573f2ecc33c95
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java 4e618e7ff63679086b507103adee2bc7736a16c4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java 32f1fd8f4fcbddd47972add304648db9f44ba8a3
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java cf4e7475b3ab6ed1e5375af23dcbe28d0533c839
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java c71651e5ff0be669646950cc41b0aa56e73c47f0
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java 43ee7fe7c79a14e2de4c27bb1b121625381f413e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ArtifactResourceProvider.java c5c02cf274239fe3493b69f97e69cc63967375dd
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseProvider.java 135eefece20046037fc5440f4dc3bc946601b1e3
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 5a7cda0d8101abccefd0464b75777c78e8cbc9cb
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java 73d24908eabfe76908a60ebe4c0d3d08deb1f32a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 54c83600b78d77ee26dffea947133cc7d07e098e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 98adcd112d768cca61c9eb0d59b00d85d8da0d9a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java f05ffbe0167fe2a6d4970d3b628fea48a54217ec
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 2e86b2dcf45076315f54bbf298ab20a107fcf513
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CredentialResourceProvider.java 79254c6d8960867f737c64d2b48782e3a364d59d
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java f051651e12e1395e24c73af10fafea9ffdb38c1a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 6708560969fc4728ca9f56d0d762db9b4438f83e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 5373ffe31cb367ab63a6940664cb5b7cfdafe7bb
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java b1062090e114554cfe4490ac5e92308018e79e09
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStatusHelper.java f94b979a49c7d9cdddb913b5c32a600f026f0f9a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HttpPropertyProvider.java c556b06d5de91d806b6dafb542c7ca3f8aceb0ba
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/JsonHttpPropertyRequest.java 2e51e8c3795352ca4daf5ee53419be2efd54ea26
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LdapSyncEventResourceProvider.java 4badc9c472753cf90d665887323f9eda4facaef5
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/MemberResourceProvider.java d9d56eee8cee951d49c237731c0a1b2fe4b13806
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/QuickLinkArtifactResourceProvider.java 073ec60b27bdae211743d0cc39c39405472e09c6
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RecommendationResourceProvider.java 70ed3dc09f43eec511d98e8e6e883d27a848f703
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 81f283c55bec72f1aba74d3594b7677ec69dcf15
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RoleAuthorizationResourceProvider.java 78eb80e8d170e4448d55f119097553d3fa38e386
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java e55a380f3d54a186aa9810f1771c21017f06b88a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java 7035f0a148083fd3cba4af51d4d54387a481bf0e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProvider.java 6bb421b67ba6aa6ef8541d0f96f27a8978e0ab81
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java 6a326b5338714c9db75a12f6450683f7925586fd
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java 0b4fcd9633237b65c376ee3113799135380f4af8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ThemeArtifactResourceProvider.java fc7cfe7f91bdd1a23dd997137316d62b9a05562a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java 36eb3bebf1aa9448dfbd86db37f30e5f149b8dd4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java c5c36e9942713186bd38e1e96fbed46260586639
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ValidationResourceProvider.java b78c64af53eee617392289e7a9becd8df60a468f
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java f94ac32f1729e38d32a380ec9d46250944d8fd54
> ambari-server/src/main/java/org/apache/ambari/server/controller/jdbc/JDBCResourceProvider.java ec5363b6ad242b51fa38b052c1d6451296b175ee
> ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java 832d9aeff416bd2033ed468fbf1988b3e2071727
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsCollectorHAClusterState.java 9ff40b44009aa2584a16de4198fbd9477bb296d5
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsCollectorHAManager.java f107aab2ec6566c0bfd9e842d2e93d7d6fee8e24
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsDownsamplingMethod.java 5994f164e62f977ee5877a97a87cf3519a9a384d
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPropertyProvider.java 04f8c78a4fe39b1c2a98929486b0ed4b529d301b
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsReportPropertyProvider.java a11bcc92676c8541f756dc6aa7af61dc3e44ef7d
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProvider.java 7ab16daee4d50234e3be72028c0461f0f09049ef
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ThreadPoolEnabledPropertyProvider.java a2f7248ab7882e7a73322c15621df7ea2760d0dd
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaPropertyProvider.java ecfd4009ec5bbc660c65b79c4c13484994e69011
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaReportPropertyProvider.java f15615bd869446101131344d10cb520141ee417d
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java cae330b3466982923deb388ac5323c67fffea02d
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProvider.java 74df3a702ee4dfb55186bfa9e9d3a01e545e19d4
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java 95352bf5ce90bbeeb3e045afebce9c97a90b5b75
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/DefaultServiceCalculatedState.java 5e02a64810f9d9e07b3497760c3d0cd64183072a
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/FlumeServiceCalculatedState.java ca4fe6e0e0faddc9f7ea8886067e4c154d756654
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HBaseServiceCalculatedState.java eac0dce1e02c46803b056943fd1fe446762590b8
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HDFSServiceCalculatedState.java 7bbad2ad5af11eb24ca0ba15c1efdee97ad67440
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HiveServiceCalculatedState.java 77e44a5029bd04bf3042369583dccefcbeb15151
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/OozieServiceCalculatedState.java 1803f7041a3c5a71bdf7f8a690b9539466fed18d
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/YARNServiceCalculatedState.java 2f1619f27fd28b317e013d7f3e123997eac881c8
> ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/DefaultLdapConnectionConfigService.java 9afcf51a4968c4740cac10b10a9fc94d0405156b
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RemoteAmbariClusterEntity.java 4f10d6f4247ef99116896f27b62460cfb97243c6
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java b7ff297ce5eaa9042f4b6c5d8db57ffe509f6141
> ambari-server/src/main/java/org/apache/ambari/server/security/encryption/CredentialProvider.java 1f2f6dbe8bf48d9f34fc3675766095cdf7efb765
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KDCKerberosOperationHandler.java e5696cd48e862eb1e26eab279c1d4645de71cc52
> ambari-server/src/main/java/org/apache/ambari/server/state/services/MetricsRetrievalService.java 510e7067f7816cbd93623cba80eec6bcb328c11f
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/OsFamily.java c0483e839a47ff87964cf4fa35318b56c9d8d94a
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java 7bd377f183ca265026fbe138996607b02a8dc55f
> ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedStateImpl.java 12af1310ecab35d18b4a0705229201e8d716ba1b
> ambari-server/src/main/java/org/apache/ambari/server/utils/RetryHelper.java d732edf4c7a41fd0ef762a1c4f04ae9b97d064ba
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewDataMigrationUtility.java 55f85a7e8ef53324e0091a528117a7a01cf45013
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewExtractor.java ad1cc5227976f3702bc852d264f4f2e79f58242f
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java c50276e8561182514dfc59e2a6901c6f476483ed
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewSubResourceProvider.java 5cceb1ece5cb9221ee93c6530e30b1bcc945e803
> ambari-server/src/main/java/org/apache/ambari/server/view/persistence/DataStoreImpl.java 5d4c7581c4c8a7b22e527fac31bf7f54ec8212aa
>
>
> Diff: https://reviews.apache.org/r/63754/diff/1/
>
>
> Testing
> -------
>
> Tested some requests that previously referred to "abstract" or "base" classes, to verify that the actual logging class shows up in the message, eg.:
>
> ```
> 13 Nov 2017 14:19:14,137 ERROR [ambari-client-thread-37] CreateHandler:79 - Bad request received: Request body for Blueprint create request is empty
> 13 Nov 2017 14:19:14,133 ERROR [ambari-client-thread-37] BlueprintResourceProvider:194 - Exception while creating blueprint
> ```
>
> Code compiles, unit tests pass:
>
> ```
> $ mvn -am -pl ambari-server clean test
> ...
> Tests run: 4955, Failures: 0, Errors: 0, Skipped: 36
> ...
> ```
>
>
> Thanks,
>
> Attila Doroszlai
>
>
Re: Review Request 63754: AMBARI-22426. Push down Logger instances
Posted by Balázs Bence Sári <bs...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63754/#review190829
-----------------------------------------------------------
Ship it!
Ship It!
- Balázs Bence Sári
On Nov. 13, 2017, 2:31 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63754/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2017, 2:31 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, and Jonathan Hurley.
>
>
> Bugs: AMBARI-22426
> https://issues.apache.org/jira/browse/AMBARI-22426
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Make (almost) all loggers private, push down to subclasses, keep in super class if also used there.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/handlers/BaseManagementHandler.java d0bd5d32f50820adfecfc2282f253e9ae03fbeb3
> ambari-server/src/main/java/org/apache/ambari/server/api/handlers/CreateHandler.java 549da76b3b0c1651507d612b037f3d70715cb7be
> ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java d24780b4ac191743d1e2c2cf4ea8c62c6f5844da
> ambari-server/src/main/java/org/apache/ambari/server/api/services/LoggingService.java c86b9a0e50958c693b3f52f1de3aa3df1783fdd4
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java 2dc45de22655d7c7a69a11335a50f6d130cef34a
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java 34888f2408b7abcb75825acc1f6b6d15ea9fe2fa
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java e134f6dc6ef9850bb4e8d2cc58b7bf7c860f4da0
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractPropertyProvider.java 322596ea5e96c1e17433ad339f39d16898384015
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 1501a0186a315cff2391e0aadbe8c3232bb4d9ee
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractResourceProvider.java 5598650ef1681557464eed5cfbb573f2ecc33c95
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java 4e618e7ff63679086b507103adee2bc7736a16c4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java 32f1fd8f4fcbddd47972add304648db9f44ba8a3
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java cf4e7475b3ab6ed1e5375af23dcbe28d0533c839
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java c71651e5ff0be669646950cc41b0aa56e73c47f0
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java 43ee7fe7c79a14e2de4c27bb1b121625381f413e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ArtifactResourceProvider.java c5c02cf274239fe3493b69f97e69cc63967375dd
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseProvider.java 135eefece20046037fc5440f4dc3bc946601b1e3
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 5a7cda0d8101abccefd0464b75777c78e8cbc9cb
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java 73d24908eabfe76908a60ebe4c0d3d08deb1f32a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 54c83600b78d77ee26dffea947133cc7d07e098e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 98adcd112d768cca61c9eb0d59b00d85d8da0d9a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java f05ffbe0167fe2a6d4970d3b628fea48a54217ec
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 2e86b2dcf45076315f54bbf298ab20a107fcf513
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CredentialResourceProvider.java 79254c6d8960867f737c64d2b48782e3a364d59d
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java f051651e12e1395e24c73af10fafea9ffdb38c1a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 6708560969fc4728ca9f56d0d762db9b4438f83e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 5373ffe31cb367ab63a6940664cb5b7cfdafe7bb
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java b1062090e114554cfe4490ac5e92308018e79e09
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStatusHelper.java f94b979a49c7d9cdddb913b5c32a600f026f0f9a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HttpPropertyProvider.java c556b06d5de91d806b6dafb542c7ca3f8aceb0ba
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/JsonHttpPropertyRequest.java 2e51e8c3795352ca4daf5ee53419be2efd54ea26
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LdapSyncEventResourceProvider.java 4badc9c472753cf90d665887323f9eda4facaef5
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/MemberResourceProvider.java d9d56eee8cee951d49c237731c0a1b2fe4b13806
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/QuickLinkArtifactResourceProvider.java 073ec60b27bdae211743d0cc39c39405472e09c6
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RecommendationResourceProvider.java 70ed3dc09f43eec511d98e8e6e883d27a848f703
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 81f283c55bec72f1aba74d3594b7677ec69dcf15
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RoleAuthorizationResourceProvider.java 78eb80e8d170e4448d55f119097553d3fa38e386
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java e55a380f3d54a186aa9810f1771c21017f06b88a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java 7035f0a148083fd3cba4af51d4d54387a481bf0e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProvider.java 6bb421b67ba6aa6ef8541d0f96f27a8978e0ab81
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java 6a326b5338714c9db75a12f6450683f7925586fd
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java 0b4fcd9633237b65c376ee3113799135380f4af8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ThemeArtifactResourceProvider.java fc7cfe7f91bdd1a23dd997137316d62b9a05562a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java 36eb3bebf1aa9448dfbd86db37f30e5f149b8dd4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java c5c36e9942713186bd38e1e96fbed46260586639
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ValidationResourceProvider.java b78c64af53eee617392289e7a9becd8df60a468f
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java f94ac32f1729e38d32a380ec9d46250944d8fd54
> ambari-server/src/main/java/org/apache/ambari/server/controller/jdbc/JDBCResourceProvider.java ec5363b6ad242b51fa38b052c1d6451296b175ee
> ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java 832d9aeff416bd2033ed468fbf1988b3e2071727
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsCollectorHAClusterState.java 9ff40b44009aa2584a16de4198fbd9477bb296d5
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsCollectorHAManager.java f107aab2ec6566c0bfd9e842d2e93d7d6fee8e24
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsDownsamplingMethod.java 5994f164e62f977ee5877a97a87cf3519a9a384d
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPropertyProvider.java 04f8c78a4fe39b1c2a98929486b0ed4b529d301b
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsReportPropertyProvider.java a11bcc92676c8541f756dc6aa7af61dc3e44ef7d
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProvider.java 7ab16daee4d50234e3be72028c0461f0f09049ef
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ThreadPoolEnabledPropertyProvider.java a2f7248ab7882e7a73322c15621df7ea2760d0dd
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaPropertyProvider.java ecfd4009ec5bbc660c65b79c4c13484994e69011
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaReportPropertyProvider.java f15615bd869446101131344d10cb520141ee417d
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java cae330b3466982923deb388ac5323c67fffea02d
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProvider.java 74df3a702ee4dfb55186bfa9e9d3a01e545e19d4
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java 95352bf5ce90bbeeb3e045afebce9c97a90b5b75
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/DefaultServiceCalculatedState.java 5e02a64810f9d9e07b3497760c3d0cd64183072a
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/FlumeServiceCalculatedState.java ca4fe6e0e0faddc9f7ea8886067e4c154d756654
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HBaseServiceCalculatedState.java eac0dce1e02c46803b056943fd1fe446762590b8
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HDFSServiceCalculatedState.java 7bbad2ad5af11eb24ca0ba15c1efdee97ad67440
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HiveServiceCalculatedState.java 77e44a5029bd04bf3042369583dccefcbeb15151
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/OozieServiceCalculatedState.java 1803f7041a3c5a71bdf7f8a690b9539466fed18d
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/YARNServiceCalculatedState.java 2f1619f27fd28b317e013d7f3e123997eac881c8
> ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/DefaultLdapConnectionConfigService.java 9afcf51a4968c4740cac10b10a9fc94d0405156b
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RemoteAmbariClusterEntity.java 4f10d6f4247ef99116896f27b62460cfb97243c6
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java b7ff297ce5eaa9042f4b6c5d8db57ffe509f6141
> ambari-server/src/main/java/org/apache/ambari/server/security/encryption/CredentialProvider.java 1f2f6dbe8bf48d9f34fc3675766095cdf7efb765
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KDCKerberosOperationHandler.java e5696cd48e862eb1e26eab279c1d4645de71cc52
> ambari-server/src/main/java/org/apache/ambari/server/state/services/MetricsRetrievalService.java 510e7067f7816cbd93623cba80eec6bcb328c11f
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/OsFamily.java c0483e839a47ff87964cf4fa35318b56c9d8d94a
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java 7bd377f183ca265026fbe138996607b02a8dc55f
> ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedStateImpl.java 12af1310ecab35d18b4a0705229201e8d716ba1b
> ambari-server/src/main/java/org/apache/ambari/server/utils/RetryHelper.java d732edf4c7a41fd0ef762a1c4f04ae9b97d064ba
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewDataMigrationUtility.java 55f85a7e8ef53324e0091a528117a7a01cf45013
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewExtractor.java ad1cc5227976f3702bc852d264f4f2e79f58242f
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java c50276e8561182514dfc59e2a6901c6f476483ed
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewSubResourceProvider.java 5cceb1ece5cb9221ee93c6530e30b1bcc945e803
> ambari-server/src/main/java/org/apache/ambari/server/view/persistence/DataStoreImpl.java 5d4c7581c4c8a7b22e527fac31bf7f54ec8212aa
>
>
> Diff: https://reviews.apache.org/r/63754/diff/1/
>
>
> Testing
> -------
>
> Tested some requests that previously referred to "abstract" or "base" classes, to verify that the actual logging class shows up in the message, eg.:
>
> ```
> 13 Nov 2017 14:19:14,137 ERROR [ambari-client-thread-37] CreateHandler:79 - Bad request received: Request body for Blueprint create request is empty
> 13 Nov 2017 14:19:14,133 ERROR [ambari-client-thread-37] BlueprintResourceProvider:194 - Exception while creating blueprint
> ```
>
> Code compiles, unit tests pass:
>
> ```
> $ mvn -am -pl ambari-server clean test
> ...
> Tests run: 4955, Failures: 0, Errors: 0, Skipped: 36
> ...
> ```
>
>
> Thanks,
>
> Attila Doroszlai
>
>