You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Jakob Homan (JIRA)" <ji...@apache.org> on 2011/09/01 02:39:09 UTC
[jira] [Created] (GIRAPH-24) Job-level statistics reports one
superstep greater than workers
Job-level statistics reports one superstep greater than workers
---------------------------------------------------------------
Key: GIRAPH-24
URL: https://issues.apache.org/jira/browse/GIRAPH-24
Project: Giraph
Issue Type: Bug
Reporter: Jakob Homan
Assignee: Jakob Homan
Attachments: GIRAPH-24.patch
In {{BspServiceMaster::coordinateSuperstep()}} the {{superStepCounter}} is incremented when the coordination begins, but since the counter starts at zero, this has the job level statistic being at superstep {{n+1}} when the workers are reporting that they are working on {{n}}. This discrepancy persists throughout the job.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-24) Job-level statistics reports one
superstep greater than workers
Posted by "Hyunsik Choi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-24?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095033#comment-13095033 ]
Hyunsik Choi commented on GIRAPH-24:
------------------------------------
+1 nice work
On another side, we need to create jira components about each part of giraph.
> Job-level statistics reports one superstep greater than workers
> ---------------------------------------------------------------
>
> Key: GIRAPH-24
> URL: https://issues.apache.org/jira/browse/GIRAPH-24
> Project: Giraph
> Issue Type: Bug
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: GIRAPH-24.patch
>
>
> In {{BspServiceMaster::coordinateSuperstep()}} the {{superStepCounter}} is incremented when the coordination begins, but since the counter starts at zero, this has the job level statistic being at superstep {{n+1}} when the workers are reporting that they are working on {{n}}. This discrepancy persists throughout the job.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-24) Job-level statistics reports one
superstep greater than workers
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-24?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated GIRAPH-24:
------------------------------
Attachment: GIRAPH-24.patch
Patch that only increments the counter after the zeroth superstep to the keep the count consistent between the job and the workers. No unit test as this is very difficult to access in its current form. Manually tested as part of a job.
> Job-level statistics reports one superstep greater than workers
> ---------------------------------------------------------------
>
> Key: GIRAPH-24
> URL: https://issues.apache.org/jira/browse/GIRAPH-24
> Project: Giraph
> Issue Type: Bug
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: GIRAPH-24.patch
>
>
> In {{BspServiceMaster::coordinateSuperstep()}} the {{superStepCounter}} is incremented when the coordination begins, but since the counter starts at zero, this has the job level statistic being at superstep {{n+1}} when the workers are reporting that they are working on {{n}}. This discrepancy persists throughout the job.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-24) Job-level statistics reports one
superstep greater than workers
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-24?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095042#comment-13095042 ]
Avery Ching commented on GIRAPH-24:
-----------------------------------
I thought I noticed this at some point, but forgot about it. Looks good. +1
> Job-level statistics reports one superstep greater than workers
> ---------------------------------------------------------------
>
> Key: GIRAPH-24
> URL: https://issues.apache.org/jira/browse/GIRAPH-24
> Project: Giraph
> Issue Type: Bug
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: GIRAPH-24.patch
>
>
> In {{BspServiceMaster::coordinateSuperstep()}} the {{superStepCounter}} is incremented when the coordination begins, but since the counter starts at zero, this has the job level statistic being at superstep {{n+1}} when the workers are reporting that they are working on {{n}}. This discrepancy persists throughout the job.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (GIRAPH-24) Job-level statistics reports one
superstep greater than workers
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-24?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan resolved GIRAPH-24.
-------------------------------
Resolution: Fixed
I've verified unit tests pass and committed this. Resolving.
> Job-level statistics reports one superstep greater than workers
> ---------------------------------------------------------------
>
> Key: GIRAPH-24
> URL: https://issues.apache.org/jira/browse/GIRAPH-24
> Project: Giraph
> Issue Type: Bug
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: GIRAPH-24.patch
>
>
> In {{BspServiceMaster::coordinateSuperstep()}} the {{superStepCounter}} is incremented when the coordination begins, but since the counter starts at zero, this has the job level statistic being at superstep {{n+1}} when the workers are reporting that they are working on {{n}}. This discrepancy persists throughout the job.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira