You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2017/05/09 19:10:58 UTC
[kudu-CR] [java-client] update protoc maven plugin
Grant Henke has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6830
Change subject: [java-client] update protoc maven plugin
......................................................................
[java-client] update protoc maven plugin
The current protoc maven plugin is not hosted on maven central
and the hosting domain is unavailable. It also has not been
updated since 2012.
It appears like the most current and maintained fork is
here: https://github.com/xolstice/protobuf-maven-plugin
Change-Id: I43167c298e5230cd6421fd992f712513f8801b5a
---
M java/kudu-client/pom.xml
M java/pom.xml
2 files changed, 12 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/6830/1
--
To view, visit http://gerrit.cloudera.org:8080/6830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I43167c298e5230cd6421fd992f712513f8801b5a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
[kudu-CR] [java-client] update protoc maven plugin
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: [java-client] update protoc maven plugin
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43167c298e5230cd6421fd992f712513f8801b5a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] [java-client] update protoc maven plugin
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [java-client] update protoc maven plugin
......................................................................
Patch Set 2:
It appears I'm late to the party, but I have two requests:
1. Looks like this newer version of protobuf-maven-plugin defines a property (https://www.xolstice.org/protobuf-maven-plugin/compile-mojo.html#attachProtoSources) that can obviate the need for delete-test-protos (see java-client/pom.xml); can you look into this?
2. More importantly, beginning with 2.6.1 protoc is available as a maven artifact itself (https://www.xolstice.org/protobuf-maven-plugin/faq.html#faq_1). If we consumed it as such, it has the potential to drastically simplify our Java build:
- We could remove all of the maven profiles associated with finding the right version of protoc.
- We could rev protobuf in thirdparty (for the server and C++ client) independently of the protobuf/protoc maven artifacts (for the Java client).
Could you investigate this?
--
To view, visit http://gerrit.cloudera.org:8080/6830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43167c298e5230cd6421fd992f712513f8801b5a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] [java-client] update protoc maven plugin
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [java-client] update protoc maven plugin
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43167c298e5230cd6421fd992f712513f8801b5a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] [java-client] update protoc maven plugin
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [java-client] update protoc maven plugin
......................................................................
Patch Set 2:
> I will look into that Adar. This helps fix the broken build in the
> mean time.
Thanks.
I took a quick look at the protoc binaries published in maven central (e.g. https://repo1.maven.org/maven2/com/google/protobuf/protoc/3.3.0/). The 3.3.0 protoc does work on CentOS 6.6, but the 2.6.1 protoc doesn't (it depends on glibc 2.14 but CentOS 6.6 only provides 2.12).
--
To view, visit http://gerrit.cloudera.org:8080/6830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43167c298e5230cd6421fd992f712513f8801b5a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] [java-client] update protoc maven plugin
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged.
Change subject: [java-client] update protoc maven plugin
......................................................................
[java-client] update protoc maven plugin
The current protoc maven plugin is not hosted on maven central
and the hosting domain is unavailable. It also has not been
updated since 2012.
It appears like the most current and maintained fork is
here: https://github.com/xolstice/protobuf-maven-plugin
Change-Id: I43167c298e5230cd6421fd992f712513f8801b5a
Reviewed-on: http://gerrit.cloudera.org:8080/6830
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
Reviewed-by: David Ribeiro Alves <da...@gmail.com>
---
M java/kudu-client/pom.xml
M java/pom.xml
2 files changed, 12 insertions(+), 18 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
David Ribeiro Alves: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I43167c298e5230cd6421fd992f712513f8801b5a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java-client] update protoc maven plugin
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change.
Change subject: [java-client] update protoc maven plugin
......................................................................
Patch Set 2:
I will look into that Adar. This helps fix the broken build in the mean time.
--
To view, visit http://gerrit.cloudera.org:8080/6830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43167c298e5230cd6421fd992f712513f8801b5a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No