You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/15 05:08:10 UTC

[GitHub] [pulsar] codelipenghui commented on pull request #14574: add instance filed into metrics output to make the metrics line continuous

codelipenghui commented on pull request #14574:
URL: https://github.com/apache/pulsar/pull/14574#issuecomment-1067569137


   > When pulsar generate metrics output, for each metrics line, we frequently call System.currentTimeMills(), this function should not call frequently, this has performance issue, the document explain the reason, [why System.currentTimeMills() is slow](http://pzemtsov.github.io/2017/07/23/the-slow-currenttimemillis.html), we should try our best to use the same current time for each metrics collector.
   
   @zplinuxlover Could you please open a separate PR for the performance improvements? The new features always present in the major release, but the performance improvements can be cherry-picked to release branches.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org