You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by rsafonseca <gi...@git.apache.org> on 2015/06/01 15:08:51 UTC
[GitHub] cloudstack pull request: Version evaluated with native tools inste...
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/341
Version evaluated with native tools instead of maven
I think i saw a build failure yesterday on buildacloud.com due to missing plexus libs invoking the mvn command.
Can't seem to pinpoint it now, but this fixes it if it reoccurs, and also makes this specific task much faster.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rsafonseca/cloudstack debfixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/341.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #341
----
commit 55ff2bdf213b8bd38064135c40bf36241a82fa7f
Author: Rafael da Fonseca <rs...@gmail.com>
Date: 2015-06-01T13:01:37Z
Version evaluated with native tools instead of maven
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Version evaluated with native tools inste...
Posted by rsafonseca <gi...@git.apache.org>.
Github user rsafonseca closed the pull request at:
https://github.com/apache/cloudstack/pull/341
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Version evaluated with native tools inste...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/341#discussion_r31430386
--- Diff: debian/rules ---
@@ -1,6 +1,6 @@
#!/usr/bin/make -f
# -*- makefile -*-
-VERSION := $(shell mvn org.apache.maven.plugins:maven-help-plugin:2.1.1:evaluate -Dexpression=project.version | grep -v "\[")
+VERSION := $(shell awk 'f{print;f=0} /<artifactId>cloudstack/{f=1}' pom.xml| sed -e 's/<[^>]*>//g' -e 's/^[ \t]*//')
--- End diff --
Looks like this will be faster, though the previous version is more understandable so I would prefer to keep the previous one. We don't build packages often and it's usually Jenkins doing the heavy lifting.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Version evaluated with native tools inste...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/341#discussion_r31676186
--- Diff: debian/rules ---
@@ -1,6 +1,6 @@
#!/usr/bin/make -f
# -*- makefile -*-
-VERSION := $(shell mvn org.apache.maven.plugins:maven-help-plugin:2.1.1:evaluate -Dexpression=project.version | grep -v "\[")
+VERSION := $(shell awk 'f{print;f=0} /<artifactId>cloudstack/{f=1}' pom.xml| sed -e 's/<[^>]*>//g' -e 's/^[ \t]*//')
--- End diff --
@rsafonseca I appreciate the optimisation, but given that we're not building deb packages (at least locally often, we've jenkins for that) and with respect to readability of the code I would prefer to keep the mvn based version fetching logic that you had done earlier -- to me that makes more sense and is readable.
I think you may close this one, though I'm willing to merge it if you strongly need this, for example building deb packages locally often.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Version evaluated with native tools inste...
Posted by rsafonseca <gi...@git.apache.org>.
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/341#discussion_r31657434
--- Diff: debian/rules ---
@@ -1,6 +1,6 @@
#!/usr/bin/make -f
# -*- makefile -*-
-VERSION := $(shell mvn org.apache.maven.plugins:maven-help-plugin:2.1.1:evaluate -Dexpression=project.version | grep -v "\[")
+VERSION := $(shell awk 'f{print;f=0} /<artifactId>cloudstack/{f=1}' pom.xml| sed -e 's/<[^>]*>//g' -e 's/^[ \t]*//')
--- End diff --
Hi @bhaisaab
So you think it's not worth the speed improvement? Should i just close this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Version evaluated with native tools inste...
Posted by rsafonseca <gi...@git.apache.org>.
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/341#discussion_r31677186
--- Diff: debian/rules ---
@@ -1,6 +1,6 @@
#!/usr/bin/make -f
# -*- makefile -*-
-VERSION := $(shell mvn org.apache.maven.plugins:maven-help-plugin:2.1.1:evaluate -Dexpression=project.version | grep -v "\[")
+VERSION := $(shell awk 'f{print;f=0} /<artifactId>cloudstack/{f=1}' pom.xml| sed -e 's/<[^>]*>//g' -e 's/^[ \t]*//')
--- End diff --
Well.. i'm actually building packages often because i'm working on it :) but since it's just a few seconds more, it's not a big deal.. i was more worried about that failure that i can't seem to find again... so, closing until i can pinpoint an actual issue with this in the jenkins build env :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---