[GitHub] [incubator-streampark] 1996fanrui commented on pull request #2268: [Feature][Issue-2192] Support trigger savepoint manually.

["1996fanrui (via GitHub)" <gi...@apache.org>]

1996fanrui commented on PR #2268:
URL: https://github.com/apache/incubator-streampark/pull/2268#issuecomment-1416647298

   > @1996fanrui Thx so much for the comments. I'll update it after the comments discussed.
   
   Hi @RocMarshal , thanks for your quick feedback.
   
   From your feedback, I found two main problems:
   
   - You added a lot of code that is not currently needed in this PR, such as: status, end_time, execution_mode, cluster_id, etc. And we can add them if they're needed in the future. 
   - Modify the logic of `CheckpointProcessor` as little as possible. The code of the master branch determines whether checkpoint/savepoint needs to be stored in the database according to the cache, and I think it is enough for now. Your code will access to the database frequently, it isn't friendly to database.
   
   Overall, this PR should only contain logic to trigger savepoint and fetch savepoint list.
   
   Also, I want to check with you: the `completed` of the `Latest` just includes checkpoint, and it doesn't include savepoint, right?
   
   <img width="959" alt="image" src="https://user-images.githubusercontent.com/38427477/216745556-97ce34d3-38ac-42b8-81ea-2ce22ec4c966.png">


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org