You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by Fei Deng <du...@apache.org> on 2022/02/22 22:01:57 UTC
[API] proposal to change the return type of TSSslTicketKeyUpdate
Hey guys,
The api TSSslTicketKeyUpdate currently returns void, but in some recent
plugin debugging, I find it necessary to check whether the key update was
actually successful or not. Upon reading the related functions I think it's
possible to return a bool value as an indication for a successful/failed
key update.
So I'm proposing that we change the return value type of
TSSslTicketKeyUpdate from void to bool.
Regards,
Fei Deng
Re: [API] proposal to change the return type of TSSslTicketKeyUpdate
Posted by Fei Deng <du...@apache.org>.
Ahh yes, good point. TSReturnCode would be the better choice.
On Tue, Feb 22, 2022 at 4:09 PM Robert O Butts <ro...@apache.org> wrote:
> +1
>
> Seems useful, and it shouldn't break backwards compatibility.
>
> But should it be a TSReturnCode of TS_ERROR or TS_SUCCESS, to match the
> rest of the API?
>
>
> On Tue, Feb 22, 2022 at 3:02 PM Fei Deng <du...@apache.org> wrote:
>
> > Hey guys,
> >
> > The api TSSslTicketKeyUpdate currently returns void, but in some recent
> > plugin debugging, I find it necessary to check whether the key update was
> > actually successful or not. Upon reading the related functions I think
> it's
> > possible to return a bool value as an indication for a successful/failed
> > key update.
> >
> > So I'm proposing that we change the return value type of
> > TSSslTicketKeyUpdate from void to bool.
> >
> > Regards,
> > Fei Deng
> >
>
Re: [API] proposal to change the return type of TSSslTicketKeyUpdate
Posted by Robert O Butts <ro...@apache.org>.
+1
Seems useful, and it shouldn't break backwards compatibility.
But should it be a TSReturnCode of TS_ERROR or TS_SUCCESS, to match the
rest of the API?
On Tue, Feb 22, 2022 at 3:02 PM Fei Deng <du...@apache.org> wrote:
> Hey guys,
>
> The api TSSslTicketKeyUpdate currently returns void, but in some recent
> plugin debugging, I find it necessary to check whether the key update was
> actually successful or not. Upon reading the related functions I think it's
> possible to return a bool value as an indication for a successful/failed
> key update.
>
> So I'm proposing that we change the return value type of
> TSSslTicketKeyUpdate from void to bool.
>
> Regards,
> Fei Deng
>