[GitHub] [carbondata] nihal0107 commented on a change in pull request #3980: [CARBONDATA-3901] [CARBONDATA-3903] [CARBONDATA-3824] SI creation on unkbown table and doc changes.

[GitBox <gi...@apache.org>]

nihal0107 commented on a change in pull request #3980:
URL: https://github.com/apache/carbondata/pull/3980#discussion_r507589219



##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/strategy/DDLStrategy.scala
##########
@@ -204,6 +204,10 @@ class DDLStrategy(sparkSession: SparkSession) extends SparkStrategy {
           ExecutedCommandExec(CarbonCreateSecondaryIndexCommand(
             indexModel, tableProperties, ifNotExists, isDeferredRefresh, isCreateSIndex)) :: Nil
         } else {
+          if (!sparkSession.sessionState.catalog.

Review comment:
       done

##########
File path: docs/spatial-index-guide.md
##########
@@ -62,13 +62,16 @@ create table source_index(id BIGINT, latitude long, longitude long) stored by 'c
 'SPATIAL_INDEX.mygeohash.maxLatitude'='20.225281',
 'SPATIAL_INDEX.mygeohash.conversionRatio'='1000000');
 ```
-Note: `mygeohash` in the above example represent the index name.
+Note: 
+   * `mygeohash` in the above example represent the index name.
+   * Columns present in spatial_index table properties cannot be altered
+    i.e., sourcecolumns: `longitude, latitude` and index column: `mygeohash` in the above example.
 
 #### List of spatial index table properties
 
 |Name|Description|
 |-----------------------------------|-----------------------------------------------------------------------------------------|
-| SPATIAL_INDEX | Used to configure Spatial Index name. This name is appended to `SPATIAL_INDEX` in the subsequent sub-property configurations. `xxx` in the below sub-properties refer to index name.|
+| SPATIAL_INDEX | Used to configure Spatial Index name. This name is appended to `SPATIAL_INDEX` in the subsequent sub-property configurations. `xxx` in the below sub-properties refer to index name. Newly created column name is same as that of spatial index name. This column is not allowed in any properties except in SORT_COLUMNS table property.|

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org