You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by Davide Giannella <da...@apache.org> on 2016/06/06 15:04:31 UTC
[VOTE] Release Apache Jackrabbit Oak 1.5.3
A candidate for the Jackrabbit Oak 1.5.3 release is available at:
https://dist.apache.org/repos/dist/dev/jackrabbit/oak/1.5.3/
The release candidate is a zip archive of the sources in:
https://svn.apache.org/repos/asf/jackrabbit/oak/tags/jackrabbit-oak-1.5.3/
The SHA1 checksum of the archive is
366809a6ea4237a13579032b89c83837603b44ae.
A staged Maven repository is available for review at:
https://repository.apache.org/
The command for running automated checks against this release candidate is:
$ sh check-release.sh oak 1.5.3 366809a6ea4237a13579032b89c83837603b44ae
Please vote on releasing this package as Apache Jackrabbit Oak 1.5.3.
The vote is open for the next 72 hours and passes if a majority of at
least three +1 Jackrabbit PMC votes are cast.
[ ] +1 Release this package as Apache Jackrabbit Oak 1.5.3
[ ] -1 Do not release this package because...
Davide
Re: [VOTE] Release Apache Jackrabbit Oak 1.5.3
Posted by Davide Giannella <da...@apache.org>.
On 06/06/2016 17:02, Julian Reschke wrote:
> On 2016-06-06 17:04, Davide Giannella wrote:
>> A candidate for the Jackrabbit Oak 1.5.3 release is available at:
>>
>> https://dist.apache.org/repos/dist/dev/jackrabbit/oak/1.5.3/
>>
>> The release candidate is a zip archive of the sources in:
>> ...
>
>
> I'm getting test failures in oak-auth-external:
> ...
> I know that Angela has been looking at them, but it seems they are
> platform-specific (Windows...).
As this looks like to be platform specific, and this is to be considered
an "unstable" cut, I'm still for +1 on it.
Davide
Re: [VOTE] Release Apache Jackrabbit Oak 1.5.3
Posted by Angela Schreiber <an...@adobe.com>.
hi julian
the problem was only with the tests and i didn't make any
changes in the actual code. so, my preference would be a)
angela
>So I believe Angela has managed to fix the issue (I can't repro it
>anymore in trunk).
>
>What does this mean for 1.5.3?
>
>a) Release anyway?
>
>b) Cancel release & release instead what we have now?
>
>c) Release anyway, but follow up with 1.5.4 shortly after?
>
>I have no preference here, as I have no insight how serious the actual
>problem was...
>
>Best regards, Julian
Re: [VOTE] Release Apache Jackrabbit Oak 1.5.3
Posted by Julian Reschke <ju...@gmx.de>.
On 2016-06-10 12:17, Davide Giannella wrote:
> On 10/06/2016 09:43, Julian Reschke wrote:
>>
>> c) Release anyway, but follow up with 1.5.4 shortly after?
>
> I'm for proceeding anyway and release 1.5.4 according to aimed schedule:
> 20th June. It's still an unstable cut and some unstability is expected.
>
> Anyway we have only 2 +1s and we need at least one more to make the
> release public.
>
> Can anyone cast his vote?
>
> To be clear we go for the majority of votes. So currently we have 2 +1s.
> Even if one -1 comes in the release will go through. So if you think it
> doesn't have to go we need at least 3 -1s.
>
> Cheers
> Davide
I'm then OK (+1) with the release; June 20 isn't that far away.
Best regards, Julian
Re: [VOTE] Release Apache Jackrabbit Oak 1.5.3
Posted by Davide Giannella <da...@apache.org>.
On 10/06/2016 09:43, Julian Reschke wrote:
>
> c) Release anyway, but follow up with 1.5.4 shortly after?
I'm for proceeding anyway and release 1.5.4 according to aimed schedule:
20th June. It's still an unstable cut and some unstability is expected.
Anyway we have only 2 +1s and we need at least one more to make the
release public.
Can anyone cast his vote?
To be clear we go for the majority of votes. So currently we have 2 +1s.
Even if one -1 comes in the release will go through. So if you think it
doesn't have to go we need at least 3 -1s.
Cheers
Davide
Re: [VOTE] Release Apache Jackrabbit Oak 1.5.3
Posted by Julian Reschke <ju...@gmx.de>.
On 2016-06-08 12:56, Angela Schreiber wrote:
> hi davide
>
>> Angela, could you set up a VM with windows.
>
> already working on it... but it doesn't fail reliably
> and it never fails, when i try to debug it.
>
> angela
So I believe Angela has managed to fix the issue (I can't repro it
anymore in trunk).
What does this mean for 1.5.3?
a) Release anyway?
b) Cancel release & release instead what we have now?
c) Release anyway, but follow up with 1.5.4 shortly after?
I have no preference here, as I have no insight how serious the actual
problem was...
Best regards, Julian
Re: [VOTE] Release Apache Jackrabbit Oak 1.5.3
Posted by Angela Schreiber <an...@adobe.com>.
hi davide
>Angela, could you set up a VM with windows.
already working on it... but it doesn't fail reliably
and it never fails, when i try to debug it.
angela
Re: [VOTE] Release Apache Jackrabbit Oak 1.5.3
Posted by Julian Reschke <ju...@greenbytes.de>.
On 2016-06-08 12:50, Davide Giannella wrote:
> On 06/06/2016 17:09, Angela Schreiber wrote:
>> hi julian
>>
>> that looks pretty similar to OAK-4382
>> <https://issues.apache.org/jira/browse/OAK-4382>
>> they have in common that they sync (or should sync) group-membership with
>> infinite nesting (in the test-setup the nesting in anyway just 2).
>>
>> but i can't reproduce neither issue on my machine; however, all those
>> tests failing on your machine lack the 'deep' groups i.e. those groups
>> the synced users is not declared but only inherited member of.
>>
>> not sure how to sort that out if i can't reproduce it.
>>
> Angela, could you set up a VM with windows. Julian said it could be
> platform specific.
>
> Julian what's your box configuration? OS, Maven, JVM, ...
>
> Cheers
> Davide
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T17:41:47+01:00)
Maven home: C:\usr\local\apache-maven-3.3.9
Java version: 1.7.0_80, vendor: Oracle Corporation
Java home: C:\usr\local\jdk17\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 8.1", version: "6.3", arch: "amd64", family: "windows"
(this ins Windows 10)
Re: [VOTE] Release Apache Jackrabbit Oak 1.5.3
Posted by Davide Giannella <da...@apache.org>.
On 06/06/2016 17:09, Angela Schreiber wrote:
> hi julian
>
> that looks pretty similar to OAK-4382
> <https://issues.apache.org/jira/browse/OAK-4382>
> they have in common that they sync (or should sync) group-membership with
> infinite nesting (in the test-setup the nesting in anyway just 2).
>
> but i can't reproduce neither issue on my machine; however, all those
> tests failing on your machine lack the 'deep' groups i.e. those groups
> the synced users is not declared but only inherited member of.
>
> not sure how to sort that out if i can't reproduce it.
>
Angela, could you set up a VM with windows. Julian said it could be
platform specific.
Julian what's your box configuration? OS, Maven, JVM, ...
Cheers
Davide
Re: [VOTE] Release Apache Jackrabbit Oak 1.5.3
Posted by Angela Schreiber <an...@adobe.com>.
hi julian
that looks pretty similar to OAK-4382
<https://issues.apache.org/jira/browse/OAK-4382>
they have in common that they sync (or should sync) group-membership with
infinite nesting (in the test-setup the nesting in anyway just 2).
but i can't reproduce neither issue on my machine; however, all those
tests failing on your machine lack the 'deep' groups i.e. those groups
the synced users is not declared but only inherited member of.
not sure how to sort that out if i can't reproduce it.
kind regards
angela
On 06/06/16 18:02, "Julian Reschke" <ju...@gmx.de> wrote:
>On 2016-06-06 17:04, Davide Giannella wrote:
>> A candidate for the Jackrabbit Oak 1.5.3 release is available at:
>>
>> https://dist.apache.org/repos/dist/dev/jackrabbit/oak/1.5.3/
>>
>> The release candidate is a zip archive of the sources in:
>> ...
>
>
>I'm getting test failures in oak-auth-external:
>
>>
>>testGetGroupMembershipExternalUserInfiniteDepth(org.apache.jackrabbit.oak
>>.spi.security.authentication.external.impl.principal.PrincipalProviderAut
>>oMembershipTest) Time elapsed: 0.051 sec <<< FAILURE!
>> java.lang.AssertionError:
>>expected:<[org.apache.jackrabbit.oak.security.user.GroupImpl$GroupPrincip
>>al:ptestGroup52594cfe-26c9-4db9-838b-a607ff4c3e8c,
>>org.apache.jackrabbit.oak.spi.security.principal.PrincipalImpl:aaa,
>>org.apache.jackrabbit.oak.spi.security.principal.PrincipalImpl:b,
>>org.apache.jackrabbit.oak.spi.security.principal.PrincipalImpl:c,
>>org.apache.jackrabbit.oak.spi.security.principal.PrincipalImpl:a,
>>org.apache.jackrabbit.oak.spi.security.principal.PrincipalImpl:aa]> but
>>was:<[org.apache.jackrabbit.oak.security.user.GroupImpl$GroupPrincipal:pt
>>estGroup52594cfe-26c9-4db9-838b-a607ff4c3e8c,
>>org.apache.jackrabbit.oak.spi.security.authentication.external.impl.princ
>>ipal.ExternalGroupPrincipalProvider$ExternalGroupPrincipal:b,
>>org.apache.jackrabbit.oak.spi.security.authentication.external.impl.princ
>>ipal.ExternalGroupPrincipalProvider$ExternalGroupPrincipal:c,
>>org.apache.jackrabbit.oak.spi.security.authentication.external.impl.princ
>>ipal.ExternalGroupPrincipalProvider$ExternalGroupPrincipal:a]>
>> at org.junit.Assert.fail(Assert.java:88)
>> at org.junit.Assert.failNotEquals(Assert.java:834)
>> at org.junit.Assert.assertEquals(Assert.java:118)
>> at org.junit.Assert.assertEquals(Assert.java:144)
>> at
>>org.apache.jackrabbit.oak.spi.security.authentication.external.impl.princ
>>ipal.ExternalGroupPrincipalProviderTest.testGetGroupMembershipExternalUse
>>rInfiniteDepth(ExternalGroupPrincipalProviderTest.java:282)
>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> at
>>sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java
>>:57)
>> at
>>sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorI
>>mpl.java:43)
>> at java.lang.reflect.Method.invoke(Method.java:606)
>> at
>>org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMeth
>>od.java:50)
>> at
>>org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallabl
>>e.java:12)
>> at
>>org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod
>>.java:47)
>> at
>>org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.
>>java:17)
>> at
>>org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java
>>:26)
>> at
>>org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:2
>>7)
>> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>> at
>>org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.
>>java:78)
>> at
>>org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.
>>java:57)
>> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>> at
>>org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>
>I know that Angela has been looking at them, but it seems they are
>platform-specific (Windows...).
>
>Best regards, Julian
>
Re: [VOTE] Release Apache Jackrabbit Oak 1.5.3
Posted by Julian Reschke <ju...@gmx.de>.
On 2016-06-06 17:04, Davide Giannella wrote:
> A candidate for the Jackrabbit Oak 1.5.3 release is available at:
>
> https://dist.apache.org/repos/dist/dev/jackrabbit/oak/1.5.3/
>
> The release candidate is a zip archive of the sources in:
> ...
I'm getting test failures in oak-auth-external:
> testGetGroupMembershipExternalUserInfiniteDepth(org.apache.jackrabbit.oak.spi.security.authentication.external.impl.principal.PrincipalProviderAutoMembershipTest) Time elapsed: 0.051 sec <<< FAILURE!
> java.lang.AssertionError: expected:<[org.apache.jackrabbit.oak.security.user.GroupImpl$GroupPrincipal:ptestGroup52594cfe-26c9-4db9-838b-a607ff4c3e8c, org.apache.jackrabbit.oak.spi.security.principal.PrincipalImpl:aaa, org.apache.jackrabbit.oak.spi.security.principal.PrincipalImpl:b, org.apache.jackrabbit.oak.spi.security.principal.PrincipalImpl:c, org.apache.jackrabbit.oak.spi.security.principal.PrincipalImpl:a, org.apache.jackrabbit.oak.spi.security.principal.PrincipalImpl:aa]> but was:<[org.apache.jackrabbit.oak.security.user.GroupImpl$GroupPrincipal:ptestGroup52594cfe-26c9-4db9-838b-a607ff4c3e8c, org.apache.jackrabbit.oak.spi.security.authentication.external.impl.principal.ExternalGroupPrincipalProvider$ExternalGroupPrincipal:b, org.apache.jackrabbit.oak.spi.security.authentication.external.impl.principal.ExternalGroupPrincipalProvider$ExternalGroupPrincipal:c, org.apache.jackrabbit.oak.spi.security.authentication.external.impl.principal.ExternalGroupPrincipalProvider$ExternalGroupPrincipal:a]>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at org.apache.jackrabbit.oak.spi.security.authentication.external.impl.principal.ExternalGroupPrincipalProviderTest.testGetGroupMembershipExternalUserInfiniteDepth(ExternalGroupPrincipalProviderTest.java:282)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
I know that Angela has been looking at them, but it seems they are
platform-specific (Windows...).
Best regards, Julian
Re: [VOTE] Release Apache Jackrabbit Oak 1.5.3
Posted by Francesco Mari <ma...@gmail.com>.
+1
2016-06-06 17:04 GMT+02:00 Davide Giannella <da...@apache.org>:
> A candidate for the Jackrabbit Oak 1.5.3 release is available at:
>
> https://dist.apache.org/repos/dist/dev/jackrabbit/oak/1.5.3/
>
> The release candidate is a zip archive of the sources in:
>
>
> https://svn.apache.org/repos/asf/jackrabbit/oak/tags/jackrabbit-oak-1.5.3/
>
> The SHA1 checksum of the archive is
> 366809a6ea4237a13579032b89c83837603b44ae.
>
> A staged Maven repository is available for review at:
>
> https://repository.apache.org/
>
> The command for running automated checks against this release candidate is:
>
> $ sh check-release.sh oak 1.5.3
> 366809a6ea4237a13579032b89c83837603b44ae
>
> Please vote on releasing this package as Apache Jackrabbit Oak 1.5.3.
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 Jackrabbit PMC votes are cast.
>
> [ ] +1 Release this package as Apache Jackrabbit Oak 1.5.3
> [ ] -1 Do not release this package because...
>
> Davide
>
Re: [VOTE] Release Apache Jackrabbit Oak 1.5.3
Posted by Davide Giannella <da...@apache.org>.
[X] +1 Release this package as Apache Jackrabbit Oak 1.5.3
Davide