You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/26 19:52:07 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #27715:
[SPARK-30963][INFRA] Add GitHub Action job for document generation
dongjoon-hyun opened a new pull request #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715
### What changes were proposed in this pull request?
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27715:
[SPARK-30963][INFRA] Add GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#issuecomment-591673693
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23740/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27715:
[SPARK-30963][INFRA] Add GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#discussion_r384869064
##########
File path: .github/workflows/master.yml
##########
@@ -117,3 +117,40 @@ jobs:
run: ./R/install-dev.sh
- name: lint-r
run: ./dev/lint-r
+
+ docs:
+ runs-on: ubuntu-latest
+ name: Generate documents
+ steps:
+ - uses: actions/checkout@master
+ - uses: actions/cache@v1
+ with:
+ path: ~/.m2/repository
+ key: docs-maven-repo-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ docs-maven-repo-
+ - uses: actions/setup-java@v1
+ with:
+ java-version: '1.8'
+ - uses: actions/setup-python@v1
+ with:
+ python-version: '3.x'
+ architecture: 'x64'
+ - uses: actions/setup-ruby@v1
+ with:
+ ruby-version: '2.7'
+ - name: Install R
+ run: |
+ echo 'deb https://cloud.r-project.org/bin/linux/ubuntu bionic-cran35/' | sudo tee -a /etc/apt/sources.list
+ curl -sL "https://keyserver.ubuntu.com/pks/lookup?op=get&search=0xE298A3A825C0D65DFD57CBB651716619E084DAB9" | sudo apt-key add
+ sudo apt-get update
+ sudo apt-get install -y r-base r-base-dev libcurl4-openssl-dev pandoc
+ - name: Install packages
+ run: |
+ pip install sphinx mkdocs numpy
+ gem install jekyll jekyll-redirect-from rouge
+ sudo Rscript -e "install.packages(c('curl', 'xml2', 'httr', 'devtools', 'testthat', 'knitr', 'rmarkdown', 'roxygen2', 'e1071', 'survival'), repos='https://cloud.r-project.org/')"
Review comment:
@dongjoon-hyun, out of curiosity, do you remember why we needed `curl`, `xml2`, `httr` when we add `lint-r` job?
I thought it should be as below (from `docs/REAME.md`)
```bash
sudo Rscript -e 'install.packages(c("knitr", "devtools", "testthat", "rmarkdown", "roxygen2"), repos="https://cloud.r-project.org/")'
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27715:
[SPARK-30963][INFRA] Add GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#issuecomment-591760107
Thank you, @HyukjinKwon and @viirya . Since this is the first attempt to recover this test coverage, we can improve gradually from now.
Merged to master/3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27715:
[SPARK-30963][INFRA] Add GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#issuecomment-591673027
**[Test build #118992 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118992/testReport)** for PR 27715 at commit [`ea05f50`](https://github.com/apache/spark/commit/ea05f505e41458a83ad2271cf40f31f8ac6dc9a8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27715:
[SPARK-30963][INFRA] Add GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#issuecomment-591693643
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27715:
[SPARK-30963][INFRA] Add GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#discussion_r384796564
##########
File path: .github/workflows/master.yml
##########
@@ -117,3 +117,41 @@ jobs:
run: ./R/install-dev.sh
- name: lint-r
run: ./dev/lint-r
+
+ docs:
+ runs-on: ubuntu-latest
+ name: Generate documents
+ steps:
+ - uses: actions/checkout@master
+ - uses: actions/cache@v1
+ with:
+ path: ~/.m2/repository
+ key: docs-maven-repo-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ docs-maven-repo-
+ - uses: actions/setup-java@v1
+ with:
+ java-version: '1.8'
+ - uses: actions/setup-python@v1
+ with:
+ python-version: '3.x'
+ architecture: 'x64'
+ - uses: actions/setup-ruby@v1
+ with:
+ ruby-version: '2.7'
+ - name: Install R
+ run: |
+ echo 'deb https://cloud.r-project.org/bin/linux/ubuntu bionic-cran35/' | sudo tee -a /etc/apt/sources.list
+ curl -sL "https://keyserver.ubuntu.com/pks/lookup?op=get&search=0xE298A3A825C0D65DFD57CBB651716619E084DAB9" | sudo apt-key add
+ sudo apt-get update
+ sudo apt-get install -y r-base r-base-dev libcurl4-openssl-dev
Review comment:
Oh, thanks. Let me check that too, @viirya !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27715:
[SPARK-30963][INFRA] Add GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#issuecomment-591612600
cc @HyukjinKwon and @shaneknapp
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27715: [SPARK-30963][INFRA]
Add GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#issuecomment-591687368
Oh nice. +1. Let me take a look today!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27715:
[SPARK-30963][INFRA] Add GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#issuecomment-591693643
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27715:
[SPARK-30963][INFRA] Add GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#issuecomment-591691413
Thank you, @HyukjinKwon ! Please let me know if I missed something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27715:
[SPARK-30963][INFRA] Add GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#issuecomment-591673693
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23740/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27715:
[SPARK-30963][INFRA] Add GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#issuecomment-591726110
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118992/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27715:
[SPARK-30963][INFRA] Add GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#issuecomment-591726110
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118992/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27715: [SPARK-30963][INFRA] Add
GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#issuecomment-591692801
**[Test build #118990 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118990/testReport)** for PR 27715 at commit [`a6a09cc`](https://github.com/apache/spark/commit/a6a09ccc4d005e95fc986b6579e8f46256be7dc7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27715:
[SPARK-30963][INFRA] Add GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#issuecomment-591693648
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118990/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27715:
[SPARK-30963][INFRA] Add GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#issuecomment-591614356
**[Test build #118990 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118990/testReport)** for PR 27715 at commit [`a6a09cc`](https://github.com/apache/spark/commit/a6a09ccc4d005e95fc986b6579e8f46256be7dc7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27715:
[SPARK-30963][INFRA] Add GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#issuecomment-591615010
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23738/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27715:
[SPARK-30963][INFRA] Add GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#issuecomment-591673684
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27715:
[SPARK-30963][INFRA] Add GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#issuecomment-591614997
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27715:
[SPARK-30963][INFRA] Add GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#issuecomment-591726108
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27715: [SPARK-30963][INFRA] Add
GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#issuecomment-591673027
**[Test build #118992 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118992/testReport)** for PR 27715 at commit [`ea05f50`](https://github.com/apache/spark/commit/ea05f505e41458a83ad2271cf40f31f8ac6dc9a8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27715:
[SPARK-30963][INFRA] Add GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#issuecomment-591614997
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27715: [SPARK-30963][INFRA] Add
GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#issuecomment-591614356
**[Test build #118990 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118990/testReport)** for PR 27715 at commit [`a6a09cc`](https://github.com/apache/spark/commit/a6a09ccc4d005e95fc986b6579e8f46256be7dc7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27715:
[SPARK-30963][INFRA] Add GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#issuecomment-591726108
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27715:
[SPARK-30963][INFRA] Add GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#discussion_r384893853
##########
File path: .github/workflows/master.yml
##########
@@ -117,3 +117,40 @@ jobs:
run: ./R/install-dev.sh
- name: lint-r
run: ./dev/lint-r
+
+ docs:
+ runs-on: ubuntu-latest
+ name: Generate documents
+ steps:
+ - uses: actions/checkout@master
+ - uses: actions/cache@v1
+ with:
+ path: ~/.m2/repository
+ key: docs-maven-repo-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ docs-maven-repo-
+ - uses: actions/setup-java@v1
+ with:
+ java-version: '1.8'
+ - uses: actions/setup-python@v1
+ with:
+ python-version: '3.x'
+ architecture: 'x64'
+ - uses: actions/setup-ruby@v1
+ with:
+ ruby-version: '2.7'
+ - name: Install R
+ run: |
+ echo 'deb https://cloud.r-project.org/bin/linux/ubuntu bionic-cran35/' | sudo tee -a /etc/apt/sources.list
+ curl -sL "https://keyserver.ubuntu.com/pks/lookup?op=get&search=0xE298A3A825C0D65DFD57CBB651716619E084DAB9" | sudo apt-key add
+ sudo apt-get update
+ sudo apt-get install -y r-base r-base-dev libcurl4-openssl-dev pandoc
+ - name: Install packages
+ run: |
+ pip install sphinx mkdocs numpy
+ gem install jekyll jekyll-redirect-from rouge
+ sudo Rscript -e "install.packages(c('curl', 'xml2', 'httr', 'devtools', 'testthat', 'knitr', 'rmarkdown', 'roxygen2', 'e1071', 'survival'), repos='https://cloud.r-project.org/')"
Review comment:
IIRC, it was the legacy migrated from the old Jenkins jobs when we migrate that from old Jenkins. I believe we can remove them later if the test passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27715:
[SPARK-30963][INFRA] Add GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#issuecomment-591673684
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27715:
[SPARK-30963][INFRA] Add GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#issuecomment-591615010
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23738/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27715:
[SPARK-30963][INFRA] Add GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#discussion_r384893853
##########
File path: .github/workflows/master.yml
##########
@@ -117,3 +117,40 @@ jobs:
run: ./R/install-dev.sh
- name: lint-r
run: ./dev/lint-r
+
+ docs:
+ runs-on: ubuntu-latest
+ name: Generate documents
+ steps:
+ - uses: actions/checkout@master
+ - uses: actions/cache@v1
+ with:
+ path: ~/.m2/repository
+ key: docs-maven-repo-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ docs-maven-repo-
+ - uses: actions/setup-java@v1
+ with:
+ java-version: '1.8'
+ - uses: actions/setup-python@v1
+ with:
+ python-version: '3.x'
+ architecture: 'x64'
+ - uses: actions/setup-ruby@v1
+ with:
+ ruby-version: '2.7'
+ - name: Install R
+ run: |
+ echo 'deb https://cloud.r-project.org/bin/linux/ubuntu bionic-cran35/' | sudo tee -a /etc/apt/sources.list
+ curl -sL "https://keyserver.ubuntu.com/pks/lookup?op=get&search=0xE298A3A825C0D65DFD57CBB651716619E084DAB9" | sudo apt-key add
+ sudo apt-get update
+ sudo apt-get install -y r-base r-base-dev libcurl4-openssl-dev pandoc
+ - name: Install packages
+ run: |
+ pip install sphinx mkdocs numpy
+ gem install jekyll jekyll-redirect-from rouge
+ sudo Rscript -e "install.packages(c('curl', 'xml2', 'httr', 'devtools', 'testthat', 'knitr', 'rmarkdown', 'roxygen2', 'e1071', 'survival'), repos='https://cloud.r-project.org/')"
Review comment:
IIRC, it was the legacy migrated from the old Jenkins jobs when we migrated that from old Jenkins. I believe we can remove them later if the test passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27715: [SPARK-30963][INFRA] Add
GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#issuecomment-591725399
**[Test build #118992 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118992/testReport)** for PR 27715 at commit [`ea05f50`](https://github.com/apache/spark/commit/ea05f505e41458a83ad2271cf40f31f8ac6dc9a8).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #27715:
[SPARK-30963][INFRA] Add GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #27715:
[SPARK-30963][INFRA] Add GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#discussion_r384772100
##########
File path: .github/workflows/master.yml
##########
@@ -117,3 +117,41 @@ jobs:
run: ./R/install-dev.sh
- name: lint-r
run: ./dev/lint-r
+
+ docs:
+ runs-on: ubuntu-latest
+ name: Generate documents
+ steps:
+ - uses: actions/checkout@master
+ - uses: actions/cache@v1
+ with:
+ path: ~/.m2/repository
+ key: docs-maven-repo-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ docs-maven-repo-
+ - uses: actions/setup-java@v1
+ with:
+ java-version: '1.8'
+ - uses: actions/setup-python@v1
+ with:
+ python-version: '3.x'
+ architecture: 'x64'
+ - uses: actions/setup-ruby@v1
+ with:
+ ruby-version: '2.7'
+ - name: Install R
+ run: |
+ echo 'deb https://cloud.r-project.org/bin/linux/ubuntu bionic-cran35/' | sudo tee -a /etc/apt/sources.list
+ curl -sL "https://keyserver.ubuntu.com/pks/lookup?op=get&search=0xE298A3A825C0D65DFD57CBB651716619E084DAB9" | sudo apt-key add
+ sudo apt-get update
+ sudo apt-get install -y r-base r-base-dev libcurl4-openssl-dev
Review comment:
Do we need pandoc for R document? I saw:
> If you'd like to generate R documentation, you'll need to [install Pandoc](https://pandoc.org/installing.html) and install these libraries ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27715:
[SPARK-30963][INFRA] Add GitHub Action job for document generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27715: [SPARK-30963][INFRA] Add GitHub Action job for document generation
URL: https://github.com/apache/spark/pull/27715#issuecomment-591693648
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118990/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org