You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/11/01 07:29:27 UTC

[GitHub] [calcite] cndaimin opened a new pull request #1555: [CALCITE-3469] Fix typo in SubstitutionVisitor#rowTypesAreEquivalent

cndaimin opened a new pull request #1555: [CALCITE-3469] Fix typo in SubstitutionVisitor#rowTypesAreEquivalent
URL: https://github.com/apache/calcite/pull/1555
 
 
   ```Java
   private boolean rowTypesAreEquivalent(
         MutableRel rel0, MutableRel rel1, Litmus litmus) {
       if (rel0.rowType.getFieldCount() != rel1.rowType.getFieldCount()) {
         return litmus.fail("Mismatch for column count: [{}]", Pair.of(rel0, rel1));
       }
       for (Pair<RelDataTypeField, RelDataTypeField> pair
           : Pair.zip(rel0.rowType.getFieldList(), rel0.rowType.getFieldList())) {
         if (!pair.left.getType().equals(pair.right.getType())) {
           return litmus.fail("Mismatch for column type: [{}]", Pair.of(rel0, rel1));
         }
       }
       return litmus.succeed();
     }
   ```
   where `Pair.zip(rel0.rowType.getFieldList(), rel0.rowType.getFieldList())` should be 
   `Pair.zip(rel0.rowType.getFieldList(), rel1.rowType.getFieldList())`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services