You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "imbajin (via GitHub)" <gi...@apache.org> on 2026/10/09 19:03:01 UTC
[PR] fix(store): drain scan and native resources [hugegraph]
imbajin opened a new pull request, #3303:
URL: https://github.com/apache/hugegraph/pull/3303
Store can close its databases while scans, RPC callbacks or TTL workers still own native resources. This change closes admission, cancels active work and drains its owners before storage shutdown. Request half-close remains distinct from transport cancellation, final batches are retained, cleanup failures stay visible, and interrupted Raft joins finish before teardown continues.
Client response parsing now runs outside the short state lock. Early iterator close cancels the transport without waiting for a blocked request send; normal half-close remains serialized. Client and server changes stay together so their cancellation/feedback behavior agrees. Tests, plain/executable Node artifact packaging and lifecycle CI registration accompany the functionality.
Split from hugegraph/hugegraph#261 and ASF #3294. Org review: https://github.com/hugegraph/hugegraph/pull/280. Based directly on current master, independent of the Server transaction split. Scan cancellation and shutdown share the same owner registry and drain barrier; separating them would leave an unsafe intermediate shutdown path and duplicate lifecycle wiring. Required packaging/test changes therefore stay here rather than forming a separate build PR.
Validation: independent diff review, formatting and `git diff --check` pass. Java 17 PD/Store packaging passes. Focused client, Scan/partition/barrier, aggregate-query, shutdown/TTL/Raft and native-iterator regressions pass using the reactor classpath; shutdown coverage includes an isolated JNI subprocess. JaCoCo and stop-script contracts pass. Full reactor CI, real Store process stop/restart checks and master-versus-candidate benchmarks are still being completed. No throughput improvement or full CI pass is claimed.
Doc - Done: `docs/store-lifecycle.md` and Store README shutdown instructions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix(store): preserve RPC and scan lifecycles [hugegraph]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3303:
URL: https://github.com/apache/hugegraph/pull/3303#issuecomment-6088031871
## [Codecov](https://app.codecov.io/gh/apache/hugegraph/pull/3303?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 35.14%. Comparing base ([`d00efce`](https://app.codecov.io/gh/apache/hugegraph/commit/d00efcedbcb8b844d3ff147834c97eaaaf36593c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`15b445a`](https://app.codecov.io/gh/apache/hugegraph/commit/15b445a955f9d2a64be3545df78ebb334bf7ab63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (d00efce) and HEAD (15b445a). Click for more details.
>
> <details><summary>HEAD has 4 uploads less than BASE</summary>
>
>| Flag | BASE (d00efce) | HEAD (15b445a) |
>|------|------|------|
>||6|2|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3303 +/- ##
============================================
- Coverage 41.42% 35.14% -6.29%
+ Complexity 6931 4619 -2312
============================================
Files 762 560 -202
Lines 66773 52624 -14149
Branches 8939 7286 -1653
============================================
- Hits 27662 18495 -9167
+ Misses 35957 31870 -4087
+ Partials 3154 2259 -895
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/hugegraph/pull/3303?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix(store): complete RPC and scan lifecycle [hugegraph]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin merged PR #3303:
URL: https://github.com/apache/hugegraph/pull/3303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org