You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2017/02/09 16:26:15 UTC

Review Request 56502: Unexpected paging behavior on Hosts page

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56502/
-----------------------------------------------------------

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-19942
    https://issues.apache.org/jira/browse/AMBARI-19942


Repository: ambari


Description
-------

Ambari remembers the page size of the Hosts page that was previously used.
After setting the page size to 100, logging out, and logging back in, the table only shows 10 hosts. Then all of a sudden it shows 100 hosts. This experience is jarring to the end user.
It's much better if we don't show any hosts at all until all 100 hosts can be shown.


Diffs
-----

  ambari-web/app/views/main/host.js 9183f6b 
  ambari-web/test/views/main/host_test.js 50279e6 

Diff: https://reviews.apache.org/r/56502/diff/


Testing
-------

30312 passing (34s)
157 pending


Thanks,

Andrii Tkach

Re: Review Request 56502: Unexpected paging behavior on Hosts page

Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56502/#review164949
-----------------------------------------------------------


Ship it!




Ship It!

- Aleksandr Kovalenko


On \u0424\u0435\u0432. 9, 2017, 4:26 \u043f.\u043f., Andrii Tkach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56502/
> -----------------------------------------------------------
> 
> (Updated \u0424\u0435\u0432. 9, 2017, 4:26 \u043f.\u043f.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-19942
>     https://issues.apache.org/jira/browse/AMBARI-19942
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari remembers the page size of the Hosts page that was previously used.
> After setting the page size to 100, logging out, and logging back in, the table only shows 10 hosts. Then all of a sudden it shows 100 hosts. This experience is jarring to the end user.
> It's much better if we don't show any hosts at all until all 100 hosts can be shown.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/views/main/host.js 9183f6b 
>   ambari-web/test/views/main/host_test.js 50279e6 
> 
> Diff: https://reviews.apache.org/r/56502/diff/
> 
> 
> Testing
> -------
> 
> 30312 passing (34s)
> 157 pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>