You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/03 08:09:44 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6196: libxx: Make HAVE_CXXINITIALIZE workable even HAVE_CXX isn't enabled
xiaoxiang781216 opened a new pull request, #6196:
URL: https://github.com/apache/incubator-nuttx/pull/6196
## Summary
and simplify the implementation of c++ initialization
## Impact
c++ initialization
## Testing
Pass local test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6196: libxx: Make HAVE_CXXINITIALIZE workable even HAVE_CXX isn't enabled
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6196:
URL: https://github.com/apache/incubator-nuttx/pull/6196#discussion_r863885427
##########
libs/libc/misc/lib_cxx_initialize.c:
##########
@@ -75,13 +77,18 @@ extern uintptr_t _etext;
*
****************************************************************************/
-void cxx_initialize(void)
+void lib_cxx_initialize(void)
{
#ifdef CONFIG_HAVE_CXXINITIALIZE
static int inited = 0;
if (inited == 0)
{
+#if defined(CONFIG_ARCH_SIM) && defined(CONFIG_HOST_MACOS)
+ extern void macho_call_saved_init_funcs(void);
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6196: libxx: Make HAVE_CXXINITIALIZE workable even HAVE_CXX isn't enabled
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6196:
URL: https://github.com/apache/incubator-nuttx/pull/6196#discussion_r863797846
##########
libs/libc/misc/lib_cxx_initialize.c:
##########
@@ -75,13 +77,18 @@ extern uintptr_t _etext;
*
****************************************************************************/
-void cxx_initialize(void)
+void lib_cxx_initialize(void)
{
#ifdef CONFIG_HAVE_CXXINITIALIZE
static int inited = 0;
if (inited == 0)
{
+#if defined(CONFIG_ARCH_SIM) && defined(CONFIG_HOST_MACOS)
+ extern void macho_call_saved_init_funcs(void);
Review Comment:
Maybe we can have it as a part of `External References` section?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea merged pull request #6196: libxx: Make HAVE_CXXINITIALIZE workable even HAVE_CXX isn't enabled
Posted by GitBox <gi...@apache.org>.
jerpelea merged PR #6196:
URL: https://github.com/apache/incubator-nuttx/pull/6196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org