[jira] [Commented] (HIVE-16805) Utilities isEmptyPath Logging Too Chatty and Uses Bad Format

["Hive QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-16805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16033638#comment-16033638 ] 

Hive QA commented on HIVE-16805:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12870839/HIVE-16805.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 10813 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[stats_partscan_1_23] (batchId=84)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr] (batchId=145)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/5499/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/5499/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-5499/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12870839 - PreCommit-HIVE-Build

> Utilities isEmptyPath Logging Too Chatty and Uses Bad Format
> ------------------------------------------------------------
>
>                 Key: HIVE-16805
>                 URL: https://issues.apache.org/jira/browse/HIVE-16805
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 2.1.1, 3.0.0
>            Reporter: BELUGA BEHR
>            Priority: Minor
>         Attachments: HIVE-16805.1.patch
>
>
> {code:title=org.apache.hadoop.hive.ql.exec.Utilities}
>   public static boolean isEmptyPath(JobConf job, Path dirPath, Context ctx)
>       throws Exception {
>     if (ctx != null) {
>       ContentSummary cs = ctx.getCS(dirPath);
>       if (cs != null) {
>         LOG.info("Content Summary " + dirPath + "length: " + cs.getLength() + " num files: "
>             + cs.getFileCount() + " num directories: " + cs.getDirectoryCount());
>         return (cs.getLength() == 0 && cs.getFileCount() == 0 && cs.getDirectoryCount() <= 1);
>       } else {
>         LOG.info("Content Summary not cached for " + dirPath);
>       }
>     }
>     return isEmptyPath(job, dirPath);
>   }
> {code}
> # This is too chatty.  Logging for caching is not necessary for INFO logging.  Move to DEBUG
> # Use Log4J's {} format
> # Make the messages more symmetrical - The success message doesn't include the word "cache" in it at all
> # Missing a space between the path and "length: " so the path is concatenated with the string "length:"



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)