You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2016/10/02 20:06:03 UTC
[Impala-ASF-CR] IMPALA-2916: Add warning to query profile if debug build
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4588
Change subject: IMPALA-2916: Add warning to query profile if debug build
......................................................................
IMPALA-2916: Add warning to query profile if debug build
Change-Id: I85ce4d4a5624382203e6b2c8f5b96d04c4482f37
---
M be/src/service/query-exec-state.cc
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/4588/1
--
To view, visit http://gerrit.cloudera.org:8080/4588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I85ce4d4a5624382203e6b2c8f5b96d04c4482f37
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-2916: Add warning to query profile if debug build
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-2916: Add warning to query profile if debug build
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85ce4d4a5624382203e6b2c8f5b96d04c4482f37
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2916: Add warning to query profile if debug build
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-2916: Add warning to query profile if debug build
......................................................................
Patch Set 1:
(2 comments)
Thanks for the review, please see PS2.
http://gerrit.cloudera.org:8080/#/c/4588/1/be/src/service/query-exec-state.cc
File be/src/service/query-exec-state.cc:
PS1, Line 88: WARNING
> Let's not use such a generic key. How about "Debug Mode Warning" ?
Done. I made the key all uppercase, so it becomes very easy to spot. Let me know if you think it's too much.
PS1, Line 88: "WARNING", "This profile has been created by a DEBUG build. If "
: "you are looking for performance related information, we suggest to use a RELEASE "
: "build instead."
> Just a suggestion to make it snappier:
Thanks, done.
--
To view, visit http://gerrit.cloudera.org:8080/4588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85ce4d4a5624382203e6b2c8f5b96d04c4482f37
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-2916: Add warning to query profile if debug build
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-2916: Add warning to query profile if debug build
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85ce4d4a5624382203e6b2c8f5b96d04c4482f37
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2916: Add warning to query profile if debug build
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-2916: Add warning to query profile if debug build
......................................................................
Patch Set 1:
(2 comments)
This will be useful to have.
http://gerrit.cloudera.org:8080/#/c/4588/1/be/src/service/query-exec-state.cc
File be/src/service/query-exec-state.cc:
PS1, Line 88: WARNING
Let's not use such a generic key. How about "Debug Mode Warning" ?
PS1, Line 88: "WARNING", "This profile has been created by a DEBUG build. If "
: "you are looking for performance related information, we suggest to use a RELEASE "
: "build instead."
Just a suggestion to make it snappier:
"Query profile created while running a DEBUG build of Impala. Use RELEASE builds to measure query performance."
--
To view, visit http://gerrit.cloudera.org:8080/4588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85ce4d4a5624382203e6b2c8f5b96d04c4482f37
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-2916: Add warning to query profile if debug build
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has uploaded a new patch set (#2).
Change subject: IMPALA-2916: Add warning to query profile if debug build
......................................................................
IMPALA-2916: Add warning to query profile if debug build
Change-Id: I85ce4d4a5624382203e6b2c8f5b96d04c4482f37
---
M be/src/service/query-exec-state.cc
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/4588/2
--
To view, visit http://gerrit.cloudera.org:8080/4588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I85ce4d4a5624382203e6b2c8f5b96d04c4482f37
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
[Impala-ASF-CR] IMPALA-2916: Add warning to query profile if debug build
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-2916: Add warning to query profile if debug build
......................................................................
IMPALA-2916: Add warning to query profile if debug build
Change-Id: I85ce4d4a5624382203e6b2c8f5b96d04c4482f37
Reviewed-on: http://gerrit.cloudera.org:8080/4588
Reviewed-by: Henry Robinson <he...@cloudera.com>
Tested-by: Internal Jenkins
---
M be/src/service/query-exec-state.cc
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Henry Robinson: Looks good to me, approved
Internal Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I85ce4d4a5624382203e6b2c8f5b96d04c4482f37
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>