[GitHub] [arrow] wesm edited a comment on pull request #7120: ARROW-8727: [C++] Don't require stack allocation of any object to use StringConverter, hide behind ParseValue function

[GitBox <gi...@apache.org>]

wesm edited a comment on pull request #7120:
URL: https://github.com/apache/arrow/pull/7120#issuecomment-625297750


   > For example, at some point conversion used C++ streams and a locale. The locale was stored on the converter instance.
   
   I'd prefer to handle this by passing a context/state argument into the `Parse` API so that the struct-initialization step is not required universally for all data types. 
   
   ```
   struct ConversionContext {};
   
   struct FloatConversionContext : public ConversionContext {
     std::locale ...;
   };
   
   ...
   
   ParseValue<T>(&ctx, s, length, &out);
   ```
   
   Might be good to go ahead and implement this idea for `TimestampType`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org