You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2020/03/27 19:12:32 UTC
[GitHub] [groovy] timyates opened a new pull request #1210: Fix 'Save
changes?' dialog quitting on cancel with Java 11 on OSX
timyates opened a new pull request #1210: Fix 'Save changes?' dialog quitting on cancel with Java 11 on OSX
URL: https://github.com/apache/groovy/pull/1210
Hiya! 👋
If the user quits the Groovy console with unsaved changes, it asks if they want to 'Save changes?'
Under Java 11, this still quits if they click 'Cancel', it looks like we need to cancel the quit event if cancel was pressed
(*Note:* I've not done this in a long time, please let me know if I've missed a step, or not signed something)
Hope you're all keeping well!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [groovy] timyates commented on issue #1210: [GROOVY-9483] Fix 'Save
changes?' dialog quitting on cancel with Java 11 on OSX
Posted by GitBox <gi...@apache.org>.
timyates commented on issue #1210: [GROOVY-9483] Fix 'Save changes?' dialog quitting on cancel with Java 11 on OSX
URL: https://github.com/apache/groovy/pull/1210#issuecomment-605323376
Just checked it with 14.0.0-zulu, and it works as expected 🙌
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [groovy] danielsun1106 merged pull request #1210: [GROOVY-9483] Fix
'Save changes?' dialog quitting on cancel with Java 11 on OSX
Posted by GitBox <gi...@apache.org>.
danielsun1106 merged pull request #1210: [GROOVY-9483] Fix 'Save changes?' dialog quitting on cancel with Java 11 on OSX
URL: https://github.com/apache/groovy/pull/1210
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [groovy] timyates commented on issue #1210: Fix 'Save changes?'
dialog quitting on cancel with Java 11 on OSX
Posted by GitBox <gi...@apache.org>.
timyates commented on issue #1210: Fix 'Save changes?' dialog quitting on cancel with Java 11 on OSX
URL: https://github.com/apache/groovy/pull/1210#issuecomment-605300770
https://issues.apache.org/jira/browse/GROOVY-9483
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [groovy] danielsun1106 commented on issue #1210: [GROOVY-9483] Fix
'Save changes?' dialog quitting on cancel with Java 11 on OSX
Posted by GitBox <gi...@apache.org>.
danielsun1106 commented on issue #1210: [GROOVY-9483] Fix 'Save changes?' dialog quitting on cancel with Java 11 on OSX
URL: https://github.com/apache/groovy/pull/1210#issuecomment-605307762
+1
> Not sure why those checks are failing... Don't think it was me... 😞
We face a weired issue on the github actions CI...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [groovy] timyates commented on issue #1210: Fix 'Save changes?'
dialog quitting on cancel with Java 11 on OSX
Posted by GitBox <gi...@apache.org>.
timyates commented on issue #1210: Fix 'Save changes?' dialog quitting on cancel with Java 11 on OSX
URL: https://github.com/apache/groovy/pull/1210#issuecomment-605276548
Not sure why those checks are failing... Don't _think_ it was me... 😞
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [groovy] danielsun1106 commented on issue #1210: [GROOVY-9483] Fix
'Save changes?' dialog quitting on cancel with Java 11 on OSX
Posted by GitBox <gi...@apache.org>.
danielsun1106 commented on issue #1210: [GROOVY-9483] Fix 'Save changes?' dialog quitting on cancel with Java 11 on OSX
URL: https://github.com/apache/groovy/pull/1210#issuecomment-605346616
Merged. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services