You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/05/18 20:03:17 UTC

[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #778: IGNITE-16550-4

vldpyatkov commented on code in PR #778:
URL: https://github.com/apache/ignite-3/pull/778#discussion_r853165400


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -542,11 +456,14 @@ private void createTableLocally(long causalityToken, String name, UUID tblId, in
             throw new IgniteInternalException(IgniteStringFormatter.format("Cannot create a table [name={}, id={}]", name, tblId), th);
         });
 
-        CompletableFuture.allOf(tablesByIdVv.get(causalityToken), tablesVv.get(causalityToken)).thenRun(() -> {
+        // TODO should be reworked in IGNITE-16763
+        schemaFut.thenCompose(v -> tablesByIdVv.get(causalityToken)).thenRun(() -> {

Review Comment:
   Why does the composed future required?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org