You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/29 11:04:17 UTC

[GitHub] [tvm] neildhickey commented on a diff in pull request #13498: [CMSIS-NN] Support int16 handling for pooling functions

neildhickey commented on code in PR #13498:
URL: https://github.com/apache/tvm/pull/13498#discussion_r1034608038


##########
tests/python/contrib/test_cmsisnn/test_pooling.py:
##########
@@ -103,18 +105,17 @@ def test_op_int8(
     compiler_cpu,
     cpu_flags,
 ):
-    """Tests QNN pooling op for int8 inputs"""
+    """Tests QNN pooling op for int8 and int16 inputs"""

Review Comment:
   I tried to add a negative test for this but it wasn't possible to produce a model that fell into this condition, particularly in the case of max_pool. In the end I think it is okay to leave the check for this state in cmsisnn.py but I don't see an easy way to test this directly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org