[GitHub] [kafka] chia7712 commented on a change in pull request #8673: KAFKA-9992: EmbeddedKafkaCluster.deleteTopicAndWait not working with kafka_2.13

[GitBox <gi...@apache.org>]

chia7712 commented on a change in pull request #8673:
URL: https://github.com/apache/kafka/pull/8673#discussion_r426134960



##########
File path: streams/src/test/java/org/apache/kafka/streams/integration/utils/EmbeddedKafkaCluster.java
##########
@@ -297,6 +295,15 @@ public void deleteAllTopicsAndWait(final long timeoutMs) throws InterruptedExcep
         }
     }
 
+    public Set<String> getAllTopics() {
+        scala.collection.Iterator<String> topicsIterator = brokers[0].kafkaServer().zkClient().getAllTopicsInCluster().iterator();

Review comment:
       > getAllTopicsInCluster()
   
   ```getAllTopicsInCluster(false)```

##########
File path: streams/src/test/java/org/apache/kafka/streams/integration/utils/EmbeddedKafkaCluster.java
##########
@@ -297,6 +295,15 @@ public void deleteAllTopicsAndWait(final long timeoutMs) throws InterruptedExcep
         }
     }
 
+    public Set<String> getAllTopics() {

Review comment:
       ```getAllTopicsInCluster``` seems to be duplicate to this new method. Could we remove the former?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org