[GitHub] [cloudstack] andrijapanicsb edited a comment on pull request #4033: kvm: suspend/resume in deleting vm snapshot on kvm

[GitBox <gi...@apache.org>]

andrijapanicsb edited a comment on pull request #4033:
URL: https://github.com/apache/cloudstack/pull/4033#issuecomment-624646040


   @weizhouapache ... should we also suspend the VM while we delete **VM snapshot** right after Backuping up **volume snap** to Secondary Storage, below:
   
   https://github.com/ustcweizhou/cloudstack/blob/6f30fdfed2986a52c78fb095b2cdc917f1e8f216/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtBackupSnapshotCommandWrapper.java#L175
   
   This PR code 4033 is executed when we delete a VM snapshot that we manually created previously : (i.e. proper resume during creation and deletion of the VM snap) - all good here.
   
   But when kvm.snapshots.enabled=true, and you snap **just the volume** of the running VM - I could see that the whole VM is being paused, whole VM snapshot was taken (all volumes and RAM) and then VM is being resumed and then a single volume snapshots (from the qcow2) is being exported via qemu-img to Secondary STorage and then the original VM snapshot is deleted - during this VM SNAP deletion I could not confirm the VM is being ALWAYS paused/suspended (no logs messages ever, but I could see it being paused when DATA volume snap is deleted, most of the time, but not paused when ROOT volumes are snapped)- i.e. I could see that the code of this PR is NOT executed, but some other code (what I shared above I guess?) - since I can't see for example that this logging is NOT done:    s_logger.debug("Suspending domain " + vmName); (from this PR)
   
   The only thing I would like to see verified is that the VM is always suspended (like in this PR) when we delete CREATE VOLUME SNAPSHOT, due to the whole VM SNAPSHOTS is taken/deleted when we do just a volume snapshots (running VM, with kvm.snapshots.enable=true)
   
   Could you please advise?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org