You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Scott O'Bryan <da...@gmail.com> on 2009/12/24 22:59:32 UTC

Re: [jira] Commented: (TRINIDAD-1233) URLs in generated CSS might include ;jessionid=xxxx

Encoding needs to be done for portals in all cases..

We talked about adding this optimization to Trinidad a while ago.
It's as simple as making a configurator that, when running as a
servlet) overrides the encodeResourceUrl to return the base URL
without doing any encoding.  The reason we didn't do this is it brings
it off spec with JSF.

Sent from my iPhone

On Dec 24, 2009, at 1:44 PM, "Blake Sullivan (JIRA)" <dev@myfaces.apache.org
 > wrote:

>
>    [ https://issues.apache.org/jira/browse/TRINIDAD-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794493#action_12794493
>  ]
>
> Blake Sullivan commented on TRINIDAD-1233:
> ------------------------------------------
>
> There are definitely things we could do with the implementation to
> make it faster and I don't think that this is exactly where we would
> want to perform this work in all cases (CSSUtils.getAbsoluteURIValue
> () presumably needs to return URLs without jsessionid as well), but
> I have a more basic question--if we don't want the session id to be
> added to the URL, why don't we just stop calling
> ExternalContext.encodeResourceURL()?  All
> ExternalContext.encodeResourceURL() does is add the jsessionid if
> necessary, so why call the method and go to all of the work of
> ripping it back out?
>
>> URLs in generated CSS might include ;jessionid=xxxx
>> ---------------------------------------------------
>>
>>                Key: TRINIDAD-1233
>>                URL: https://issues.apache.org/jira/browse/TRINIDAD-1233
>>            Project: MyFaces Trinidad
>>         Issue Type: Improvement
>>   Affects Versions: 1.2.9-core
>>        Environment: Trinidad 1.2.10-SNAPSHOT
>> tomcat 6.0.14
>> tomcat 5.5
>>           Reporter: Harald Kuhn
>>        Attachments: CSSUtils.java.patch
>>
>>
>> Depending on the Servlet-Container URLs in the generated CSS-file
>> may include the Session-Id (of the session that initiated the
>> generation).
>> i.e.
>> background-image:url(/aim/css/skin/airplus/img/
>> dialogclose.gif;jsessionid=8A002E216A7B2BF42735740787DBF102.tomcat)
>> This part of the URL should be removed.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>