[GitHub] [pulsar-helm-chart] sijie commented on a change in pull request #181: [Istio] Kill istio proxy when container has completed

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #181:
URL: https://github.com/apache/pulsar-helm-chart/pull/181#discussion_r768211745



##########
File path: charts/pulsar/templates/bookkeeper-cluster-initialize.yaml
##########
@@ -69,6 +69,9 @@ spec:
                 {{- end }}
                 bin/bookkeeper shell initnewcluster;
             fi
+            {{- if .Values.istio.enabled }}

Review comment:
       I would suggest a different approach:
   
   Can you just introduce a setting called `extraInitCommand`? So you can include this in the init container. Then you can add this command to your values file. This provides better extensibility to the helm chart.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org