You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Guenter Knauf <fu...@apache.org> on 2008/01/01 16:08:24 UTC
svn commit: r607853 - /httpd/httpd/branches/2.0.x/STATUS
Hi Ruediger,
> --- httpd/httpd/branches/2.0.x/STATUS (original)
> +++ httpd/httpd/branches/2.0.x/STATUS Tue Jan 1 06:48:51 2008
> @@ -129,7 +129,7 @@
> http://svn.apache.org/viewvc?rev==607282&view==rev
> Backport version for 2.0.x of patch:
> http://awe.com/e8f6ad05238f8/CVE-2007-6388-httpd-2.x.patch
> - +1: rpluem,
> + +1: rpluem, fuankg
> PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
> [ start all new proposals below, under PATCHES PROPOSED. ]
I would prefer if we default to something greater than 1 second;
with refresh of 1 second its near to impossible to correct a typo, f.e.:
http://localhost/server-status?refresh=bla
results in an 1-second auto-refresh;
if we would default to 10 or 30 secs then it would be possible to edit the URL and correct the value.
apr_table_set(r->headers_out,
status_options[i].hdr_out_str,
--- apr_ltoa(r->pool, t < 1 ? 1 : t));
+++ apr_ltoa(r->pool, t < 1 ? 10 : t));
Guenter.
Re: svn commit: r607853 - /httpd/httpd/branches/2.0.x/STATUS
Posted by Ruediger Pluem <rp...@apache.org>.
On 01/01/2008 04:08 PM, Guenter Knauf wrote:
> Hi Ruediger,
>
>> --- httpd/httpd/branches/2.0.x/STATUS (original)
>> +++ httpd/httpd/branches/2.0.x/STATUS Tue Jan 1 06:48:51 2008
>> @@ -129,7 +129,7 @@
>> http://svn.apache.org/viewvc?rev==607282&view==rev
>> Backport version for 2.0.x of patch:
>> http://awe.com/e8f6ad05238f8/CVE-2007-6388-httpd-2.x.patch
>> - +1: rpluem,
>> + +1: rpluem, fuankg
>
>> PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
>> [ start all new proposals below, under PATCHES PROPOSED. ]
>
> I would prefer if we default to something greater than 1 second;
> with refresh of 1 second its near to impossible to correct a typo, f.e.:
> http://localhost/server-status?refresh=bla
>
> results in an 1-second auto-refresh;
> if we would default to 10 or 30 secs then it would be possible to edit the URL and correct the value.
>
> apr_table_set(r->headers_out,
> status_options[i].hdr_out_str,
> --- apr_ltoa(r->pool, t < 1 ? 1 : t));
> +++ apr_ltoa(r->pool, t < 1 ? 10 : t));
Sounds reasonable. OTOH this has been already backported to 2.2.x. So as I think we should have
the same behaviour in 2.0.x / 2.2.x / trunk I would propose fixing this in trunk and proposing it
for backport in 2.0.x / 2.2.x. And yes I would be +1 to this :-). So only one vote would be missing
for the backport and we should be able to get the missing vote rather quickly.
Regards
Rüdiger