You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/06/29 04:10:19 UTC

[GitHub] [rocketmq-client-go] fengberlin opened a new pull request #691: fix: call cancel() as soon as possible to release the resources associatd with context

fengberlin opened a new pull request #691:
URL: https://github.com/apache/rocketmq-client-go/pull/691


   Although the the resources associatd with the context created by context.WithTimeout will be release after the timer elapsed, but call cancel() to release the resources as soon as possible can avoid context/memory leak.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] maixiaohai commented on pull request #691: fix: call cancel() as soon as possible to release the resources associatd with context

Posted by GitBox <gi...@apache.org>.
maixiaohai commented on pull request #691:
URL: https://github.com/apache/rocketmq-client-go/pull/691#issuecomment-874125272


   @fengberlin plz create a related issue~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] maixiaohai merged pull request #691: [ISSUE #698] fix: call cancel() as soon as possible to release the resources associatd with context

Posted by GitBox <gi...@apache.org>.
maixiaohai merged pull request #691:
URL: https://github.com/apache/rocketmq-client-go/pull/691


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] codecov-commenter edited a comment on pull request #691: fix: call cancel() as soon as possible to release the resources associatd with context

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #691:
URL: https://github.com/apache/rocketmq-client-go/pull/691#issuecomment-870217011


   # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/691?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#691](https://codecov.io/gh/apache/rocketmq-client-go/pull/691?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (506e50e) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/c688c190734dcdb6e2fc9b2f6791544d648185a2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c688c19) will **increase** coverage by `0.02%`.
   > The diff coverage is `35.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-go/pull/691/graphs/tree.svg?width=650&height=150&src=pr&token=CiV9ofPkG3&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/rocketmq-client-go/pull/691?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #691      +/-   ##
   ==========================================
   + Coverage   24.71%   24.74%   +0.02%     
   ==========================================
     Files          48       48              
     Lines        5223     5234      +11     
   ==========================================
   + Hits         1291     1295       +4     
   - Misses       3726     3733       +7     
     Partials      206      206              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/691?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [internal/client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvY2xpZW50Lmdv) | `0.00% <0.00%> (ø)` | |
   | [internal/trace.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvdHJhY2UuZ28=) | `29.49% <0.00%> (-0.11%)` | :arrow_down: |
   | [internal/route.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvcm91dGUuZ28=) | `9.86% <100.00%> (+0.61%)` | :arrow_up: |
   | [producer/producer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvZHVjZXIvcHJvZHVjZXIuZ28=) | `28.57% <100.00%> (+0.44%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/691?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/691?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c688c19...506e50e](https://codecov.io/gh/apache/rocketmq-client-go/pull/691?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] fengberlin edited a comment on pull request #691: fix: call cancel() as soon as possible to release the resources associatd with context

Posted by GitBox <gi...@apache.org>.
fengberlin edited a comment on pull request #691:
URL: https://github.com/apache/rocketmq-client-go/pull/691#issuecomment-873762332


   Please continue reviewing my PR. Thanks.
   @wenfengwang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] codecov-commenter edited a comment on pull request #691: fix: call cancel() as soon as possible to release the resources associatd with context

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #691:
URL: https://github.com/apache/rocketmq-client-go/pull/691#issuecomment-870217011


   # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/691?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#691](https://codecov.io/gh/apache/rocketmq-client-go/pull/691?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (506e50e) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/c688c190734dcdb6e2fc9b2f6791544d648185a2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c688c19) will **increase** coverage by `0.02%`.
   > The diff coverage is `35.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-go/pull/691/graphs/tree.svg?width=650&height=150&src=pr&token=CiV9ofPkG3&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/rocketmq-client-go/pull/691?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #691      +/-   ##
   ==========================================
   + Coverage   24.71%   24.74%   +0.02%     
   ==========================================
     Files          48       48              
     Lines        5223     5234      +11     
   ==========================================
   + Hits         1291     1295       +4     
   - Misses       3726     3733       +7     
     Partials      206      206              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/691?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [internal/client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvY2xpZW50Lmdv) | `0.00% <0.00%> (ø)` | |
   | [internal/trace.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvdHJhY2UuZ28=) | `29.49% <0.00%> (-0.11%)` | :arrow_down: |
   | [internal/route.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvcm91dGUuZ28=) | `9.86% <100.00%> (+0.61%)` | :arrow_up: |
   | [producer/producer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvZHVjZXIvcHJvZHVjZXIuZ28=) | `28.57% <100.00%> (+0.44%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/691?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/691?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c688c19...506e50e](https://codecov.io/gh/apache/rocketmq-client-go/pull/691?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] fengberlin commented on pull request #691: fix: call cancel() as soon as possible to release the resources associatd with context

Posted by GitBox <gi...@apache.org>.
fengberlin commented on pull request #691:
URL: https://github.com/apache/rocketmq-client-go/pull/691#issuecomment-873762332


   Please continue reviewing my reopen PR. Thanks.
   @wenfengwang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] fengberlin removed a comment on pull request #691: fix: call cancel() as soon as possible to release the resources associatd with context

Posted by GitBox <gi...@apache.org>.
fengberlin removed a comment on pull request #691:
URL: https://github.com/apache/rocketmq-client-go/pull/691#issuecomment-870253416


   @xujianhai666


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] fengberlin commented on pull request #691: fix: call cancel() as soon as possible to release the resources associatd with context

Posted by GitBox <gi...@apache.org>.
fengberlin commented on pull request #691:
URL: https://github.com/apache/rocketmq-client-go/pull/691#issuecomment-874199396


   > @fengberlin plz create a related issue~
   
   I have been created the issue [#698](https://github.com/apache/rocketmq-client-go/issues/698) related to this PR.
   Plz continue review my PR. Thanks.
   @maixiaohai


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] wenfengwang commented on pull request #691: fix: call cancel() as soon as possible to release the resources associatd with context

Posted by GitBox <gi...@apache.org>.
wenfengwang commented on pull request #691:
URL: https://github.com/apache/rocketmq-client-go/pull/691#issuecomment-872190640


   It seems that the changes of this PR  included in https://github.com/apache/rocketmq-client-go/pull/691


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] fengberlin commented on pull request #691: fix: call cancel() as soon as possible to release the resources associatd with context

Posted by GitBox <gi...@apache.org>.
fengberlin commented on pull request #691:
URL: https://github.com/apache/rocketmq-client-go/pull/691#issuecomment-870253416


   @xujianhai666


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] wenfengwang edited a comment on pull request #691: fix: call cancel() as soon as possible to release the resources associatd with context

Posted by GitBox <gi...@apache.org>.
wenfengwang edited a comment on pull request #691:
URL: https://github.com/apache/rocketmq-client-go/pull/691#issuecomment-872190640


   It seems that the changes of this PR  included in https://github.com/apache/rocketmq-client-go/pull/692
   
   could you separate them or close this PR? 
   
   @fengberlin


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] maixiaohai commented on pull request #691: fix: call cancel() as soon as possible to release the resources associatd with context

Posted by GitBox <gi...@apache.org>.
maixiaohai commented on pull request #691:
URL: https://github.com/apache/rocketmq-client-go/pull/691#issuecomment-874125272


   @fengberlin plz create a related issue~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] wenfengwang edited a comment on pull request #691: fix: call cancel() as soon as possible to release the resources associatd with context

Posted by GitBox <gi...@apache.org>.
wenfengwang edited a comment on pull request #691:
URL: https://github.com/apache/rocketmq-client-go/pull/691#issuecomment-872190640


   It seems that the changes of this PR  included in https://github.com/apache/rocketmq-client-go/pull/691，could you separate them or close this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] fengberlin commented on pull request #691: fix: call cancel() as soon as possible to release the resources associatd with context

Posted by GitBox <gi...@apache.org>.
fengberlin commented on pull request #691:
URL: https://github.com/apache/rocketmq-client-go/pull/691#issuecomment-874201538


   #698


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] fengberlin commented on pull request #691: fix: call cancel() as soon as possible to release the resources associatd with context

Posted by GitBox <gi...@apache.org>.
fengberlin commented on pull request #691:
URL: https://github.com/apache/rocketmq-client-go/pull/691#issuecomment-870253416


   @xujianhai666


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] codecov-commenter commented on pull request #691: fix: call cancel() as soon as possible to release the resources associatd with context

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #691:
URL: https://github.com/apache/rocketmq-client-go/pull/691#issuecomment-870217011


   # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/691?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#691](https://codecov.io/gh/apache/rocketmq-client-go/pull/691?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (506e50e) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/c688c190734dcdb6e2fc9b2f6791544d648185a2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c688c19) will **increase** coverage by `0.02%`.
   > The diff coverage is `35.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-go/pull/691/graphs/tree.svg?width=650&height=150&src=pr&token=CiV9ofPkG3&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/rocketmq-client-go/pull/691?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #691      +/-   ##
   ==========================================
   + Coverage   24.71%   24.74%   +0.02%     
   ==========================================
     Files          48       48              
     Lines        5223     5234      +11     
   ==========================================
   + Hits         1291     1295       +4     
   - Misses       3726     3733       +7     
     Partials      206      206              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/691?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [internal/client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvY2xpZW50Lmdv) | `0.00% <0.00%> (ø)` | |
   | [internal/trace.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvdHJhY2UuZ28=) | `29.49% <0.00%> (-0.11%)` | :arrow_down: |
   | [internal/route.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvcm91dGUuZ28=) | `9.86% <100.00%> (+0.61%)` | :arrow_up: |
   | [producer/producer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvZHVjZXIvcHJvZHVjZXIuZ28=) | `28.57% <100.00%> (+0.44%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/691?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/691?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c688c19...506e50e](https://codecov.io/gh/apache/rocketmq-client-go/pull/691?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] fengberlin removed a comment on pull request #691: fix: call cancel() as soon as possible to release the resources associatd with context

Posted by GitBox <gi...@apache.org>.
fengberlin removed a comment on pull request #691:
URL: https://github.com/apache/rocketmq-client-go/pull/691#issuecomment-874201538


   #698


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] fengberlin commented on pull request #691: fix: call cancel() as soon as possible to release the resources associatd with context

Posted by GitBox <gi...@apache.org>.
fengberlin commented on pull request #691:
URL: https://github.com/apache/rocketmq-client-go/pull/691#issuecomment-872269751


   ok. I will separate them in [#692](https://github.com/apache/rocketmq-client-go/pull/692). Could you accept this PR first?
   @wenfengwang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] fengberlin commented on pull request #691: fix: call cancel() as soon as possible to release the resources associatd with context

Posted by GitBox <gi...@apache.org>.
fengberlin commented on pull request #691:
URL: https://github.com/apache/rocketmq-client-go/pull/691#issuecomment-874199396






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] wenfengwang edited a comment on pull request #691: fix: call cancel() as soon as possible to release the resources associatd with context

Posted by GitBox <gi...@apache.org>.
wenfengwang edited a comment on pull request #691:
URL: https://github.com/apache/rocketmq-client-go/pull/691#issuecomment-872190640


   It seems that the changes of this PR  included in https://github.com/apache/rocketmq-client-go/pull/691
   
   could you separate them or close this PR? 
   
   @fengberlin


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] codecov-commenter commented on pull request #691: fix: call cancel() as soon as possible to release the resources associatd with context

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #691:
URL: https://github.com/apache/rocketmq-client-go/pull/691#issuecomment-870217011


   # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/691?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#691](https://codecov.io/gh/apache/rocketmq-client-go/pull/691?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (506e50e) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/c688c190734dcdb6e2fc9b2f6791544d648185a2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c688c19) will **increase** coverage by `0.02%`.
   > The diff coverage is `35.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-go/pull/691/graphs/tree.svg?width=650&height=150&src=pr&token=CiV9ofPkG3&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/rocketmq-client-go/pull/691?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #691      +/-   ##
   ==========================================
   + Coverage   24.71%   24.74%   +0.02%     
   ==========================================
     Files          48       48              
     Lines        5223     5234      +11     
   ==========================================
   + Hits         1291     1295       +4     
   - Misses       3726     3733       +7     
     Partials      206      206              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/691?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [internal/client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvY2xpZW50Lmdv) | `0.00% <0.00%> (ø)` | |
   | [internal/trace.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvdHJhY2UuZ28=) | `29.49% <0.00%> (-0.11%)` | :arrow_down: |
   | [internal/route.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvcm91dGUuZ28=) | `9.86% <100.00%> (+0.61%)` | :arrow_up: |
   | [producer/producer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvZHVjZXIvcHJvZHVjZXIuZ28=) | `28.57% <100.00%> (+0.44%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/691?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/691?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c688c19...506e50e](https://codecov.io/gh/apache/rocketmq-client-go/pull/691?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] weichangdong removed a comment on pull request #691: [ISSUE #698] fix: call cancel() as soon as possible to release the resources associatd with context

Posted by GitBox <gi...@apache.org>.
weichangdong removed a comment on pull request #691:
URL: https://github.com/apache/rocketmq-client-go/pull/691#issuecomment-878013769


   0712


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] wenfengwang commented on pull request #691: fix: call cancel() as soon as possible to release the resources associatd with context

Posted by GitBox <gi...@apache.org>.
wenfengwang commented on pull request #691:
URL: https://github.com/apache/rocketmq-client-go/pull/691#issuecomment-873834796


   LGTM @ding @maixiaohai 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] fengberlin removed a comment on pull request #691: fix: call cancel() as soon as possible to release the resources associatd with context

Posted by GitBox <gi...@apache.org>.
fengberlin removed a comment on pull request #691:
URL: https://github.com/apache/rocketmq-client-go/pull/691#issuecomment-870253416






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] weichangdong commented on pull request #691: [ISSUE #698] fix: call cancel() as soon as possible to release the resources associatd with context

Posted by GitBox <gi...@apache.org>.
weichangdong commented on pull request #691:
URL: https://github.com/apache/rocketmq-client-go/pull/691#issuecomment-878013769


   0712


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] fengberlin commented on pull request #691: fix: call cancel() as soon as possible to release the resources associatd with context

Posted by GitBox <gi...@apache.org>.
fengberlin commented on pull request #691:
URL: https://github.com/apache/rocketmq-client-go/pull/691#issuecomment-872336455


   this PR can be remove the `duplicate` label?
   @wenfengwang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org