[jira] [Work logged] (HDFS-16402) Improve HeartbeatManager logic to avoid incorrect stats

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HDFS-16402?focusedWorklogId=713513&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-713513 ]

ASF GitHub Bot logged work on HDFS-16402:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Jan/22 06:26
            Start Date: 24/Jan/22 06:26
    Worklog Time Spent: 10m 
      Work Description: Hexiaoqiao merged pull request #3839:
URL: https://github.com/apache/hadoop/pull/3839


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 713513)
    Time Spent: 3h  (was: 2h 50m)

> Improve HeartbeatManager logic to avoid incorrect stats
> -------------------------------------------------------
>
>                 Key: HDFS-16402
>                 URL: https://issues.apache.org/jira/browse/HDFS-16402
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: tomscut
>            Assignee: tomscut
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: image-2021-12-29-08-25-44-303.png, image-2021-12-29-08-25-54-441.png
>
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> After reconfig {*}dfs.datanode.data.dir{*}, we found that the stats of the Namenode Web became *negative* and there were many NPE in namenode logs. This problem has been solved by HDFS-14042.
> !image-2021-12-29-08-25-54-441.png|width=681,height=293!
> !image-2021-12-29-08-25-44-303.png|width=677,height=180!
> However, if *HeartbeatManager#updateHeartbeat* and *HeartbeatManager#updateLifeline* throw other exceptions, stats errors can also occur. We should ensure that *stats.subtract()* and *stats.add()* are transactional.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org