You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/11/22 15:31:04 UTC
[GitHub] [camel-quarkus] aldettinger opened a new pull request #3316: core: Add RouteConfigurationsBuilder before regular RoutesBuilder whe…
aldettinger opened a new pull request #3316:
URL: https://github.com/apache/camel-quarkus/pull/3316
…n camel main is disabled #2978
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a change in pull request #3316: core: Add RouteConfigurationsBuilder before regular RoutesBuilder whe…
Posted by GitBox <gi...@apache.org>.
aldettinger commented on a change in pull request #3316:
URL: https://github.com/apache/camel-quarkus/pull/3316#discussion_r755059477
##########
File path: extensions-core/core/runtime/src/main/java/org/apache/camel/quarkus/core/CamelContextRecorder.java
##########
@@ -90,6 +93,8 @@ public void customize(RuntimeValue<CamelContext> context, RuntimeValue<CamelCont
return new RuntimeValue((CamelContextCustomizer) context -> context.setShutdownStrategy(new NoShutdownStrategy()));
}
Review comment:
Okay I've removed the useless methods. Thanks all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a change in pull request #3316: core: Add RouteConfigurationsBuilder before regular RoutesBuilder whe…
Posted by GitBox <gi...@apache.org>.
aldettinger commented on a change in pull request #3316:
URL: https://github.com/apache/camel-quarkus/pull/3316#discussion_r755066212
##########
File path: extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelContextProcessor.java
##########
@@ -165,17 +165,12 @@ public CamelRuntimeBuildItem runtime(
List<CamelRuntimeTaskBuildItem> runtimeTasks,
CamelConfig config) {
- for (CamelRoutesBuilderClassBuildItem item : routesBuilderClasses) {
- // don't add routes builders that are known by the container
- if (containerBeans.getClasses().contains(item.getDotName())) {
- continue;
- }
-
- recorder.addRoutes(context.getCamelContext(), item.getDotName().toString());
Review comment:
I've spread the logic from the loop above in the code block below. So, the logic is now executed only when config.routesDiscovery.enabled = true.
However, to my current understanding, when config.routesDiscovery.enabled = false, then the routesBuilderClasses list is empty. As such, the logic in the loop above was not executed when config.routesDiscovery.enabled = false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #3316: core: Add RouteConfigurationsBuilder before regular RoutesBuilder whe…
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #3316:
URL: https://github.com/apache/camel-quarkus/pull/3316#discussion_r754978121
##########
File path: extensions-core/core/runtime/src/main/java/org/apache/camel/quarkus/core/CamelContextRecorder.java
##########
@@ -90,6 +93,8 @@ public void customize(RuntimeValue<CamelContext> context, RuntimeValue<CamelCont
return new RuntimeValue((CamelContextCustomizer) context -> context.setShutdownStrategy(new NoShutdownStrategy()));
}
Review comment:
Agreed - I think for internal stuff in the past like recorder methods, we have removed them without deprecation. It's not public API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger merged pull request #3316: core: Add RouteConfigurationsBuilder before regular RoutesBuilder whe…
Posted by GitBox <gi...@apache.org>.
aldettinger merged pull request #3316:
URL: https://github.com/apache/camel-quarkus/pull/3316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on a change in pull request #3316: core: Add RouteConfigurationsBuilder before regular RoutesBuilder whe…
Posted by GitBox <gi...@apache.org>.
zbendhiba commented on a change in pull request #3316:
URL: https://github.com/apache/camel-quarkus/pull/3316#discussion_r754973106
##########
File path: extensions-core/core/runtime/src/main/java/org/apache/camel/quarkus/core/CamelContextRecorder.java
##########
@@ -90,6 +93,8 @@ public void customize(RuntimeValue<CamelContext> context, RuntimeValue<CamelCont
return new RuntimeValue((CamelContextCustomizer) context -> context.setShutdownStrategy(new NoShutdownStrategy()));
}
Review comment:
If it's for internal use only, I'd vote for removing them.
If the user can use them, I'd say maybe deprecate and remove when introducing 3.14, the next LTS ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a change in pull request #3316: core: Add RouteConfigurationsBuilder before regular RoutesBuilder whe…
Posted by GitBox <gi...@apache.org>.
aldettinger commented on a change in pull request #3316:
URL: https://github.com/apache/camel-quarkus/pull/3316#discussion_r754390810
##########
File path: extensions-core/core/runtime/src/main/java/org/apache/camel/quarkus/core/CamelContextRecorder.java
##########
@@ -90,6 +93,8 @@ public void customize(RuntimeValue<CamelContext> context, RuntimeValue<CamelCont
return new RuntimeValue((CamelContextCustomizer) context -> context.setShutdownStrategy(new NoShutdownStrategy()));
}
Review comment:
I've marked those recorded methods as deprecated. Maybe it's even ok to remove them ? I don't know what we have done in the past for that kind of situations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org