[jira] [Commented] (YARN-9118) Handle issues with parsing user defined GPU devices in GpuDiscoverer

["Peter Bacsko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748070#comment-16748070 ] 

Peter Bacsko commented on YARN-9118:
------------------------------------

There is this condition:
{noformat}
if (lastDiscoveredGpuInformation.getGpus() != null) {
{noformat}

Now, what if it's actually null? Could that happen? If so, is that an erroneous condition where we should fail? Or just log something?

> Handle issues with parsing user defined GPU devices in GpuDiscoverer
> --------------------------------------------------------------------
>
>                 Key: YARN-9118
>                 URL: https://issues.apache.org/jira/browse/YARN-9118
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Szilard Nemeth
>            Assignee: Szilard Nemeth
>            Priority: Major
>         Attachments: YARN-9118.001.patch, YARN-9118.002.patch, YARN-9118.003.patch, YARN-9118.004.patch
>
>
> getGpusUsableByYarn has the following issues: 
> - Duplicate GPU device definitions are not denied: This seems to be the biggest issue as it could increase the number of devices on the node if the device ID is defined 2 or more times.
> - An empty-string is accepted, it works like the user would not want to use auto-discovery and haven't defined any GPU devices: This will result in an empty device list, but the empty-string check is never explicitly there in the code, so this behavior just coincidental.
> - Number validation does not happen on GPU device IDs (separated by commas)
> Many testcases are added as the coverage was already very low.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org