[GitHub] [tvm] giuseros commented on issue #8062: AOT C Codegen Type Issue

[GitBox <gi...@apache.org>]

giuseros commented on issue #8062:
URL: https://github.com/apache/tvm/issues/8062#issuecomment-845249393


   Hi all,
   The main problem is that the Graph Memory Planner( in Relay ) sees the output of the graph as a further temporary variable. When using the graph executor this temporary area is then copied to the user real output, but in AOT that *is* the real output. 
   
   Why is this a problem? Because GMP can expand temporaries to that they can be shared. Thinking the output is a temporary it expands the output as well, but the output is not expandable in AOT (since it is provided by the user). 
   
   We were able to reproduce this with mobilenet quantized. The fix we come up with in #8096 is to remove the dependency from the GMP and use the TIR StorageRewrite pass on the runner function, which does not suffer of this problem. 
   
   The memory foot print is the same, so we basically got two birds with one stone. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org