You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/12/07 18:49:36 UTC
[kudu-CR] Replace boost::iequals with our own implementation
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16826
Change subject: Replace boost::iequals with our own implementation
......................................................................
Replace boost::iequals with our own implementation
This patch replaces uses of boost::iequals with our own implementation.
This is a step in our ongoing work to reduce dependence on boost.
Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
---
M src/kudu/clock/hybrid_clock.cc
M src/kudu/hms/hms_client.cc
M src/kudu/integration-tests/hms_itest-base.cc
M src/kudu/rpc/sasl_common.cc
M src/kudu/security/tls_context.cc
M src/kudu/server/default_path_handlers.cc
M src/kudu/server/server_base.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/table_scanner.cc
M src/kudu/tools/tool_action_cluster.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_hms.cc
M src/kudu/tools/tool_action_master.cc
M src/kudu/tools/tool_action_table.cc
M src/kudu/tools/tool_action_test.cc
M src/kudu/tools/tool_action_tserver.cc
M src/kudu/util/flags.cc
M src/kudu/util/string_case-test.cc
M src/kudu/util/string_case.cc
M src/kudu/util/string_case.h
21 files changed, 141 insertions(+), 104 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/16826/1
--
To view, visit http://gerrit.cloudera.org:8080/16826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
Gerrit-Change-Number: 16826
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] Replace boost::iequals with our own implementation
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: Replace boost::iequals with our own implementation
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/16826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
Gerrit-Change-Number: 16826
Gerrit-PatchSet: 10
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] Replace boost::iequals with our own implementation
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16826 )
Change subject: Replace boost::iequals with our own implementation
......................................................................
Patch Set 5: Code-Review+2
(3 comments)
http://gerrit.cloudera.org:8080/#/c/16826/5//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16826/5//COMMIT_MSG@13
PS5, Line 13: ascii
nit: ASCII
http://gerrit.cloudera.org:8080/#/c/16826/5/src/kudu/util/string_case-test.cc
File src/kudu/util/string_case-test.cc:
http://gerrit.cloudera.org:8080/#/c/16826/5/src/kudu/util/string_case-test.cc@66
PS5, Line 66: string foo = "foo";
: string capital = "Foo";
: string caps = "FOO";
: string mix = "FoO";
: string zero = "FO0";
nit: if there is an idea to test for 'const' qualifier of the parameters of iequals() as well, maybe make these 'const string'
http://gerrit.cloudera.org:8080/#/c/16826/2/src/kudu/util/string_case.cc
File src/kudu/util/string_case.cc:
http://gerrit.cloudera.org:8080/#/c/16826/2/src/kudu/util/string_case.cc@86
PS2, Line 86: DCHECK(IsAscii(*word));
> good idea. I added these checks to the other methods as well.
Cool, thanks!
--
To view, visit http://gerrit.cloudera.org:8080/16826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
Gerrit-Change-Number: 16826
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 Dec 2020 04:04:35 +0000
Gerrit-HasComments: Yes
[kudu-CR] Replace boost::iequals with our own implementation
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16826 )
Change subject: Replace boost::iequals with our own implementation
......................................................................
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/16826/5//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16826/5//COMMIT_MSG@13
PS5, Line 13: ascii
> nit: ASCII
Done
http://gerrit.cloudera.org:8080/#/c/16826/5/src/kudu/util/string_case-test.cc
File src/kudu/util/string_case-test.cc:
http://gerrit.cloudera.org:8080/#/c/16826/5/src/kudu/util/string_case-test.cc@66
PS5, Line 66: string foo = "foo";
: string capital = "Foo";
: string caps = "FOO";
: string mix = "FoO";
: string zero = "FO0";
> nit: if there is an idea to test for 'const' qualifier of the parameters o
Done
--
To view, visit http://gerrit.cloudera.org:8080/16826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
Gerrit-Change-Number: 16826
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 Dec 2020 18:00:20 +0000
Gerrit-HasComments: Yes
[kudu-CR] Replace boost::iequals with our own implementation
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16826 )
Change subject: Replace boost::iequals with our own implementation
......................................................................
Patch Set 10: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
Gerrit-Change-Number: 16826
Gerrit-PatchSet: 10
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 Dec 2020 20:07:06 +0000
Gerrit-HasComments: No
[kudu-CR] Replace boost::iequals with our own implementation
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16826 )
Change subject: Replace boost::iequals with our own implementation
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
Gerrit-Change-Number: 16826
Gerrit-PatchSet: 8
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 Dec 2020 19:04:46 +0000
Gerrit-HasComments: No
[kudu-CR] Replace boost::iequals with our own implementation
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16826
to look at the new patch set (#10).
Change subject: Replace boost::iequals with our own implementation
......................................................................
Replace boost::iequals with our own implementation
This patch replaces uses of boost::iequals with our own implementation.
This is a step in our ongoing work to reduce dependence on boost.
Note that we don’t need to worry about locale awareness or performance
given all usage today is against ASCII strings (not locale specific) and are
not in performance sensitive code paths.
Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
---
M src/kudu/clock/hybrid_clock.cc
M src/kudu/hms/hms_client.cc
M src/kudu/integration-tests/hms_itest-base.cc
M src/kudu/rpc/sasl_common.cc
M src/kudu/security/tls_context.cc
M src/kudu/server/default_path_handlers.cc
M src/kudu/server/server_base.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/table_scanner.cc
M src/kudu/tools/tool_action_cluster.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_hms.cc
M src/kudu/tools/tool_action_master.cc
M src/kudu/tools/tool_action_table.cc
M src/kudu/tools/tool_action_test.cc
M src/kudu/tools/tool_action_tserver.cc
M src/kudu/util/flags.cc
M src/kudu/util/string_case-test.cc
M src/kudu/util/string_case.cc
M src/kudu/util/string_case.h
22 files changed, 164 insertions(+), 108 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/16826/10
--
To view, visit http://gerrit.cloudera.org:8080/16826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
Gerrit-Change-Number: 16826
Gerrit-PatchSet: 10
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] Replace boost::iequals with our own implementation
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16826 )
Change subject: Replace boost::iequals with our own implementation
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/16826/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16826/2//COMMIT_MSG@7
PS2, Line 7: our own implementation
> Cool, thank you for the clarification. Does it make sense to reflect this
Done
http://gerrit.cloudera.org:8080/#/c/16826/2/src/kudu/util/string_case.h
File src/kudu/util/string_case.h:
http://gerrit.cloudera.org:8080/#/c/16826/2/src/kudu/util/string_case.h@61
PS2, Line 61: iequals
> Since it's targeted to work as expected only with ASCII symbols, maybe rena
I like the idea of adding the DCHECK but keeping the name the same. The other methods in this class also expect ascii but do not add that to the name. In the future we can enhance the impl if needed.
http://gerrit.cloudera.org:8080/#/c/16826/2/src/kudu/util/string_case.cc
File src/kudu/util/string_case.cc:
http://gerrit.cloudera.org:8080/#/c/16826/2/src/kudu/util/string_case.cc@86
PS2, Line 86: bool iequals(const string& a, const string& b) {
> Since it's targeted to work only with ASCII characters, does it make sense
good idea. I added these checks to the other methods as well.
--
To view, visit http://gerrit.cloudera.org:8080/16826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
Gerrit-Change-Number: 16826
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 Dec 2020 03:46:41 +0000
Gerrit-HasComments: Yes
[kudu-CR] Replace boost::iequals with our own implementation
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16826
to look at the new patch set (#3).
Change subject: Replace boost::iequals with our own implementation
......................................................................
Replace boost::iequals with our own implementation
This patch replaces uses of boost::iequals with our own implementation.
This is a step in our ongoing work to reduce dependence on boost.
Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
---
M src/kudu/clock/hybrid_clock.cc
M src/kudu/hms/hms_client.cc
M src/kudu/integration-tests/hms_itest-base.cc
M src/kudu/rpc/sasl_common.cc
M src/kudu/security/tls_context.cc
M src/kudu/server/default_path_handlers.cc
M src/kudu/server/server_base.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/table_scanner.cc
M src/kudu/tools/tool_action_cluster.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_hms.cc
M src/kudu/tools/tool_action_master.cc
M src/kudu/tools/tool_action_table.cc
M src/kudu/tools/tool_action_test.cc
M src/kudu/tools/tool_action_tserver.cc
M src/kudu/util/flags.cc
M src/kudu/util/string_case-test.cc
M src/kudu/util/string_case.cc
M src/kudu/util/string_case.h
21 files changed, 143 insertions(+), 104 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/16826/3
--
To view, visit http://gerrit.cloudera.org:8080/16826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
Gerrit-Change-Number: 16826
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] Replace boost::iequals with our own implementation
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16826 )
Change subject: Replace boost::iequals with our own implementation
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
Gerrit-Change-Number: 16826
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 Dec 2020 18:10:26 +0000
Gerrit-HasComments: No
[kudu-CR] Replace boost::iequals with our own implementation
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16826 )
Change subject: Replace boost::iequals with our own implementation
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/16826/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16826/2//COMMIT_MSG@7
PS2, Line 7: our own implementation
Do we need to have the new function locale-aware like boost::iequals?
https://www.boost.org/doc/libs/1_60_0/doc/html/boost/algorithm/iequals.html
http://gerrit.cloudera.org:8080/#/c/16826/2//COMMIT_MSG@9
PS2, Line 9: boost::iequals with our own implementation
Could you add a test to assess the performance of the new implementation compared with boost::iequals?
--
To view, visit http://gerrit.cloudera.org:8080/16826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
Gerrit-Change-Number: 16826
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 07 Dec 2020 20:51:32 +0000
Gerrit-HasComments: Yes
[kudu-CR] Replace boost::iequals with our own implementation
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16826
to look at the new patch set (#7).
Change subject: Replace boost::iequals with our own implementation
......................................................................
Replace boost::iequals with our own implementation
This patch replaces uses of boost::iequals with our own implementation.
This is a step in our ongoing work to reduce dependence on boost.
Note that we don’t need to worry about locale awareness or performance
given all usage today is against ASCII strings (not locale specific) and are
not in performance sensitive code paths.
Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
---
M src/kudu/clock/hybrid_clock.cc
M src/kudu/hms/hms_client.cc
M src/kudu/integration-tests/hms_itest-base.cc
M src/kudu/rpc/sasl_common.cc
M src/kudu/security/tls_context.cc
M src/kudu/server/default_path_handlers.cc
M src/kudu/server/server_base.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/table_scanner.cc
M src/kudu/tools/tool_action_cluster.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_hms.cc
M src/kudu/tools/tool_action_master.cc
M src/kudu/tools/tool_action_table.cc
M src/kudu/tools/tool_action_test.cc
M src/kudu/tools/tool_action_tserver.cc
M src/kudu/util/flags.cc
M src/kudu/util/string_case-test.cc
M src/kudu/util/string_case.cc
M src/kudu/util/string_case.h
22 files changed, 168 insertions(+), 107 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/16826/7
--
To view, visit http://gerrit.cloudera.org:8080/16826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
Gerrit-Change-Number: 16826
Gerrit-PatchSet: 7
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] Replace boost::iequals with our own implementation
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16826
to look at the new patch set (#4).
Change subject: Replace boost::iequals with our own implementation
......................................................................
Replace boost::iequals with our own implementation
This patch replaces uses of boost::iequals with our own implementation.
This is a step in our ongoing work to reduce dependence on boost.
Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
---
M src/kudu/clock/hybrid_clock.cc
M src/kudu/hms/hms_client.cc
M src/kudu/integration-tests/hms_itest-base.cc
M src/kudu/rpc/sasl_common.cc
M src/kudu/security/tls_context.cc
M src/kudu/server/default_path_handlers.cc
M src/kudu/server/server_base.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/table_scanner.cc
M src/kudu/tools/tool_action_cluster.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_hms.cc
M src/kudu/tools/tool_action_master.cc
M src/kudu/tools/tool_action_table.cc
M src/kudu/tools/tool_action_test.cc
M src/kudu/tools/tool_action_tserver.cc
M src/kudu/util/flags.cc
M src/kudu/util/string_case-test.cc
M src/kudu/util/string_case.cc
M src/kudu/util/string_case.h
21 files changed, 158 insertions(+), 104 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/16826/4
--
To view, visit http://gerrit.cloudera.org:8080/16826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
Gerrit-Change-Number: 16826
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] Replace boost::iequals with our own implementation
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16826 )
Change subject: Replace boost::iequals with our own implementation
......................................................................
Patch Set 3:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/16826/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16826/2//COMMIT_MSG@7
PS2, Line 7: our own implementation
> Do we need to have the new function locale-aware like boost::iequals?
We don't need locale aware. All usage today is against known no-locale specific string values (flags, configs, tests, etc).
http://gerrit.cloudera.org:8080/#/c/16826/2//COMMIT_MSG@9
PS2, Line 9: boost::iequals with our own implementation
> Could you add a test to assess the performance of the new implementation co
All usage is on non-performant sensitive code paths (flags, configs, tests, etc).
http://gerrit.cloudera.org:8080/#/c/16826/2/src/kudu/util/string_case-test.cc
File src/kudu/util/string_case-test.cc:
http://gerrit.cloudera.org:8080/#/c/16826/2/src/kudu/util/string_case-test.cc@78
PS2, Line 78: ASSERT_TRUE(iequals(caps, mix));
> nit: only remaining combination that isn't tested is 'mix' and 'capital'.
Done
http://gerrit.cloudera.org:8080/#/c/16826/2/src/kudu/util/string_case.cc
File src/kudu/util/string_case.cc:
http://gerrit.cloudera.org:8080/#/c/16826/2/src/kudu/util/string_case.cc@87
PS2, Line 87: if (b.size() != a.size()) {
> nit: from a consistency point of view is it better to include curly braces
Done
--
To view, visit http://gerrit.cloudera.org:8080/16826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
Gerrit-Change-Number: 16826
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Mon, 07 Dec 2020 22:58:59 +0000
Gerrit-HasComments: Yes
[kudu-CR] Replace boost::iequals with our own implementation
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16826
to look at the new patch set (#2).
Change subject: Replace boost::iequals with our own implementation
......................................................................
Replace boost::iequals with our own implementation
This patch replaces uses of boost::iequals with our own implementation.
This is a step in our ongoing work to reduce dependence on boost.
Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
---
M src/kudu/clock/hybrid_clock.cc
M src/kudu/hms/hms_client.cc
M src/kudu/integration-tests/hms_itest-base.cc
M src/kudu/rpc/sasl_common.cc
M src/kudu/security/tls_context.cc
M src/kudu/server/default_path_handlers.cc
M src/kudu/server/server_base.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/table_scanner.cc
M src/kudu/tools/tool_action_cluster.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_hms.cc
M src/kudu/tools/tool_action_master.cc
M src/kudu/tools/tool_action_table.cc
M src/kudu/tools/tool_action_test.cc
M src/kudu/tools/tool_action_tserver.cc
M src/kudu/util/flags.cc
M src/kudu/util/string_case-test.cc
M src/kudu/util/string_case.cc
M src/kudu/util/string_case.h
21 files changed, 141 insertions(+), 104 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/16826/2
--
To view, visit http://gerrit.cloudera.org:8080/16826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
Gerrit-Change-Number: 16826
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Replace boost::iequals with our own implementation
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16826
to look at the new patch set (#8).
Change subject: Replace boost::iequals with our own implementation
......................................................................
Replace boost::iequals with our own implementation
This patch replaces uses of boost::iequals with our own implementation.
This is a step in our ongoing work to reduce dependence on boost.
Note that we don’t need to worry about locale awareness or performance
given all usage today is against ASCII strings (not locale specific) and are
not in performance sensitive code paths.
Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
---
M src/kudu/clock/hybrid_clock.cc
M src/kudu/hms/hms_client.cc
M src/kudu/integration-tests/hms_itest-base.cc
M src/kudu/rpc/sasl_common.cc
M src/kudu/security/tls_context.cc
M src/kudu/server/default_path_handlers.cc
M src/kudu/server/server_base.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/table_scanner.cc
M src/kudu/tools/tool_action_cluster.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_hms.cc
M src/kudu/tools/tool_action_master.cc
M src/kudu/tools/tool_action_table.cc
M src/kudu/tools/tool_action_test.cc
M src/kudu/tools/tool_action_tserver.cc
M src/kudu/util/flags.cc
M src/kudu/util/string_case-test.cc
M src/kudu/util/string_case.cc
M src/kudu/util/string_case.h
21 files changed, 161 insertions(+), 106 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/16826/8
--
To view, visit http://gerrit.cloudera.org:8080/16826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
Gerrit-Change-Number: 16826
Gerrit-PatchSet: 8
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] Replace boost::iequals with our own implementation
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16826 )
Change subject: Replace boost::iequals with our own implementation
......................................................................
Patch Set 10: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
Gerrit-Change-Number: 16826
Gerrit-PatchSet: 10
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 Dec 2020 19:59:24 +0000
Gerrit-HasComments: No
[kudu-CR] Replace boost::iequals with our own implementation
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16826 )
Change subject: Replace boost::iequals with our own implementation
......................................................................
Replace boost::iequals with our own implementation
This patch replaces uses of boost::iequals with our own implementation.
This is a step in our ongoing work to reduce dependence on boost.
Note that we don’t need to worry about locale awareness or performance
given all usage today is against ASCII strings (not locale specific) and are
not in performance sensitive code paths.
Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
Reviewed-on: http://gerrit.cloudera.org:8080/16826
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Grant Henke <gr...@apache.org>
---
M src/kudu/clock/hybrid_clock.cc
M src/kudu/hms/hms_client.cc
M src/kudu/integration-tests/hms_itest-base.cc
M src/kudu/rpc/sasl_common.cc
M src/kudu/security/tls_context.cc
M src/kudu/server/default_path_handlers.cc
M src/kudu/server/server_base.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/table_scanner.cc
M src/kudu/tools/tool_action_cluster.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_hms.cc
M src/kudu/tools/tool_action_master.cc
M src/kudu/tools/tool_action_table.cc
M src/kudu/tools/tool_action_test.cc
M src/kudu/tools/tool_action_tserver.cc
M src/kudu/util/flags.cc
M src/kudu/util/string_case-test.cc
M src/kudu/util/string_case.cc
M src/kudu/util/string_case.h
22 files changed, 164 insertions(+), 108 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Grant Henke: Verified
--
To view, visit http://gerrit.cloudera.org:8080/16826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
Gerrit-Change-Number: 16826
Gerrit-PatchSet: 11
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] Replace boost::iequals with our own implementation
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16826 )
Change subject: Replace boost::iequals with our own implementation
......................................................................
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/16826/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16826/2//COMMIT_MSG@7
PS2, Line 7: our own implementation
> We don't need locale aware. All usage today is against known no-locale spec
Cool, thank you for the clarification. Does it make sense to reflect this fact in the commit description as well?
http://gerrit.cloudera.org:8080/#/c/16826/2//COMMIT_MSG@9
PS2, Line 9: boost::iequals with our own implementation
> All usage is on non-performant sensitive code paths (flags, configs, tests,
Ah, indeed: makes sense.
http://gerrit.cloudera.org:8080/#/c/16826/2/src/kudu/util/string_case.h
File src/kudu/util/string_case.h:
http://gerrit.cloudera.org:8080/#/c/16826/2/src/kudu/util/string_case.h@61
PS2, Line 61: iequals
Since it's targeted to work as expected only with ASCII symbols, maybe rename this into ascii_iequals()?
http://gerrit.cloudera.org:8080/#/c/16826/2/src/kudu/util/string_case.cc
File src/kudu/util/string_case.cc:
http://gerrit.cloudera.org:8080/#/c/16826/2/src/kudu/util/string_case.cc@86
PS2, Line 86: bool iequals(const string& a, const string& b) {
Since it's targeted to work only with ASCII characters, does it make sense to add
DCHECK(IsAscii(a));
DCHECK(IsAscii(b));
?
--
To view, visit http://gerrit.cloudera.org:8080/16826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
Gerrit-Change-Number: 16826
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Mon, 07 Dec 2020 23:52:00 +0000
Gerrit-HasComments: Yes
[kudu-CR] Replace boost::iequals with our own implementation
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16826
to look at the new patch set (#6).
Change subject: Replace boost::iequals with our own implementation
......................................................................
Replace boost::iequals with our own implementation
This patch replaces uses of boost::iequals with our own implementation.
This is a step in our ongoing work to reduce dependence on boost.
Note that we don’t need to worry about locale awareness or performance
given all usage today is against ASCII strings (not locale specific) and are
not in performance sensitive code paths.
Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
---
M src/kudu/clock/hybrid_clock.cc
M src/kudu/hms/hms_client.cc
M src/kudu/integration-tests/hms_itest-base.cc
M src/kudu/rpc/sasl_common.cc
M src/kudu/security/tls_context.cc
M src/kudu/server/default_path_handlers.cc
M src/kudu/server/server_base.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/table_scanner.cc
M src/kudu/tools/tool_action_cluster.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_hms.cc
M src/kudu/tools/tool_action_master.cc
M src/kudu/tools/tool_action_table.cc
M src/kudu/tools/tool_action_test.cc
M src/kudu/tools/tool_action_tserver.cc
M src/kudu/util/flags.cc
M src/kudu/util/string_case-test.cc
M src/kudu/util/string_case.cc
M src/kudu/util/string_case.h
21 files changed, 158 insertions(+), 104 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/16826/6
--
To view, visit http://gerrit.cloudera.org:8080/16826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
Gerrit-Change-Number: 16826
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] Replace boost::iequals with our own implementation
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16826
to look at the new patch set (#5).
Change subject: Replace boost::iequals with our own implementation
......................................................................
Replace boost::iequals with our own implementation
This patch replaces uses of boost::iequals with our own implementation.
This is a step in our ongoing work to reduce dependence on boost.
Note that we don’t need to worry about locale awareness or performance
given all usage today is against ascii strings (not locale specific) and are
not in performance sensitive code paths.
Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
---
M src/kudu/clock/hybrid_clock.cc
M src/kudu/hms/hms_client.cc
M src/kudu/integration-tests/hms_itest-base.cc
M src/kudu/rpc/sasl_common.cc
M src/kudu/security/tls_context.cc
M src/kudu/server/default_path_handlers.cc
M src/kudu/server/server_base.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/table_scanner.cc
M src/kudu/tools/tool_action_cluster.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_hms.cc
M src/kudu/tools/tool_action_master.cc
M src/kudu/tools/tool_action_table.cc
M src/kudu/tools/tool_action_test.cc
M src/kudu/tools/tool_action_tserver.cc
M src/kudu/util/flags.cc
M src/kudu/util/string_case-test.cc
M src/kudu/util/string_case.cc
M src/kudu/util/string_case.h
21 files changed, 158 insertions(+), 104 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/16826/5
--
To view, visit http://gerrit.cloudera.org:8080/16826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
Gerrit-Change-Number: 16826
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] Replace boost::iequals with our own implementation
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16826
to look at the new patch set (#9).
Change subject: Replace boost::iequals with our own implementation
......................................................................
Replace boost::iequals with our own implementation
This patch replaces uses of boost::iequals with our own implementation.
This is a step in our ongoing work to reduce dependence on boost.
Note that we don’t need to worry about locale awareness or performance
given all usage today is against ASCII strings (not locale specific) and are
not in performance sensitive code paths.
Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
---
M src/kudu/clock/hybrid_clock.cc
M src/kudu/hms/hms_client.cc
M src/kudu/integration-tests/hms_itest-base.cc
M src/kudu/rpc/sasl_common.cc
M src/kudu/security/tls_context.cc
M src/kudu/server/default_path_handlers.cc
M src/kudu/server/server_base.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/table_scanner.cc
M src/kudu/tools/tool_action_cluster.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_hms.cc
M src/kudu/tools/tool_action_master.cc
M src/kudu/tools/tool_action_table.cc
M src/kudu/tools/tool_action_test.cc
M src/kudu/tools/tool_action_tserver.cc
M src/kudu/util/flags.cc
M src/kudu/util/string_case-test.cc
M src/kudu/util/string_case.cc
M src/kudu/util/string_case.h
22 files changed, 162 insertions(+), 107 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/16826/9
--
To view, visit http://gerrit.cloudera.org:8080/16826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
Gerrit-Change-Number: 16826
Gerrit-PatchSet: 9
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] Replace boost::iequals with our own implementation
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16826 )
Change subject: Replace boost::iequals with our own implementation
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/16826/2/src/kudu/util/string_case-test.cc
File src/kudu/util/string_case-test.cc:
http://gerrit.cloudera.org:8080/#/c/16826/2/src/kudu/util/string_case-test.cc@78
PS2, Line 78:
nit: only remaining combination that isn't tested is 'mix' and 'capital'.
http://gerrit.cloudera.org:8080/#/c/16826/2/src/kudu/util/string_case.cc
File src/kudu/util/string_case.cc:
http://gerrit.cloudera.org:8080/#/c/16826/2/src/kudu/util/string_case.cc@87
PS2, Line 87: if (b.size() != a.size())
nit: from a consistency point of view is it better to include curly braces for this if statement? Or moving the return statement to the same line as the condition.
--
To view, visit http://gerrit.cloudera.org:8080/16826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d2fdd30b739cee53e1551f784dbebfbe76e9233
Gerrit-Change-Number: 16826
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Mon, 07 Dec 2020 22:26:27 +0000
Gerrit-HasComments: Yes